Ensure pre-test is the first item in conditional mark check by davidm-arista · Pull Request #20382 · sonic-net/sonic-mgmt

davidm-arista · 2025-08-22T22:52:56Z

Summary:
Ensure pre-test is first item in conditional mark check, because pre-test runs before everything else, and it makes the most sense at the top of the file.

Also this change goes with #20326
This change will allow that PR to pass its PR checks.

Type of change

Testbed and Framework(new/improvement)

Back port request

Approach

What is the motivation for this PR?

To allow #20326 to pass the PR checks

How did you verify/test it?

Running it manually on PR 20326

Any platform specific information?

No

Supported testbed topology if it's a new test case?

N/A

mssonicbld · 2025-08-22T22:53:03Z

/azp run

davidm-arista · 2025-08-26T23:11:46Z

/azp run

azure-pipelines · 2025-08-26T23:11:52Z

Commenter does not have sufficient privileges for PR 20382 in repo sonic-net/sonic-mgmt

davidm-arista · 2025-08-26T23:15:37Z

/azpw run

mssonicbld · 2025-08-26T23:15:40Z

/AzurePipelines run

azure-pipelines · 2025-08-26T23:15:55Z

Azure Pipelines successfully started running 1 pipeline(s).

sdszhang

lgtm

mssonicbld · 2025-08-27T16:29:32Z

/azp run

azure-pipelines · 2025-08-27T16:29:46Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-08-30T01:01:37Z

/azp run

azure-pipelines · 2025-08-30T01:01:51Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-09-07T16:40:58Z

/azp run

azure-pipelines · 2025-09-07T16:41:11Z

Azure Pipelines successfully started running 1 pipeline(s).

sdszhang · 2025-09-09T12:07:24Z

There are two other PRs depends on this PR to use the new syntax. Will need it to be merged into the release branch, such as 202505 or 202412. Otherwise, will need a separate PR for release branches.
Skipping PFCWD tests for lossy topos & add anchor section by davidm-arista · Pull Request #2032…
[TH5] Skip VxLAN Tests for Non-Applicable Topologies by ccroy-arista · Pull Request #20552 · sonic-…

…t#20382) Ensure pre-test is first item in conditional mark check, because pre-test runs before everything else, and it makes the most sense at the top of the file. Also this change goes with sonic-net#20326 This change will allow that PR to pass its PR checks.

mssonicbld · 2025-09-09T12:09:30Z

Cherry-pick PR to 202505: #20581

Description of PR Summary: update pre-commit version to include the fix for sonic-net#20382 Approach What is the motivation for this PR? update pre-commit version to include the fix for sonic-net#20382 How did you do it? update referencing version. signed-off-by: [email protected]

…t#20382) Ensure pre-test is first item in conditional mark check, because pre-test runs before everything else, and it makes the most sense at the top of the file. Also this change goes with sonic-net#20326 This change will allow that PR to pass its PR checks. Signed-off-by: opcoder0 <[email protected]>

Description of PR Summary: update pre-commit version to include the fix for sonic-net#20382 Approach What is the motivation for this PR? update pre-commit version to include the fix for sonic-net#20382 How did you do it? update referencing version. signed-off-by: [email protected] Signed-off-by: opcoder0 <[email protected]>

…t#20382) Ensure pre-test is first item in conditional mark check, because pre-test runs before everything else, and it makes the most sense at the top of the file. Also this change goes with sonic-net#20326 This change will allow that PR to pass its PR checks. Signed-off-by: Guy Shemesh <[email protected]>

Description of PR Summary: update pre-commit version to include the fix for sonic-net#20382 Approach What is the motivation for this PR? update pre-commit version to include the fix for sonic-net#20382 How did you do it? update referencing version. signed-off-by: [email protected] Signed-off-by: Guy Shemesh <[email protected]>

…t#20382) Ensure pre-test is first item in conditional mark check, because pre-test runs before everything else, and it makes the most sense at the top of the file. Also this change goes with sonic-net#20326 This change will allow that PR to pass its PR checks. Signed-off-by: Aharon Malkin <[email protected]>

Description of PR Summary: update pre-commit version to include the fix for sonic-net#20382 Approach What is the motivation for this PR? update pre-commit version to include the fix for sonic-net#20382 How did you do it? update referencing version. signed-off-by: [email protected] Signed-off-by: Aharon Malkin <[email protected]>

…t#20382) Ensure pre-test is first item in conditional mark check, because pre-test runs before everything else, and it makes the most sense at the top of the file. Also this change goes with sonic-net#20326 This change will allow that PR to pass its PR checks. Signed-off-by: Guy Shemesh <[email protected]>

Description of PR Summary: update pre-commit version to include the fix for sonic-net#20382 Approach What is the motivation for this PR? update pre-commit version to include the fix for sonic-net#20382 How did you do it? update referencing version. signed-off-by: [email protected] Signed-off-by: Guy Shemesh <[email protected]>

…t#20382) Ensure pre-test is first item in conditional mark check, because pre-test runs before everything else, and it makes the most sense at the top of the file. Also this change goes with sonic-net#20326 This change will allow that PR to pass its PR checks.

Description of PR Summary: update pre-commit version to include the fix for sonic-net#20382 Approach What is the motivation for this PR? update pre-commit version to include the fix for sonic-net#20382 How did you do it? update referencing version. signed-off-by: [email protected]

PR sonic-net#20326 introduced anchors in the conditional mark yaml files. The anchors are defined in a dummy entry for test_pretest.py. PR sonic-net#20382 updated code to add exception for the sort checking of test_pretest.py in conditional mark yaml files. These changes made it complicated when we do need to skip something for test_pretest.py. This change fixed the problem by using a real dummy entry for defining the yaml anchors. The code of skipping test_pretest.py in sort checking in conditional mark yaml file is also removed. This change also improved a variable name in conditional mark and fixed a few typos. Signed-off-by: Xin Wang <[email protected]>

PR #20326 introduced anchors in the conditional mark yaml files. The anchors are defined in a dummy entry for test_pretest.py. PR #20382 updated code to add exception for the sort checking of test_pretest.py in conditional mark yaml files. These changes made it complicated when we do need to skip something for test_pretest.py. This change fixed the problem by using a real dummy entry for defining the yaml anchors. The code of skipping test_pretest.py in sort checking in conditional mark yaml file is also removed. This change also improved a variable name in conditional mark and fixed a few typos. Signed-off-by: Xin Wang <[email protected]>

PR sonic-net#20326 introduced anchors in the conditional mark yaml files. The anchors are defined in a dummy entry for test_pretest.py. PR sonic-net#20382 updated code to add exception for the sort checking of test_pretest.py in conditional mark yaml files. These changes made it complicated when we do need to skip something for test_pretest.py. This change fixed the problem by using a real dummy entry for defining the yaml anchors. The code of skipping test_pretest.py in sort checking in conditional mark yaml file is also removed. This change also improved a variable name in conditional mark and fixed a few typos. Signed-off-by: Xin Wang <[email protected]> Signed-off-by: Priyansh Tratiya <[email protected]>

PR sonic-net#20326 introduced anchors in the conditional mark yaml files. The anchors are defined in a dummy entry for test_pretest.py. PR sonic-net#20382 updated code to add exception for the sort checking of test_pretest.py in conditional mark yaml files. These changes made it complicated when we do need to skip something for test_pretest.py. This change fixed the problem by using a real dummy entry for defining the yaml anchors. The code of skipping test_pretest.py in sort checking in conditional mark yaml file is also removed. This change also improved a variable name in conditional mark and fixed a few typos. Signed-off-by: Xin Wang <[email protected]> Signed-off-by: Andoni Sanguesa <[email protected]>

PR sonic-net#20326 introduced anchors in the conditional mark yaml files. The anchors are defined in a dummy entry for test_pretest.py. PR sonic-net#20382 updated code to add exception for the sort checking of test_pretest.py in conditional mark yaml files. These changes made it complicated when we do need to skip something for test_pretest.py. This change fixed the problem by using a real dummy entry for defining the yaml anchors. The code of skipping test_pretest.py in sort checking in conditional mark yaml file is also removed. This change also improved a variable name in conditional mark and fixed a few typos. Signed-off-by: Xin Wang <[email protected]> Signed-off-by: Saravanan Sellappa <[email protected]>

…t#20382) Ensure pre-test is first item in conditional mark check, because pre-test runs before everything else, and it makes the most sense at the top of the file. Also this change goes with sonic-net#20326 This change will allow that PR to pass its PR checks. Signed-off-by: Guy Shemesh <[email protected]>

Description of PR Summary: update pre-commit version to include the fix for sonic-net#20382 Approach What is the motivation for this PR? update pre-commit version to include the fix for sonic-net#20382 How did you do it? update referencing version. signed-off-by: [email protected] Signed-off-by: Guy Shemesh <[email protected]>

…t#20382) Ensure pre-test is first item in conditional mark check, because pre-test runs before everything else, and it makes the most sense at the top of the file. Also this change goes with sonic-net#20326 This change will allow that PR to pass its PR checks. Signed-off-by: Lakshmi Yarramaneni <[email protected]>

Description of PR Summary: update pre-commit version to include the fix for sonic-net#20382 Approach What is the motivation for this PR? update pre-commit version to include the fix for sonic-net#20382 How did you do it? update referencing version. signed-off-by: [email protected] Signed-off-by: Lakshmi Yarramaneni <[email protected]>

…t#20382) Ensure pre-test is first item in conditional mark check, because pre-test runs before everything else, and it makes the most sense at the top of the file. Also this change goes with sonic-net#20326 This change will allow that PR to pass its PR checks. Signed-off-by: Yael Tzur <[email protected]>

Description of PR Summary: update pre-commit version to include the fix for sonic-net#20382 Approach What is the motivation for this PR? update pre-commit version to include the fix for sonic-net#20382 How did you do it? update referencing version. signed-off-by: [email protected] Signed-off-by: Yael Tzur <[email protected]>

PR sonic-net#20326 introduced anchors in the conditional mark yaml files. The anchors are defined in a dummy entry for test_pretest.py. PR sonic-net#20382 updated code to add exception for the sort checking of test_pretest.py in conditional mark yaml files. These changes made it complicated when we do need to skip something for test_pretest.py. This change fixed the problem by using a real dummy entry for defining the yaml anchors. The code of skipping test_pretest.py in sort checking in conditional mark yaml file is also removed. This change also improved a variable name in conditional mark and fixed a few typos. Signed-off-by: Xin Wang <[email protected]> Signed-off-by: Yael Tzur <[email protected]>

PR sonic-net#20326 introduced anchors in the conditional mark yaml files. The anchors are defined in a dummy entry for test_pretest.py. PR sonic-net#20382 updated code to add exception for the sort checking of test_pretest.py in conditional mark yaml files. These changes made it complicated when we do need to skip something for test_pretest.py. This change fixed the problem by using a real dummy entry for defining the yaml anchors. The code of skipping test_pretest.py in sort checking in conditional mark yaml file is also removed. This change also improved a variable name in conditional mark and fixed a few typos. Signed-off-by: Xin Wang <[email protected]>

PR sonic-net#20326 introduced anchors in the conditional mark yaml files. The anchors are defined in a dummy entry for test_pretest.py. PR sonic-net#20382 updated code to add exception for the sort checking of test_pretest.py in conditional mark yaml files. These changes made it complicated when we do need to skip something for test_pretest.py. This change fixed the problem by using a real dummy entry for defining the yaml anchors. The code of skipping test_pretest.py in sort checking in conditional mark yaml file is also removed. This change also improved a variable name in conditional mark and fixed a few typos. Signed-off-by: Xin Wang <[email protected]> Signed-off-by: nnelluri-cisco <[email protected]>

PR sonic-net#20326 introduced anchors in the conditional mark yaml files. The anchors are defined in a dummy entry for test_pretest.py. PR sonic-net#20382 updated code to add exception for the sort checking of test_pretest.py in conditional mark yaml files. These changes made it complicated when we do need to skip something for test_pretest.py. This change fixed the problem by using a real dummy entry for defining the yaml anchors. The code of skipping test_pretest.py in sort checking in conditional mark yaml file is also removed. This change also improved a variable name in conditional mark and fixed a few typos. Signed-off-by: Xin Wang <[email protected]> Signed-off-by: Raghavendran Ramanathan <[email protected]>

PR sonic-net#20326 introduced anchors in the conditional mark yaml files. The anchors are defined in a dummy entry for test_pretest.py. PR sonic-net#20382 updated code to add exception for the sort checking of test_pretest.py in conditional mark yaml files. These changes made it complicated when we do need to skip something for test_pretest.py. This change fixed the problem by using a real dummy entry for defining the yaml anchors. The code of skipping test_pretest.py in sort checking in conditional mark yaml file is also removed. This change also improved a variable name in conditional mark and fixed a few typos. Signed-off-by: Xin Wang <[email protected]> Signed-off-by: Zhuohui Tan <[email protected]>

PR sonic-net#20326 introduced anchors in the conditional mark yaml files. The anchors are defined in a dummy entry for test_pretest.py. PR sonic-net#20382 updated code to add exception for the sort checking of test_pretest.py in conditional mark yaml files. These changes made it complicated when we do need to skip something for test_pretest.py. This change fixed the problem by using a real dummy entry for defining the yaml anchors. The code of skipping test_pretest.py in sort checking in conditional mark yaml file is also removed. This change also improved a variable name in conditional mark and fixed a few typos. Signed-off-by: Xin Wang <[email protected]> Signed-off-by: Abhishek <[email protected]>

davidm-arista requested a review from wangxin as a code owner August 22, 2025 22:52

davidm-arista mentioned this pull request Aug 22, 2025

Skipping PFCWD tests for lossy topos & add anchor section #20326

Merged

11 tasks

sdszhang approved these changes Aug 26, 2025

View reviewed changes

davidm-arista force-pushed the master-pretestFirstInConditionCheck branch from 7dc7184 to 956000e Compare August 27, 2025 16:29

davidm-arista force-pushed the master-pretestFirstInConditionCheck branch from 956000e to cd0e4de Compare August 30, 2025 01:01

Ensure pre-test is the first item in conditional mark check

0274d77

davidm-arista force-pushed the master-pretestFirstInConditionCheck branch from cd0e4de to 0274d77 Compare September 7, 2025 16:40

ccroy-arista mentioned this pull request Sep 7, 2025

[TH5] Skip VxLAN Tests for Non-Applicable Topologies #20552

Merged

11 tasks

sdszhang added Request for msft-202412 Branch Request for msft-202503 Branch Request for 202505 branch labels Sep 8, 2025

wangxin approved these changes Sep 9, 2025

View reviewed changes

wangxin merged commit dbec321 into sonic-net:master Sep 9, 2025
23 checks passed

yejianquan added the Approved for 202505 branch label Sep 9, 2025

mssonicbld added the Created PR to 202505 branch label Sep 9, 2025

wangxin mentioned this pull request Jan 15, 2026

Improve anchor definition in conditional mark #21943

Merged

12 tasks

Conversation

davidm-arista commented Aug 22, 2025

Type of change

Back port request

Approach

What is the motivation for this PR?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Uh oh!

mssonicbld commented Aug 22, 2025

Uh oh!

davidm-arista commented Aug 26, 2025

Uh oh!

azure-pipelines bot commented Aug 26, 2025

Uh oh!

davidm-arista commented Aug 26, 2025

Uh oh!

mssonicbld commented Aug 26, 2025

Uh oh!

azure-pipelines bot commented Aug 26, 2025

Uh oh!

sdszhang left a comment

Choose a reason for hiding this comment

Uh oh!

mssonicbld commented Aug 27, 2025

Uh oh!

azure-pipelines bot commented Aug 27, 2025

Uh oh!

mssonicbld commented Aug 30, 2025

Uh oh!

azure-pipelines bot commented Aug 30, 2025

Uh oh!

mssonicbld commented Sep 7, 2025

Uh oh!

azure-pipelines bot commented Sep 7, 2025

Uh oh!

Uh oh!

sdszhang commented Sep 9, 2025

Uh oh!

mssonicbld commented Sep 9, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants