ci: add expected result to pr tests#21859
Merged
yejianquan merged 1 commit intosonic-net:masterfrom Jan 15, 2026
Merged
Conversation
Collaborator
|
/azp run |
github-actions
bot
requested review from
wangxin,
xwjiang-ms and
yutongzhang-microsoft
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Austin Pham <[email protected]>
auspham
force-pushed
the
asutinpham/refine-pr-test-expect-result
branch
from
525f14d to
57ad6ca
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
Hi @auspham , I've double checked the code logic in test_plan.py, adding default value should be good, but let's monitor after merged, to make sure it can catch the PR who fails the test modules |
xwjiang-ms
added a commit
to xwjiang-ms/sonic-mgmt
that referenced
this pull request
Jan 15, 2026
This reverts commit 562d00c.
yejianquan
pushed a commit
that referenced
this pull request
Jan 15, 2026
PriyanshTratiya
pushed a commit
to PriyanshTratiya/sonic-mgmt
that referenced
this pull request
Jan 21, 2026
Description of PR Summary: Due to recent internal discussion, there might be some false positive if EXPECTED_RESULT: "SUCCESS" is not set especially in combination with TEST_PLAN_STOP_ON_FAILURE: False To address this, we should always set this parameter for our critical test. Signed-off-by: Austin Pham <[email protected]> Signed-off-by: Priyansh Tratiya <[email protected]>
PriyanshTratiya
pushed a commit
to PriyanshTratiya/sonic-mgmt
that referenced
this pull request
Jan 21, 2026
…-net#21948) This reverts commit 562d00c. Signed-off-by: Priyansh Tratiya <[email protected]>
AndoniSanguesa
pushed a commit
to AndoniSanguesa/sonic-mgmt
that referenced
this pull request
Jan 21, 2026
Description of PR Summary: Due to recent internal discussion, there might be some false positive if EXPECTED_RESULT: "SUCCESS" is not set especially in combination with TEST_PLAN_STOP_ON_FAILURE: False To address this, we should always set this parameter for our critical test. Signed-off-by: Austin Pham <[email protected]> Signed-off-by: Andoni Sanguesa <[email protected]>
AndoniSanguesa
pushed a commit
to AndoniSanguesa/sonic-mgmt
that referenced
this pull request
Jan 21, 2026
…-net#21948) This reverts commit 562d00c. Signed-off-by: Andoni Sanguesa <[email protected]>
AndoniSanguesa
pushed a commit
to AndoniSanguesa/sonic-mgmt
that referenced
this pull request
Jan 21, 2026
Description of PR Summary: Due to recent internal discussion, there might be some false positive if EXPECTED_RESULT: "SUCCESS" is not set especially in combination with TEST_PLAN_STOP_ON_FAILURE: False To address this, we should always set this parameter for our critical test. Signed-off-by: Austin Pham <[email protected]> Signed-off-by: Andoni Sanguesa <[email protected]>
AndoniSanguesa
pushed a commit
to AndoniSanguesa/sonic-mgmt
that referenced
this pull request
Jan 21, 2026
…-net#21948) This reverts commit 562d00c. Signed-off-by: Andoni Sanguesa <[email protected]>
saravanan-nexthop
pushed a commit
to nexthop-ai/sonic-mgmt
that referenced
this pull request
Jan 22, 2026
Description of PR Summary: Due to recent internal discussion, there might be some false positive if EXPECTED_RESULT: "SUCCESS" is not set especially in combination with TEST_PLAN_STOP_ON_FAILURE: False To address this, we should always set this parameter for our critical test. Signed-off-by: Austin Pham <[email protected]> Signed-off-by: Saravanan Sellappa <[email protected]>
saravanan-nexthop
pushed a commit
to nexthop-ai/sonic-mgmt
that referenced
this pull request
Jan 22, 2026
…-net#21948) This reverts commit 562d00c. Signed-off-by: Saravanan Sellappa <[email protected]>
ytzur1
pushed a commit
to ytzur1/sonic-mgmt
that referenced
this pull request
Feb 2, 2026
Description of PR Summary: Due to recent internal discussion, there might be some false positive if EXPECTED_RESULT: "SUCCESS" is not set especially in combination with TEST_PLAN_STOP_ON_FAILURE: False To address this, we should always set this parameter for our critical test. Signed-off-by: Austin Pham <[email protected]> Signed-off-by: Yael Tzur <[email protected]>
ytzur1
pushed a commit
to ytzur1/sonic-mgmt
that referenced
this pull request
Feb 2, 2026
…-net#21948) This reverts commit 562d00c. Signed-off-by: Yael Tzur <[email protected]>
abhishek-nexthop
pushed a commit
to nexthop-ai/sonic-mgmt
that referenced
this pull request
Feb 6, 2026
Description of PR Summary: Due to recent internal discussion, there might be some false positive if EXPECTED_RESULT: "SUCCESS" is not set especially in combination with TEST_PLAN_STOP_ON_FAILURE: False To address this, we should always set this parameter for our critical test. Signed-off-by: Austin Pham <[email protected]>
abhishek-nexthop
pushed a commit
to nexthop-ai/sonic-mgmt
that referenced
this pull request
Feb 6, 2026
…-net#21948) This reverts commit 562d00c.
nnelluri-cisco
pushed a commit
to nnelluri-cisco/sonic-mgmt
that referenced
this pull request
Feb 12, 2026
Description of PR Summary: Due to recent internal discussion, there might be some false positive if EXPECTED_RESULT: "SUCCESS" is not set especially in combination with TEST_PLAN_STOP_ON_FAILURE: False To address this, we should always set this parameter for our critical test. Signed-off-by: Austin Pham <[email protected]> Signed-off-by: nnelluri-cisco <[email protected]>
nnelluri-cisco
pushed a commit
to nnelluri-cisco/sonic-mgmt
that referenced
this pull request
Feb 12, 2026
…-net#21948) This reverts commit 562d00c. Signed-off-by: nnelluri-cisco <[email protected]>
rraghav-cisco
pushed a commit
to rraghav-cisco/sonic-mgmt
that referenced
this pull request
Feb 13, 2026
Description of PR Summary: Due to recent internal discussion, there might be some false positive if EXPECTED_RESULT: "SUCCESS" is not set especially in combination with TEST_PLAN_STOP_ON_FAILURE: False To address this, we should always set this parameter for our critical test. Signed-off-by: Austin Pham <[email protected]> Signed-off-by: Raghavendran Ramanathan <[email protected]>
rraghav-cisco
pushed a commit
to rraghav-cisco/sonic-mgmt
that referenced
this pull request
Feb 13, 2026
…-net#21948) This reverts commit 562d00c. Signed-off-by: Raghavendran Ramanathan <[email protected]>
rraghav-cisco
pushed a commit
to rraghav-cisco/sonic-mgmt
that referenced
this pull request
Feb 18, 2026
Description of PR Summary: Due to recent internal discussion, there might be some false positive if EXPECTED_RESULT: "SUCCESS" is not set especially in combination with TEST_PLAN_STOP_ON_FAILURE: False To address this, we should always set this parameter for our critical test. Signed-off-by: Austin Pham <[email protected]> Signed-off-by: Raghavendran Ramanathan <[email protected]>
rraghav-cisco
pushed a commit
to rraghav-cisco/sonic-mgmt
that referenced
this pull request
Feb 18, 2026
…-net#21948) This reverts commit 562d00c. Signed-off-by: Raghavendran Ramanathan <[email protected]>
anilal-amd
pushed a commit
to anilal-amd/anilal-forked-sonic-mgmt
that referenced
this pull request
Feb 19, 2026
Description of PR Summary: Due to recent internal discussion, there might be some false positive if EXPECTED_RESULT: "SUCCESS" is not set especially in combination with TEST_PLAN_STOP_ON_FAILURE: False To address this, we should always set this parameter for our critical test. Signed-off-by: Austin Pham <[email protected]> Signed-off-by: Zhuohui Tan <[email protected]>
anilal-amd
pushed a commit
to anilal-amd/anilal-forked-sonic-mgmt
that referenced
this pull request
Feb 19, 2026
…-net#21948) This reverts commit 562d00c. Signed-off-by: Zhuohui Tan <[email protected]>
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…atically (sonic-net#21859) #### Why I did it src/sonic-utilities ``` * 17a7b18b - (HEAD -> 202411, origin/202411) Fix `vnet_route_check` for active and inactive routes, add `--all` option (sonic-net#3780) (2 days ago) [mssonicbld] ``` #### How I did it #### How to verify it #### Description for the changelog
abhishek-nexthop
pushed a commit
to nexthop-ai/sonic-mgmt
that referenced
this pull request
Mar 17, 2026
Description of PR Summary: Due to recent internal discussion, there might be some false positive if EXPECTED_RESULT: "SUCCESS" is not set especially in combination with TEST_PLAN_STOP_ON_FAILURE: False To address this, we should always set this parameter for our critical test. Signed-off-by: Austin Pham <[email protected]> Signed-off-by: Abhishek <[email protected]>
abhishek-nexthop
pushed a commit
to nexthop-ai/sonic-mgmt
that referenced
this pull request
Mar 17, 2026
…-net#21948) This reverts commit 562d00c. Signed-off-by: Abhishek <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary: Due to recent internal discussion, there might be some false positive if
EXPECTED_RESULT: "SUCCESS"is not set especially in combination withTEST_PLAN_STOP_ON_FAILURE: FalseTo address this, we should always set this parameter for our critical test.
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation