ci: add expected result to pr tests (sonic-net#21859)

Description of PR
Summary: Due to recent internal discussion, there might be some false positive if EXPECTED_RESULT: "SUCCESS" is not set especially in combination with TEST_PLAN_STOP_ON_FAILURE: False

To address this, we should always set this parameter for our critical test.

Signed-off-by: Austin Pham <austinpham@microsoft.com>

Author: auspham

.azure-pipelines/pr_test_template.yml

@@ -85,6 +85,7 @@ jobs:
           KVM_IMAGE_BRANCH: $(BUILD_BRANCH)
           MGMT_BRANCH: $(BUILD_BRANCH)
           COMMON_EXTRA_PARAMS: "--disable_sai_validation "
+          EXPECTED_RESULT: "SUCCESS"
           ${{ each param in parameters.OVERRIDE_PARAMS }}:
             ${{ param.key }}: ${{ param.value }}
 
@@ -120,6 +121,7 @@ jobs:
           KVM_IMAGE_BRANCH: $(BUILD_BRANCH)
           MGMT_BRANCH: $(BUILD_BRANCH)
           COMMON_EXTRA_PARAMS: "--disable_sai_validation "
+          EXPECTED_RESULT: "SUCCESS"
           ${{ each param in parameters.OVERRIDE_PARAMS }}:
             ${{ param.key }}: ${{ param.value }}
 
@@ -154,6 +156,7 @@ jobs:
           KVM_IMAGE_BRANCH: $(BUILD_BRANCH)
           MGMT_BRANCH: $(BUILD_BRANCH)
           COMMON_EXTRA_PARAMS: "--disable_sai_validation "
+          EXPECTED_RESULT: "SUCCESS"
           ${{ each param in parameters.OVERRIDE_PARAMS }}:
             ${{ param.key }}: ${{ param.value }}
 
@@ -188,6 +191,7 @@ jobs:
           COMMON_EXTRA_PARAMS: "--disable_loganalyzer --disable_sai_validation "
           KVM_IMAGE_BRANCH: $(BUILD_BRANCH)
           MGMT_BRANCH: $(BUILD_BRANCH)
+          EXPECTED_RESULT: "SUCCESS"
           ${{ each param in parameters.OVERRIDE_PARAMS }}:
             ${{ param.key }}: ${{ param.value }}
 
@@ -227,6 +231,7 @@ jobs:
               {"name": "bgp/test_bgp_fact.py", "param": "--neighbor_type=sonic --enable_macsec --macsec_profile=128_SCI,256_XPN_SCI"},
               {"name": "macsec", "param": "--neighbor_type=sonic --enable_macsec --macsec_profile=128_SCI,256_XPN_SCI"}
             ]'
+          EXPECTED_RESULT: "SUCCESS"
           ${{ each param in parameters.OVERRIDE_PARAMS }}:
             ${{ param.key }}: ${{ param.value }}
 
@@ -264,6 +269,7 @@ jobs:
           SPECIFIC_PARAM: '[
               {"name": "dash/test_dash_vnet.py", "param": "--skip_dataplane_checking"}
             ]'
+          EXPECTED_RESULT: "SUCCESS"
           ${{ each param in parameters.OVERRIDE_PARAMS }}:
             ${{ param.key }}: ${{ param.value }}
 
@@ -300,6 +306,7 @@ jobs:
           KVM_IMAGE_BRANCH: $(BUILD_BRANCH)
           MGMT_BRANCH: $(BUILD_BRANCH)
           COMMON_EXTRA_PARAMS: "--disable_sai_validation "
+          EXPECTED_RESULT: "SUCCESS"
           ${{ each param in parameters.OVERRIDE_PARAMS }}:
             ${{ param.key }}: ${{ param.value }}
 
@@ -335,5 +342,6 @@ jobs:
           KVM_IMAGE_BRANCH: $(BUILD_BRANCH)
           MGMT_BRANCH: $(BUILD_BRANCH)
           COMMON_EXTRA_PARAMS: "--disable_sai_validation "
+          EXPECTED_RESULT: "SUCCESS"
           ${{ each param in parameters.OVERRIDE_PARAMS }}:
             ${{ param.key }}: ${{ param.value }}

.azure-pipelines/sonic_vpp/sonic-vpp-nightly.yml

@@ -49,3 +49,4 @@ stages:
               KVM_IMAGE_BUILD_PIPELINE_ID: "2818"
               COMMON_EXTRA_PARAMS: "--disable_sai_validation --disable_loganalyzer"
               STOP_ON_FAILURE: "False"
+              EXPECTED_RESULT: "SUCCESS"