Skip to content

[ test_autonegotiation ] Added missing topology mark#3780

Merged
lguohan merged 1 commit intosonic-net:masterfrom
SavchukRomanLv:added_missed_topology_mark
Aug 13, 2021
Merged

[ test_autonegotiation ] Added missing topology mark#3780
lguohan merged 1 commit intosonic-net:masterfrom
SavchukRomanLv:added_missed_topology_mark

Conversation

@SavchukRomanLv
Copy link

Signed-off-by: Roman Savchuk [email protected]

Description of PR

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911

Approach

What is the motivation for this PR?

TC skipped when run with --topology mark
is skipped when no topology marker is given

How did you do it?

Run TC with --topology=any, TC was not skipped

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@SavchukRomanLv SavchukRomanLv requested a review from jleveque as a code owner July 13, 2021 07:21
Signed-off-by: Roman Savchuk <[email protected]>
@yxieca
Copy link
Collaborator

yxieca commented Jul 20, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@SavchukRomanLv
Copy link
Author

@jleveque can you please check?

@lguohan lguohan merged commit a1f47ab into sonic-net:master Aug 13, 2021
@bingwang-ms
Copy link
Collaborator

Hi @SavchukRomanLv, the test seems to be failing at most platforms.

Traceback (most recent call last):
  File "/azp/agent/_work/8/s/tests/common/plugins/log_section_start/__init__.py", line 73, in _fixture_generator_decorator
    res = next(it)
  File "/azp/agent/_work/8/s/tests/platform_tests/test_auto_negotiation.py", line 62, in recover_ports
    cadidate_test_ports[duthost] = random.sample(all_ports, 3)
  File "/usr/lib/python2.7/random.py", line 325, in sample
    raise ValueError("sample larger than population")
ValueError: sample larger than population

Can you help take a look? Thanks

@SavchukRomanLv
Copy link
Author

@bingwang-ms this issue fixed in 4055

vmittal-msft pushed a commit to vmittal-msft/sonic-mgmt that referenced this pull request Sep 28, 2021
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
…atically (sonic-net#21859)

#### Why I did it
src/sonic-utilities
```
* 17a7b18b - (HEAD -> 202411, origin/202411) Fix `vnet_route_check` for active and inactive routes, add `--all` option (sonic-net#3780) (2 days ago) [mssonicbld]
```
#### How I did it
#### How to verify it
#### Description for the changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants