Skip warm-reboot part in qos/test_qos_dscp_mapping.py for dualtor topologies#21820
Merged
StormLiangMS merged 7 commits intosonic-net:masterfrom Feb 25, 2026
Conversation
Collaborator
|
/azp run |
github-actions
bot
requested review from
XuChen-MSFT,
vmittal-msft and
xwjiang-ms
|
Azure Pipelines successfully started running 1 pipeline(s). |
…QueueMapping_IPIP_Base::test_dscp_to_queue_mapping for dualtor Skipping warm-reboot and re-running test after that as warm-reboot is broken in dualtor topologies Signed-off-by: rajkumar1 <rajkumar1@arista.com>
rajkumar1-arista
force-pushed
the
skip-warm-reboot-part-in-test-qos-dscp-mapping-for-dualtor
branch
from
8aad6a3 to
c7e6834
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
@StormLiangMS @xwjiang-ms can you please review this change? |
Contributor
Author
|
@StormLiangMS, @XuChen-MSFT can you please take a look? |
…s-dscp-mapping-for-dualtor
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: rajkumar1 <rajkumar1@arista.com>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: rajkumar1 <rajkumar1@arista.com>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: rajkumar1 <rajkumar1@arista.com>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: rajkumar1 <rajkumar1@arista.com>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: rajkumar1 <rajkumar1@arista.com>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
lolyu
requested changes
Feb 19, 2026
Collaborator
lolyu
left a comment
lolyu
left a comment
There was a problem hiding this comment.
suggest using the conditional mark to skip the case.
Contributor
Author
Testing up until the warm reboot point is still valid for these topologies. |
StormLiangMS
added
Request for 202511 branch
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Feb 25, 2026
…opologies (sonic-net#21820) What is the motivation for this PR? This test triggers warm reboot which is broken on dualtor and can cause orchagent crash etc. How did you do it? Skipping the warm-reboot part of the test for dualtor How did you verify/test it? ran the test Signed-off-by: mssonicbld <sonicbld@microsoft.com>
Collaborator
|
Cherry-pick PR to 202511: #22614 |
12 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Feb 25, 2026
…opologies (#21820) What is the motivation for this PR? This test triggers warm reboot which is broken on dualtor and can cause orchagent crash etc. How did you do it? Skipping the warm-reboot part of the test for dualtor How did you verify/test it? ran the test Signed-off-by: mssonicbld <sonicbld@microsoft.com>
mssonicbld
added
Included in 202511 branch
and removed
Created PR to 202511 branch
labels
aronovic
pushed a commit
to aronovic/sonic-mgmt
that referenced
this pull request
Mar 3, 2026
…opologies (sonic-net#21820) What is the motivation for this PR? This test triggers warm reboot which is broken on dualtor and can cause orchagent crash etc. How did you do it? Skipping the warm-reboot part of the test for dualtor How did you verify/test it? ran the test Signed-off-by: Mihut Aronovici <aronovic@cisco.com>
rraghav-cisco
pushed a commit
to rraghav-cisco/sonic-mgmt
that referenced
this pull request
Mar 3, 2026
…opologies (sonic-net#21820) What is the motivation for this PR? This test triggers warm reboot which is broken on dualtor and can cause orchagent crash etc. How did you do it? Skipping the warm-reboot part of the test for dualtor How did you verify/test it? ran the test Signed-off-by: Raghavendran Ramanathan <rraghav@cisco.com>
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…tically (sonic-net#21820) #### Why I did it src/sonic-sairedis ``` * d884ff9a - (HEAD -> 202411, origin/202411) [syncd] Move logSet logGet under mutex to prevent race condition (sonic-net#1520) (sonic-net#1538) (3 hours ago) [Kamil Cudnik] ``` #### How I did it #### How to verify it #### Description for the changelog
abhishek-nexthop
pushed a commit
to nexthop-ai/sonic-mgmt
that referenced
this pull request
Mar 17, 2026
…opologies (sonic-net#21820) What is the motivation for this PR? This test triggers warm reboot which is broken on dualtor and can cause orchagent crash etc. How did you do it? Skipping the warm-reboot part of the test for dualtor How did you verify/test it? ran the test Signed-off-by: Abhishek <abhishek@nexthop.ai>
vrajeshe
pushed a commit
to vrajeshe/sonic-mgmt
that referenced
this pull request
Mar 23, 2026
…opologies (sonic-net#21820) What is the motivation for this PR? This test triggers warm reboot which is broken on dualtor and can cause orchagent crash etc. How did you do it? Skipping the warm-reboot part of the test for dualtor How did you verify/test it? ran the test Signed-off-by: Venkata Gouri Rajesh Etla <vrajeshe@cisco.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Skip warm-reboot and re-running test
qos/test_qos_dscp_mapping.py::TestQoSSaiDSCPQueueMapping_IPIP_Base::test_dscp_to_queue_mappingafter warm-reboot as its broken in dualtorSummary:
Fixes # (https://github.com/aristanetworks/sonic-qual.msft/issues/1010)
Type of change
Back port request
Approach
What is the motivation for this PR?
This test triggers warm reboot which is broken on
dualtorand can cause orchagent crash etc.How did you do it?
Skipping the warm-reboot part of the test for dualtor
How did you verify/test it?
ran the test
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation