Skip to content

Commit 458bb10

Browse files
Skip warm-reboot part in qos/test_qos_dscp_mapping.py for dualtor topologies (#21820)
What is the motivation for this PR? This test triggers warm reboot which is broken on dualtor and can cause orchagent crash etc. How did you do it? Skipping the warm-reboot part of the test for dualtor How did you verify/test it? ran the test
1 parent 1747b26 commit 458bb10

File tree

1 file changed

+8
-2
lines changed

1 file changed

+8
-2
lines changed

tests/qos/test_qos_dscp_mapping.py

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -500,8 +500,14 @@ def test_dscp_to_queue_mapping(self, ptfadapter, rand_selected_dut, localhost, d
500500
with allure.step("Run test"):
501501
self._run_test(ptfadapter, duthost, tbinfo, test_params, inner_dst_ip_list, dut_qos_maps_module, dscp_mode)
502502

503-
if completeness_level != "basic" and \
504-
not duthost.dut_basic_facts()['ansible_facts']['dut_basic_facts'].get("is_smartswitch"):
503+
is_smartswitch = duthost.dut_basic_facts()['ansible_facts']['dut_basic_facts'].get("is_smartswitch", False)
504+
topo_name = tbinfo["topo"]["name"]
505+
if (
506+
completeness_level != "basic"
507+
and not is_smartswitch
508+
and "dualtor" not in topo_name
509+
and "t1" not in topo_name
510+
):
505511
with allure.step("Do warm-reboot"):
506512
reboot(duthost, localhost, reboot_type="warm", safe_reboot=True, check_intf_up_ports=True,
507513
wait_warmboot_finalizer=True)

0 commit comments

Comments
 (0)