Skip to content

Commit 8cdde5a

Browse files
rajkumar1-aristamssonicbld
authored andcommitted
Skip warm-reboot part in qos/test_qos_dscp_mapping.py for dualtor topologies (sonic-net#21820)
What is the motivation for this PR? This test triggers warm reboot which is broken on dualtor and can cause orchagent crash etc. How did you do it? Skipping the warm-reboot part of the test for dualtor How did you verify/test it? ran the test Signed-off-by: mssonicbld <sonicbld@microsoft.com>
1 parent 8b59be3 commit 8cdde5a

1 file changed

Lines changed: 8 additions & 2 deletions

File tree

tests/qos/test_qos_dscp_mapping.py

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -493,8 +493,14 @@ def test_dscp_to_queue_mapping(self, ptfadapter, rand_selected_dut, localhost, d
493493
with allure.step("Run test"):
494494
self._run_test(ptfadapter, duthost, tbinfo, test_params, inner_dst_ip_list, dut_qos_maps_module, dscp_mode)
495495

496-
if completeness_level != "basic" and \
497-
not duthost.dut_basic_facts()['ansible_facts']['dut_basic_facts'].get("is_smartswitch"):
496+
is_smartswitch = duthost.dut_basic_facts()['ansible_facts']['dut_basic_facts'].get("is_smartswitch", False)
497+
topo_name = tbinfo["topo"]["name"]
498+
if (
499+
completeness_level != "basic"
500+
and not is_smartswitch
501+
and "dualtor" not in topo_name
502+
and "t1" not in topo_name
503+
):
498504
with allure.step("Do warm-reboot"):
499505
reboot(duthost, localhost, reboot_type="warm", safe_reboot=True, check_intf_up_ports=True,
500506
wait_warmboot_finalizer=True)

0 commit comments

Comments
 (0)