Fix IPv6-only topology support in generic_patch BGP convergence check#23241
Merged
yxieca merged 1 commit intosonic-net:masterfrom Mar 26, 2026
Merged
Fix IPv6-only topology support in generic_patch BGP convergence check#23241yxieca merged 1 commit intosonic-net:masterfrom
yxieca merged 1 commit intosonic-net:masterfrom
Conversation
PR sonic-net#22895 added BGP session convergence wait before DB comparison in generic_patch_add_t0(), but unconditionally checks both IPv4 and IPv6 BGP sessions. On IPv6-only topologies (e.g. t1-isolated-v6-d56u1-lag), tor_data["ip"]["remote"] is empty, causing is_bgp_session_established() to fail. Fix by checking whether each neighbor IP exists before waiting for the BGP session, consistent with the chk_any_bgp_session() approach from PR sonic-net#21591. Change-Id: I694fd17b7b49b4ce4ece53e0521773b71f301b70 Signed-off-by: weiguo-nvidia <weguo@nvidia.com>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yxieca
approved these changes
Mar 26, 2026
Collaborator
yxieca
left a comment
yxieca
left a comment
There was a problem hiding this comment.
AI agent on behalf of Ying. Reviewed; no issues found.
ravaliyel
pushed a commit
to ravaliyel/sonic-mgmt
that referenced
this pull request
Mar 27, 2026
…sonic-net#23241) What is the motivation for this PR?\nPR sonic-net#22895 added BGP session convergence wait before DB comparison in generic_patch_add_t0(), but unconditionally checks both IPv4 and IPv6 BGP sessions. On IPv6-only topologies (e.g. t1-isolated-v6-d56u1-lag), tor_data["ip"]["remote"] is empty, causing is_bgp_session_established() to fail.\n\nHow did you do it?\nFix by checking whether each neighbor IP exists before waiting for the BGP session, consistent with the chk_any_bgp_session() approach from PR sonic-net#21591.\n\nHow did you verify/test it?\nRegression test pass\n\nSigned-off-by:\nweiguo-nvidia <weiguo@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Fix IPv6-only topology support in generic_patch BGP convergence check
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
PR #22895 added BGP session convergence wait before DB comparison in
generic_patch_add_t0(), but unconditionally checks both IPv4 and IPv6 BGP sessions. On IPv6-only topologies (e.g.t1-isolated-v6-d56u1-lag),tor_data["ip"]["remote"]is empty, causing is_bgp_session_established() to fail.How did you do it?
Fix by checking whether each neighbor IP exists before waiting for the BGP session, consistent with the
chk_any_bgp_session()approach from PR #21591.How did you verify/test it?
Regression test pass
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation