[Mellanox] Skip fan default speed check#2062
Merged
wangxin merged 2 commits intosonic-net:masterfrom Aug 10, 2020
Merged
Conversation
|
This pull request introduces 1 alert when merging 18eb1de into 384c948 - view on LGTM.com new alerts:
|
wangxin
approved these changes
Aug 10, 2020
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
91d7558 (HEAD -> 202111, origin/202111) Allow IPv4 link-local nexthops (sonic-net#1903) ceb5161 Fix for 2053, Fix IPv6 BGP multipath-relax peer-type. (sonic-net#2062) b3b279a [crm] Use sai_object_type_get_availability() API to get counters (sonic-net#2098) 28955f4 Try get port operational speed from STATE DB (sonic-net#2119)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Mellanox no longer set default fan speed to 60% since there is thermal control running. No need to wait fan speed to reach 60%.
Type of change
Approach
What is the motivation for this PR?
It always take 5 minutes to wait for fan speed to reach 60% because fan speed will not reach that value with thermal control enabled.
How did you do it?
Remove the unused wait.
How did you verify/test it?
Manual test.
Any platform specific information?
All mellanox platforms.
Supported testbed topology if it's a new test case?
N/A
Documentation