Skip to content

[util tests] add markers to help reduce util group execution logs#1903

Merged
yxieca merged 2 commits intosonic-net:masterfrom
yxieca:util
Jul 15, 2020
Merged

[util tests] add markers to help reduce util group execution logs#1903
yxieca merged 2 commits intosonic-net:masterfrom
yxieca:util

Conversation

@yxieca
Copy link
Collaborator

@yxieca yxieca commented Jul 14, 2020

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Approach

What is the motivation for this PR?

Reduce the chattiness of the util test group output.

How did you do it?

  • util test group split to pre-test group and post-test group.
  • pre-test group is responsible for gettign DUT ready for test.
  • post-test group is responsible for cleaning up DUT after tests.
  • remove addon-ops to give perference to run_test.sh.
  • make sure the RC is set per feature/regression tests.

Signed-off-by: Ying Xie ying.xie@microsoft.com

How did you verify/test it?

Execute test with run_test.sh. Observed the pretest and post test output.

- util test group split to pre-test group and post-test group.
- pre-test group is responsible for gettign DUT ready for test.
- post-test group is responsible for cleaning up DUT after tests.
- remove addon-ops to give perference to run_test.sh.

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
@yxieca yxieca requested a review from a team July 14, 2020 17:57
disable_loganalyzer: make to disable automatic loganalyzer
broadcom: test specific to Broadcom platform
pretest: tests are run before feature/regression test cases to prepare the DUT/environment.
posttest: tests are run after feature/regression test cases to cleanup the DUT/environment and/or collect diagnostics.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which test uses this marker? is it a placeholder?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Place holder for now. the cleanup tests will go to this group.

@yxieca yxieca merged commit 63efe45 into sonic-net:master Jul 15, 2020
@yxieca yxieca deleted the util branch July 15, 2020 02:47

if [[ x"${OMIT_FILE_LOG}" == x"True" ]]; then
UTIL_LOGGING_OPTIONS=""
PRET_LOGGING_OPTIONS=""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PRET?

kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
* 9d095aa 2021-10-28 | disk_check.py: Move to python2 (sonic-net#1903) (github/201811) [Renuka Manavalan]

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
91d7558 (HEAD -> 202111, origin/202111) Allow IPv4 link-local nexthops (sonic-net#1903)
ceb5161 Fix for 2053, Fix IPv6 BGP multipath-relax peer-type. (sonic-net#2062)
b3b279a [crm] Use sai_object_type_get_availability() API to get counters (sonic-net#2098)
28955f4 Try get port operational speed from STATE DB (sonic-net#2119)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants