Update test_duplicate_route to fix PR test failures#20360
Closed
Ndancejic wants to merge 1 commit intosonic-net:masterfrom
Closed
Update test_duplicate_route to fix PR test failures#20360Ndancejic wants to merge 1 commit intosonic-net:masterfrom
Ndancejic wants to merge 1 commit intosonic-net:masterfrom
Conversation
test_duplicate_route is failing PR tests in sairedis submodule update for sonic-buildimge. This is due to a sairedis change which updates bulk operation functionality to match the expected behavior when SAI_BULK_OP_ERROR_MODE_IGNORE_ERROR flag is set. sonic-buildimage PR: sonic-net/sonic-buildimage sonic-net#23334 sonic-sairedis PR: sonic-net/sonic-sairedis sonic-net#1613 This sairedis change causes swss to process failures in a different way, which leads to a change in expected log output. test_duplicate_route will look for logs output before the change sonic-net#1613 causing failure, and changing test_duplicate_route to expect logs after sonic-net#1613 fails other PR. This change looks to temporarily loosen the expected log output so that both versions of sairedis can pass this test. Once sonic-net#23334 is merged, the expected logs can be updated to match only the new behavior. Signed-off-by: Nikola Dancejic <ndancejic@microsoft.com>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
test_duplicate_route is failing PR tests in sairedis submodule update for sonic-buildimge. This is due to a sairedis change which updates bulk operation functionality to match the expected behavior when SAI_BULK_OP_ERROR_MODE_IGNORE_ERROR flag is set.
sonic-buildimage PR: sonic-net/sonic-buildimage#23334
sonic-sairedis PR: sonic-net/sonic-sairedis#1613
This sairedis change causes swss to process failures in a different way, which leads to a change in expected log output. test_duplicate_route will look for logs output before the change sairedis#1613 causing failure, and changing test_duplicate_route to expect logs after sairedis#1613 fails other PR.
This change looks to temporarily loosen the expected log output so that both versions of sairedis can pass this test. Once buildimage#23334 is merged, the expected logs can be updated to match only the new behavior.
Summary:
Fixes #20231
Type of change
Back port request
Approach
What is the motivation for this PR?
Unblock sairedis module update in sonic-buildimage sonic-net/sonic-buildimage#23334
How did you do it?
How did you verify/test it?
Run on testbed
Any platform specific information?
N/A
Supported testbed topology if it's a new test case?
N/A