[sanity check] Skip bgp check for particular topology#2034
Merged
wangxin merged 1 commit intosonic-net:masterfrom Aug 5, 2020
Merged
[sanity check] Skip bgp check for particular topology#2034wangxin merged 1 commit intosonic-net:masterfrom
wangxin merged 1 commit intosonic-net:masterfrom
Conversation
wangxin
approved these changes
Aug 5, 2020
ZhaohuiS
added a commit
that referenced
this pull request
Feb 2, 2023
What is the motivation for this PR? test_trap_config_save_after_reboot case should skipped in 202012 branch, since always_enable feature is not merged into 202012 image. [CoPP] Add always_enabled field to coppmgr logic by noaOrMlnx · Pull Request #2034 · sonic-net/sonic-swss (github.com) Test case was added in this PR: #4891 xfail in this PR [test] skip/xfail unmerged copp feature temporarily by yejianquan · Pull Request #5148 · sonic-net/sonic-mgmt (github.com) How did you do it? Xfail is not correct, it needs to be skipped for now. Change xfail to skip. Signed-off-by: Zhaohui Sun <[email protected]>
wangxin
pushed a commit
that referenced
this pull request
Feb 3, 2023
What is the motivation for this PR? test_trap_config_save_after_reboot case should skipped in 202012 branch, since always_enable feature is not merged into 202012 image. [CoPP] Add always_enabled field to coppmgr logic by noaOrMlnx · Pull Request #2034 · sonic-net/sonic-swss (github.com) Test case was added in this PR: #4891 xfail in this PR [test] skip/xfail unmerged copp feature temporarily by yejianquan · Pull Request #5148 · sonic-net/sonic-mgmt (github.com) How did you do it? Xfail is not correct, it needs to be skipped for now. Change xfail to skip. Signed-off-by: Zhaohui Sun <[email protected]>
wangxin
pushed a commit
that referenced
this pull request
Feb 3, 2023
What is the motivation for this PR? test_trap_config_save_after_reboot case should skipped in 202012 branch, since always_enable feature is not merged into 202012 image. [CoPP] Add always_enabled field to coppmgr logic by noaOrMlnx · Pull Request #2034 · sonic-net/sonic-swss (github.com) Test case was added in this PR: xfail in this PR [test] skip/xfail unmerged copp feature temporarily by yejianquan · Pull Request #5148 · sonic-net/sonic-mgmt (github.com) How did you do it? Xfail is not correct, it needs to be skipped for now. Change xfail to skip. Signed-off-by: Zhaohui Sun <[email protected]>
kellyyeh
pushed a commit
to kellyyeh/sonic-mgmt
that referenced
this pull request
Mar 31, 2023
…7373) What is the motivation for this PR? test_trap_config_save_after_reboot case should skipped in 202012 branch, since always_enable feature is not merged into 202012 image. [CoPP] Add always_enabled field to coppmgr logic by noaOrMlnx · Pull Request sonic-net#2034 · sonic-net/sonic-swss (github.com) Test case was added in this PR: sonic-net#4891 xfail in this PR [test] skip/xfail unmerged copp feature temporarily by yejianquan · Pull Request sonic-net#5148 · sonic-net/sonic-mgmt (github.com) How did you do it? Xfail is not correct, it needs to be skipped for now. Change xfail to skip. Signed-off-by: Zhaohui Sun <[email protected]>
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
Include following commits:
- d061e27 [tunnelmgrd]: Warm boot support (sonic-net#2166)
- 73ced6e Remove port serdes object before removing port (sonic-net#2152)
- 6ac0b9b [CoPP] Add always_enabled field to coppmgr logic (sonic-net#2034) (sonic-net#2147)
Signed-off-by: Lawrence Lee <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
There are topologies that don't have BGP sessions. The PR is to skip bgp check for those topologies.
Type of change
Approach
What is the motivation for this PR?
There are topologies that don't have BGP sessions. The PR is to skip bgp check for those topologies.
How did you do it?
For particular topologies, remove bgp from the check items.
How did you verify/test it?
Run a basic regression test case
Any platform specific information?
N/A
Supported testbed topology if it's a new test case?
N/A
Documentation