[test] skip/xfail unmerged copp feature temporarily#5148
Merged
yejianquan merged 1 commit intosonic-net:masterfrom Feb 18, 2022
Merged
[test] skip/xfail unmerged copp feature temporarily#5148yejianquan merged 1 commit intosonic-net:masterfrom
yejianquan merged 1 commit intosonic-net:masterfrom
Conversation
neethajohn
reviewed
Feb 15, 2022
neethajohn
approved these changes
Feb 18, 2022
6 tasks
ZhaohuiS
added a commit
that referenced
this pull request
Feb 2, 2023
What is the motivation for this PR? test_trap_config_save_after_reboot case should skipped in 202012 branch, since always_enable feature is not merged into 202012 image. [CoPP] Add always_enabled field to coppmgr logic by noaOrMlnx · Pull Request #2034 · sonic-net/sonic-swss (github.com) Test case was added in this PR: #4891 xfail in this PR [test] skip/xfail unmerged copp feature temporarily by yejianquan · Pull Request #5148 · sonic-net/sonic-mgmt (github.com) How did you do it? Xfail is not correct, it needs to be skipped for now. Change xfail to skip. Signed-off-by: Zhaohui Sun <[email protected]>
wangxin
pushed a commit
that referenced
this pull request
Feb 3, 2023
What is the motivation for this PR? test_trap_config_save_after_reboot case should skipped in 202012 branch, since always_enable feature is not merged into 202012 image. [CoPP] Add always_enabled field to coppmgr logic by noaOrMlnx · Pull Request #2034 · sonic-net/sonic-swss (github.com) Test case was added in this PR: #4891 xfail in this PR [test] skip/xfail unmerged copp feature temporarily by yejianquan · Pull Request #5148 · sonic-net/sonic-mgmt (github.com) How did you do it? Xfail is not correct, it needs to be skipped for now. Change xfail to skip. Signed-off-by: Zhaohui Sun <[email protected]>
wangxin
pushed a commit
that referenced
this pull request
Feb 3, 2023
What is the motivation for this PR? test_trap_config_save_after_reboot case should skipped in 202012 branch, since always_enable feature is not merged into 202012 image. [CoPP] Add always_enabled field to coppmgr logic by noaOrMlnx · Pull Request #2034 · sonic-net/sonic-swss (github.com) Test case was added in this PR: xfail in this PR [test] skip/xfail unmerged copp feature temporarily by yejianquan · Pull Request #5148 · sonic-net/sonic-mgmt (github.com) How did you do it? Xfail is not correct, it needs to be skipped for now. Change xfail to skip. Signed-off-by: Zhaohui Sun <[email protected]>
kellyyeh
pushed a commit
to kellyyeh/sonic-mgmt
that referenced
this pull request
Mar 31, 2023
…7373) What is the motivation for this PR? test_trap_config_save_after_reboot case should skipped in 202012 branch, since always_enable feature is not merged into 202012 image. [CoPP] Add always_enabled field to coppmgr logic by noaOrMlnx · Pull Request sonic-net#2034 · sonic-net/sonic-swss (github.com) Test case was added in this PR: sonic-net#4891 xfail in this PR [test] skip/xfail unmerged copp feature temporarily by yejianquan · Pull Request sonic-net#5148 · sonic-net/sonic-mgmt (github.com) How did you do it? Xfail is not correct, it needs to be skipped for now. Change xfail to skip. Signed-off-by: Zhaohui Sun <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes #5106
Type of change
Back port request
Approach
What is the motivation for this PR?
skip/xfail unmerged feature of CoPP
How did you do it?
Add skip/xfail in tests_mark_conditions.yaml.
Set the 'strict' flag to True, once the feature has been merged in the future, the 'xpass' will be considered as 'fail', then we can remove the mark conditions.
How did you verify/test it?
Run them on physical testbeds, successfully skipped/xfailed
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation