Skip to content

Add Dpc role assignment for SmartSwitch interfaces#20244

Merged
prabhataravind merged 2 commits intosonic-net:masterfrom
nnelluri-cisco:dpu-role-fix
Sep 19, 2025
Merged

Add Dpc role assignment for SmartSwitch interfaces#20244
prabhataravind merged 2 commits intosonic-net:masterfrom
nnelluri-cisco:dpu-role-fix

Conversation

@nnelluri-cisco
Copy link
Copy Markdown
Contributor

Description of PR

Summary:This commit introduces logic to assign the 'Dpc' role based on specific conditions within the port alias and subtype.
Fixes # (issue)

Type of change

  • Bug fix
  • [X ] Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202205
  • 202305
  • 202311
  • 202405
  • [ X] 202411
  • [X ] 202505

Approach

The 'Dpc' role is now assigned when:
The subtype is defined and equals 'SmartSwitch'.
The integer value extracted from the intf variable (starting from the 8th character) is greater than or equal to 224.

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Deployed the minigraph and confirmed that the DPU role configuration is present for all backplane interfaces.

Any platform specific information?

HwSKU: Cisco-8102-28FH-DPU-O

Supported testbed topology if it's a new test case?

t1-128-lag

Documentation

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@nnelluri-cisco
Copy link
Copy Markdown
Contributor Author

@prabhataravind @congh-nvidia @rameshraghupathy
Please review and approve the PR

This PR is raised extension to below mentioned PR
#18157

prabhataravind
prabhataravind previously approved these changes Aug 14, 2025
Copy link
Copy Markdown
Contributor

@prabhataravind prabhataravind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@prabhataravind
Copy link
Copy Markdown
Contributor

@congh-nvidia please review this change.

@prabhataravind
Copy link
Copy Markdown
Contributor

@congh-nvidia could you please approve if this looks okay to you for Nvidia smartswitch platform?

<PortName>0</PortName>
<Priority>0</Priority>
{% if subtype is defined and subtype == 'SmartSwitch' and index > 27 %}
{% set intf = port_alias[index] %}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be based on sonic port name and not port alias?

Copy link
Copy Markdown
Contributor

@prabhataravind prabhataravind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comment on using port_alias. Did you try deploying mg with this change on O28 and O8C40 skus?

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Copy Markdown
Contributor

@prabhataravind prabhataravind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@prabhataravind
Copy link
Copy Markdown
Contributor

@congh-nvidia could you approve as well if there are no concerns?

Copy link
Copy Markdown
Contributor

@congh-nvidia congh-nvidia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mssonicbld
Copy link
Copy Markdown
Collaborator

@nnelluri-cisco PR conflicts with 202505 branch

vidyac86 pushed a commit to vidyac86/sonic-mgmt that referenced this pull request Oct 23, 2025
* Add Dpc role assignment for SmartSwitch interfaces

* replaced port_alias with port_name for intf
opcoder0 pushed a commit to opcoder0/sonic-mgmt that referenced this pull request Dec 8, 2025
* Add Dpc role assignment for SmartSwitch interfaces

* replaced port_alias with port_name for intf

Signed-off-by: opcoder0 <[email protected]>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Dec 16, 2025
* Add Dpc role assignment for SmartSwitch interfaces

* replaced port_alias with port_name for intf

Signed-off-by: Guy Shemesh <[email protected]>
AharonMalkin pushed a commit to AharonMalkin/sonic-mgmt that referenced this pull request Dec 16, 2025
* Add Dpc role assignment for SmartSwitch interfaces

* replaced port_alias with port_name for intf

Signed-off-by: Aharon Malkin <[email protected]>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Dec 21, 2025
* Add Dpc role assignment for SmartSwitch interfaces

* replaced port_alias with port_name for intf

Signed-off-by: Guy Shemesh <[email protected]>
venu-nexthop pushed a commit to venu-nexthop/sonic-mgmt that referenced this pull request Jan 13, 2026
* Add Dpc role assignment for SmartSwitch interfaces

* replaced port_alias with port_name for intf
yifan-nexthop pushed a commit to nexthop-ai/sonic-mgmt that referenced this pull request Jan 14, 2026
* Add Dpc role assignment for SmartSwitch interfaces

* replaced port_alias with port_name for intf

Signed-off-by: YiFan Wang <[email protected]>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Jan 26, 2026
* Add Dpc role assignment for SmartSwitch interfaces

* replaced port_alias with port_name for intf

Signed-off-by: Guy Shemesh <[email protected]>
lakshmi-nexthop pushed a commit to lakshmi-nexthop/sonic-mgmt that referenced this pull request Jan 28, 2026
* Add Dpc role assignment for SmartSwitch interfaces

* replaced port_alias with port_name for intf

Signed-off-by: Lakshmi Yarramaneni <[email protected]>
ytzur1 pushed a commit to ytzur1/sonic-mgmt that referenced this pull request Feb 2, 2026
* Add Dpc role assignment for SmartSwitch interfaces

* replaced port_alias with port_name for intf

Signed-off-by: Yael Tzur <[email protected]>
abhishek-nexthop pushed a commit to nexthop-ai/sonic-mgmt that referenced this pull request Feb 6, 2026
* Add Dpc role assignment for SmartSwitch interfaces

* replaced port_alias with port_name for intf
venu-nexthop pushed a commit to venu-nexthop/sonic-mgmt that referenced this pull request Mar 27, 2026
* Add Dpc role assignment for SmartSwitch interfaces

* replaced port_alias with port_name for intf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants