fix for qos failures for master branch due to backplane changes by nnelluri-cisco · Pull Request #19495 · sonic-net/sonic-mgmt

nnelluri-cisco · 2025-07-09T18:07:55Z

Description of PR

This fix is to address the issue introduced by smartswicth interafces naming from Ethernet-BP0 / Ethernet-BP7
To Ethernet224 / Ethernet280

Summary: Excluded the DPU interafces Ethernet-224 to Ethernet-280 from the minigraph_facts to avoid qos failures
Fixes # (issue)

Type of change

Bug fix
Testbed and Framework(new/improvement)
New Test case
- Skipped for non-supported platforms
[X ] Test case improvement

Back port request

Approach

exclude new DPU interfaces Ethernet-224 to Ethernet-280

What is the motivation for this PR?

The new DPU interfaces Ethernet-224 to Ethernet-280 is breaking test_qos_sai.py regression in latest master branch.

How did you do it?

How did you verify/test it?

Ran complete test_qos_sai.py regression under sonic-mgmt. with new changes and all tests pass.

Any platform specific information?

Platform: x86_64-8102_28fh_dpu_o-r0
HwSKU: Cisco-8102-28FH-DPU-O
ASIC: cisco-8000

Supported testbed topology if it's a new test case?

topo_t1_28_lag

Documentation

mssonicbld · 2025-07-09T18:08:03Z

/azp run

azure-pipelines · 2025-07-09T18:08:16Z

Azure Pipelines successfully started running 1 pipeline(s).

nnelluri-cisco · 2025-07-09T18:09:28Z

@prabhataravind and @bhavani
please review and approve the PR.

This latest PR is raised extension to previous PR #16465
due to interface namig changes for DPU backplane interafces.

mssonicbld · 2025-07-09T18:52:54Z

/azp run

azure-pipelines · 2025-07-09T18:53:09Z

Azure Pipelines successfully started running 1 pipeline(s).

tests/common/devices/sonic.py

mssonicbld · 2025-07-10T05:06:32Z

/azp run

azure-pipelines · 2025-07-10T05:06:46Z

Azure Pipelines successfully started running 1 pipeline(s).

prabhataravind · 2025-07-10T19:02:10Z

@congh-nvidia @wen587 please review

tests/common/devices/sonic.py

prabhataravind

We can't have hard-coded IPs in generic code.

rameshraghupathy

Updated the comment

tests/common/devices/sonic.py

congh-nvidia · 2025-07-11T01:37:21Z

tests/common/devices/sonic.py

+        show_ip_int_output = self.shell("show ip interface")["stdout"]
+        # Build set of Ethernet ports with 18.x.202.0/31 IPs to exclude
+        excluded_ports = set()
+        for line in show_ip_int_output.strip().splitlines():


There is already a common method to parse the show output:

sonic-mgmt/tests/common/devices/sonic.py

Line 1679 in 20847a8

def show_and_parse(self, show_cmd, header_len=1, **kwargs):

@congh-nvidia
used show_and_parse API instead of custom parsing.

congh-nvidia · 2025-07-11T01:40:45Z

In general the DPU interfaces could affect some tests, not only the QOS test. For us we just don't add those interfaces to the ansible/files/sonic_lab_links.csv. And then there is no need to change the existing tests.

wen587 · 2025-07-11T01:41:20Z

tests/common/devices/sonic.py

+        excluded_ports = self.get_backplane_ports()
        for k, v in list(ip_ifs.items()):
-            if ((k.startswith("Ethernet") and (not k.startswith("Ethernet-BP")) and not is_inband_port(k)) or
+            if ((k.startswith("Ethernet") and (k not in excluded_ports) and not is_inband_port(k)) or


What is the current naming for this Ehternet-BP port?

@wen587
The current naming as follows
Ethernet224 18.0.202.0/31 up/up N/A N/A
Ethernet232 18.1.202.0/31 up/up N/A N/A
Ethernet240 18.2.202.0/31 up/up N/A N/A
Ethernet248 18.3.202.0/31 up/up N/A N/A
Ethernet256 18.4.202.0/31 up/up N/A N/A
Ethernet264 18.5.202.0/31 up/up N/A N/A
Ethernet272 18.6.202.0/31 up/up N/A N/A
Ethernet280 18.7.202.0/31 up/up N/A N/A

bpar9

@nnelluri-cisco lets close on common approach for all SS dependent scripts which can be adopted by everyone

nnelluri-cisco · 2025-07-11T05:07:08Z

In general the DPU interfaces could affect some tests, not only the QOS test. For us we just don't add those interfaces to the ansible/files/sonic_lab_links.csv. And then there is no need to change the existing tests.

@congh-nvidia
we are not providing DPU interafces on ansible/files/sonic_lab_links.csv ( we only provide front panel ports information in to this file).

The DPU interfaces show up like below when all the DPU modules are active on the system
Ethernet224 18.0.202.0/31 up/up N/A N/A
Ethernet232 18.1.202.0/31 up/up N/A N/A
Ethernet240 18.2.202.0/31 up/up N/A N/A
Ethernet248 18.3.202.0/31 up/up N/A N/A
Ethernet256 18.4.202.0/31 up/up N/A N/A
Ethernet264 18.5.202.0/31 up/up N/A N/A
Ethernet272 18.6.202.0/31 up/up N/A N/A
Ethernet280 18.7.202.0/31 up/up N/A N/A

These ineterfaces are not show up when DPU are in dark mode.
Since these interafces has IP address , it breaks certain sonic-mgmt tests.

Can u please double check and let me know?

nnelluri-cisco · 2025-07-11T05:07:45Z

@nnelluri-cisco lets close on common approach for all SS dependent scripts which can be adopted by everyone

sure @bhavani

mssonicbld · 2025-07-13T06:42:36Z

/azp run

azure-pipelines · 2025-07-13T06:42:49Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-07-13T15:11:41Z

/azp run

azure-pipelines · 2025-07-13T15:11:54Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-08-20T04:25:34Z

/azp run

azure-pipelines · 2025-08-20T04:25:47Z

Azure Pipelines successfully started running 1 pipeline(s).

nnelluri-cisco · 2025-08-20T04:27:09Z

@prabhataravind and @congh-nvidia
since we agreed on 18.X.202.0/31 for DPU interfaces, can u review the code and approve

tests/qos/qos_sai_base.py

mssonicbld · 2025-08-21T16:00:32Z

/azp run

azure-pipelines · 2025-08-21T16:00:46Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2025-11-18T17:08:09Z

Azure Pipelines successfully started running 1 pipeline(s).

prabhataravind · 2025-12-15T18:24:56Z

@yxieca @prsunny please help approve/merge

…c-net#19495) Approach exclude new DPU interfaces Ethernet-224 to Ethernet-280 What is the motivation for this PR? The new DPU interfaces Ethernet-224 to Ethernet-280 is breaking test_qos_sai.py regression in latest master branch. How did you verify/test it? Ran complete test_qos_sai.py regression under sonic-mgmt. with new changes and all tests pass. Signed-off-by: Saravanan <[email protected]>

…c-net#19495) Approach exclude new DPU interfaces Ethernet-224 to Ethernet-280 What is the motivation for this PR? The new DPU interfaces Ethernet-224 to Ethernet-280 is breaking test_qos_sai.py regression in latest master branch. How did you verify/test it? Ran complete test_qos_sai.py regression under sonic-mgmt. with new changes and all tests pass. Signed-off-by: Guy Shemesh <[email protected]>

…c-net#19495) Approach exclude new DPU interfaces Ethernet-224 to Ethernet-280 What is the motivation for this PR? The new DPU interfaces Ethernet-224 to Ethernet-280 is breaking test_qos_sai.py regression in latest master branch. How did you verify/test it? Ran complete test_qos_sai.py regression under sonic-mgmt. with new changes and all tests pass. Signed-off-by: Nishanth Sampath Kumar <[email protected]>

…c-net#19495) Approach exclude new DPU interfaces Ethernet-224 to Ethernet-280 What is the motivation for this PR? The new DPU interfaces Ethernet-224 to Ethernet-280 is breaking test_qos_sai.py regression in latest master branch. How did you verify/test it? Ran complete test_qos_sai.py regression under sonic-mgmt. with new changes and all tests pass. Signed-off-by: selldinesh <[email protected]>

…c-net#19495) Approach exclude new DPU interfaces Ethernet-224 to Ethernet-280 What is the motivation for this PR? The new DPU interfaces Ethernet-224 to Ethernet-280 is breaking test_qos_sai.py regression in latest master branch. How did you verify/test it? Ran complete test_qos_sai.py regression under sonic-mgmt. with new changes and all tests pass. Signed-off-by: Guy Shemesh <[email protected]>

…c-net#19495) Approach exclude new DPU interfaces Ethernet-224 to Ethernet-280 What is the motivation for this PR? The new DPU interfaces Ethernet-224 to Ethernet-280 is breaking test_qos_sai.py regression in latest master branch. How did you verify/test it? Ran complete test_qos_sai.py regression under sonic-mgmt. with new changes and all tests pass. Signed-off-by: Venkata Gouri Rajesh Etla <[email protected]>

…c-net#19495) Approach exclude new DPU interfaces Ethernet-224 to Ethernet-280 What is the motivation for this PR? The new DPU interfaces Ethernet-224 to Ethernet-280 is breaking test_qos_sai.py regression in latest master branch. How did you verify/test it? Ran complete test_qos_sai.py regression under sonic-mgmt. with new changes and all tests pass.

…c-net#19495) Approach exclude new DPU interfaces Ethernet-224 to Ethernet-280 What is the motivation for this PR? The new DPU interfaces Ethernet-224 to Ethernet-280 is breaking test_qos_sai.py regression in latest master branch. How did you verify/test it? Ran complete test_qos_sai.py regression under sonic-mgmt. with new changes and all tests pass. Signed-off-by: YiFan Wang <[email protected]>

…c-net#19495) Approach exclude new DPU interfaces Ethernet-224 to Ethernet-280 What is the motivation for this PR? The new DPU interfaces Ethernet-224 to Ethernet-280 is breaking test_qos_sai.py regression in latest master branch. How did you verify/test it? Ran complete test_qos_sai.py regression under sonic-mgmt. with new changes and all tests pass. Signed-off-by: Priyansh Tratiya <[email protected]>

…c-net#19495) Approach exclude new DPU interfaces Ethernet-224 to Ethernet-280 What is the motivation for this PR? The new DPU interfaces Ethernet-224 to Ethernet-280 is breaking test_qos_sai.py regression in latest master branch. How did you verify/test it? Ran complete test_qos_sai.py regression under sonic-mgmt. with new changes and all tests pass. Signed-off-by: Yael Tzur <[email protected]>

…c-net#19495) Approach exclude new DPU interfaces Ethernet-224 to Ethernet-280 What is the motivation for this PR? The new DPU interfaces Ethernet-224 to Ethernet-280 is breaking test_qos_sai.py regression in latest master branch. How did you verify/test it? Ran complete test_qos_sai.py regression under sonic-mgmt. with new changes and all tests pass.

mssonicbld · 2026-02-09T22:02:47Z

Cherry-pick PR to 202511: #22301

KrisNey-MSFT · 2026-02-09T22:05:47Z

pinged this PR to @prsunny to label and move forward

…c-net#19495) Approach exclude new DPU interfaces Ethernet-224 to Ethernet-280 What is the motivation for this PR? The new DPU interfaces Ethernet-224 to Ethernet-280 is breaking test_qos_sai.py regression in latest master branch. How did you verify/test it? Ran complete test_qos_sai.py regression under sonic-mgmt. with new changes and all tests pass. Signed-off-by: Raghavendran Ramanathan <[email protected]>

…c-net#19495) Approach exclude new DPU interfaces Ethernet-224 to Ethernet-280 What is the motivation for this PR? The new DPU interfaces Ethernet-224 to Ethernet-280 is breaking test_qos_sai.py regression in latest master branch. How did you verify/test it? Ran complete test_qos_sai.py regression under sonic-mgmt. with new changes and all tests pass. Signed-off-by: Zhuohui Tan <[email protected]>

Approach exclude new DPU interfaces Ethernet-224 to Ethernet-280 What is the motivation for this PR? The new DPU interfaces Ethernet-224 to Ethernet-280 is breaking test_qos_sai.py regression in latest master branch. How did you verify/test it? Ran complete test_qos_sai.py regression under sonic-mgmt. with new changes and all tests pass.

…c-net#19495) Approach exclude new DPU interfaces Ethernet-224 to Ethernet-280 What is the motivation for this PR? The new DPU interfaces Ethernet-224 to Ethernet-280 is breaking test_qos_sai.py regression in latest master branch. How did you verify/test it? Ran complete test_qos_sai.py regression under sonic-mgmt. with new changes and all tests pass. Signed-off-by: Abhishek <[email protected]>

…c-net#19495) Approach exclude new DPU interfaces Ethernet-224 to Ethernet-280 What is the motivation for this PR? The new DPU interfaces Ethernet-224 to Ethernet-280 is breaking test_qos_sai.py regression in latest master branch. How did you verify/test it? Ran complete test_qos_sai.py regression under sonic-mgmt. with new changes and all tests pass.

bpar9 requested changes Jul 10, 2025

View reviewed changes

tests/common/devices/sonic.py Outdated Show resolved Hide resolved

tests/common/devices/sonic.py Show resolved Hide resolved

bpar9 approved these changes Jul 10, 2025

View reviewed changes

prabhataravind reviewed Jul 10, 2025

View reviewed changes

tests/common/devices/sonic.py Outdated Show resolved Hide resolved

prabhataravind requested changes Jul 10, 2025

View reviewed changes

rameshraghupathy reviewed Jul 10, 2025

View reviewed changes

tests/common/devices/sonic.py Show resolved Hide resolved

congh-nvidia reviewed Jul 11, 2025

View reviewed changes

wen587 reviewed Jul 11, 2025

View reviewed changes

bpar9 requested changes Jul 11, 2025

View reviewed changes

congh-nvidia reviewed Aug 20, 2025

View reviewed changes

tests/qos/qos_sai_base.py Show resolved Hide resolved

nnelluri-cisco force-pushed the qos_fix_for_dpu_lit_mode branch from 98c7c5f to 2420f3e Compare August 25, 2025 17:59

prabhataravind approved these changes Dec 15, 2025

View reviewed changes

yxieca merged commit 92f9d93 into sonic-net:master Dec 15, 2025
19 checks passed

prsunny added Request for 202511 branch Request to backport a change to 202511 branch Approved for 202511 branch labels Feb 9, 2026

mssonicbld added the Created PR to 202511 branch label Feb 9, 2026

mssonicbld mentioned this pull request Feb 9, 2026

[action] [PR:19495] fix for qos failures for master branch due to backplane changes #22301

Merged

9 tasks

mssonicbld added Included in 202511 branch and removed Created PR to 202511 branch labels Feb 20, 2026

Conversation

nnelluri-cisco commented Jul 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of PR

Type of change

Back port request

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Uh oh!

mssonicbld commented Jul 9, 2025

Uh oh!

azure-pipelines bot commented Jul 9, 2025

Uh oh!

nnelluri-cisco commented Jul 9, 2025

Uh oh!

mssonicbld commented Jul 9, 2025

Uh oh!

azure-pipelines bot commented Jul 9, 2025

Uh oh!

Uh oh!

Uh oh!

mssonicbld commented Jul 10, 2025

Uh oh!

azure-pipelines bot commented Jul 10, 2025

Uh oh!

prabhataravind commented Jul 10, 2025

Uh oh!

Uh oh!

prabhataravind left a comment

Choose a reason for hiding this comment

Uh oh!

rameshraghupathy left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

congh-nvidia Jul 11, 2025

Choose a reason for hiding this comment

Uh oh!

nnelluri-cisco Aug 20, 2025

Choose a reason for hiding this comment

Uh oh!

congh-nvidia commented Jul 11, 2025

Uh oh!

wen587 Jul 11, 2025

Choose a reason for hiding this comment

Uh oh!

nnelluri-cisco Jul 11, 2025

Choose a reason for hiding this comment

Uh oh!

bpar9 left a comment

Choose a reason for hiding this comment

Uh oh!

nnelluri-cisco commented Jul 11, 2025

Uh oh!

nnelluri-cisco commented Jul 11, 2025

Uh oh!

mssonicbld commented Jul 13, 2025

Uh oh!

azure-pipelines bot commented Jul 13, 2025

Uh oh!

mssonicbld commented Jul 13, 2025

Uh oh!

azure-pipelines bot commented Jul 13, 2025

Uh oh!

mssonicbld commented Aug 20, 2025

Uh oh!

azure-pipelines bot commented Aug 20, 2025

Uh oh!

nnelluri-cisco commented Aug 20, 2025

Uh oh!

Uh oh!

mssonicbld commented Aug 21, 2025

Uh oh!

azure-pipelines bot commented Aug 21, 2025

Uh oh!

nnelluri-cisco commented Jul 9, 2025 •

edited

Loading