deploy script changes for smartswitch lit mode by nnelluri-cisco · Pull Request #21174 · sonic-net/sonic-mgmt

nnelluri-cisco · 2025-11-03T05:35:14Z

Description of PR

incorporated the DPC role fix in the minigraph by replacing port_name with port_alias, since port_name was not functioning correctly.

Summary:
Fixes # (issue)

Type of change

[ X] Bug fix
Testbed and Framework(new/improvement)
New Test case
- Skipped for non-supported platforms
Test case improvement

Back port request

Approach

What is the motivation for this PR?

port_name is causing deploy_mg to be failed.
replaced port_name with port_alias

How did you do it?

Deployed minigraph and make sure deploy-mg went fine without any error.

How did you verify/test it?

Deployed minigraph and make sure deploy-mg went fine without any error.

Any platform specific information?

Smartswitch

Supported testbed topology if it's a new test case?

Documentation

mssonicbld · 2025-11-03T05:35:22Z

/azp run

azure-pipelines · 2025-11-03T05:35:35Z

Azure Pipelines successfully started running 1 pipeline(s).

nnelluri-cisco · 2025-11-03T05:36:17Z

@prabhataravind and @rameshraghupathy
Please review and approve the changes

mssonicbld · 2025-11-03T22:51:08Z

/azp run

azure-pipelines · 2025-11-03T22:51:23Z

Azure Pipelines successfully started running 1 pipeline(s).

prabhataravind · 2025-11-07T01:38:03Z

/azp run

azure-pipelines · 2025-11-07T01:38:17Z

Azure Pipelines successfully started running 1 pipeline(s).

KrisNey-MSFT · 2025-11-18T23:35:34Z

hi @nnelluri-cisco - looks like we are failing some checks

mssonicbld · 2025-11-19T00:56:35Z

/azp run

azure-pipelines · 2025-11-19T00:56:49Z

Azure Pipelines successfully started running 1 pipeline(s).

nnelluri-cisco · 2025-11-19T04:20:40Z

@KrisNey-MSFT
Can you please ask some one MSFT to merge this PR.

KrisNey-MSFT · 2025-11-19T04:43:01Z

Hi @prabhataravind - looks like this is fixed. Would you mind merging please?

prabhataravind · 2025-12-15T18:20:07Z

hi @yxieca could you help merge this?

yxieca · 2025-12-15T18:35:51Z

ansible/templates/minigraph_device.j2

          <PortName>0</PortName>
          <Priority>0</Priority>
-{% set intf = port_name[index] %}
+{% set intf = port_alias[index] %}


This could be a dangerous change. It could potentially break the other platforms where port_name works.

@wangxin @lolyu can you chime in here? This PR passed all checkers.

@yxieca this was added for smartswitch in PR #20244. I don't think any other platform needs this change. It should be a no-op for other platforms.

hi @yxieca I checked again. This won't work. I have requested changes..

@nnelluri-cisco please confirm what port_alias[index] resolves to. If it is etp, this change won't work.

Thanks @prabhataravind for catching the error.
I have provided the correct fix , please review it and I deployed minigrapg and changes are wokring fine "Dpc" role is generated in "minigraph.xml" file.

Sample snippet for etp28 and etp29 ports. <a:EthernetInterface> <ElementType>DeviceInterface</ElementType> <AlternateSpeeds i:nil="true"/> <EnableFlowControl>true</EnableFlowControl> <Index>1</Index> <InterfaceName>etp28</InterfaceName> <InterfaceType i:nil="true"/> <MultiPortsInterface>false</MultiPortsInterface> <PortName>0</PortName> <Priority>0</Priority> <role>Dpc</role> <Speed>200000</Speed> </a:EthernetInterface> <a:EthernetInterface> <ElementType>DeviceInterface</ElementType> <AlternateSpeeds i:nil="true"/> <EnableFlowControl>true</EnableFlowControl> <Index>1</Index> <InterfaceName>etp29</InterfaceName> <InterfaceType i:nil="true"/> <MultiPortsInterface>false</MultiPortsInterface> <PortName>0</PortName> <Priority>0</Priority> <role>Dpc</role> <Speed>200000</Speed>

prabhataravind

Port alias index check against 227 will never work. This is not right.

mssonicbld · 2025-12-16T00:43:00Z

/azp run

azure-pipelines · 2025-12-16T00:43:13Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2025-12-16T00:43:13Z

Azure Pipelines successfully started running 1 pipeline(s).

rameshraghupathy · 2025-12-16T16:57:22Z

ansible/templates/minigraph_device.j2

-{% set intf = port_name[index] %}
-{% if subtype is defined and subtype == 'SmartSwitch' and intf[8:]|int >= 224 %}
+{% set alias = port_alias[index] %}
+{% if alias in port_alias_map %}


@nnelluri-cisco can we check if "port_alias_map is defined" as shown {% if port_alias_map is defined and alias in port_alias_map %}

@rameshraghupathy
Check the "port_alias_map" which will be defined during deploy-mg workflow.

"port_alias_map": { "etp0": "Ethernet0", "etp1": "Ethernet8", "etp10": "Ethernet80", "etp11": "Ethernet88", "etp12": "Ethernet96", "etp13": "Ethernet104", "etp14": "Ethernet112", "etp15": "Ethernet120", "etp16": "Ethernet128", "etp17": "Ethernet136", "etp18": "Ethernet144", "etp19": "Ethernet152", "etp2": "Ethernet16", "etp20": "Ethernet160", "etp21": "Ethernet168", "etp22": "Ethernet176", "etp23": "Ethernet184", "etp24": "Ethernet192", "etp25": "Ethernet200", "etp26": "Ethernet208", "etp27": "Ethernet216", "etp28": "Ethernet224", "etp29": "Ethernet232", "etp3": "Ethernet24", "etp30": "Ethernet240", "etp31": "Ethernet248", "etp32": "Ethernet256", "etp33": "Ethernet264", "etp34": "Ethernet272", "etp35": "Ethernet280", "etp4": "Ethernet32", "etp5": "Ethernet40", "etp6": "Ethernet48", "etp7": "Ethernet56", "etp8": "Ethernet64", "etp9": "Ethernet72" },

rameshraghupathy · 2025-12-16T17:22:48Z

LGTM
@nnelluri-cisco can you take care of https://github.com/sonic-net/sonic-mgmt/pull/21174/checks?check_run_id=58147433300 ?

mssonicbld · 2025-12-16T17:36:50Z

/azp run

azure-pipelines · 2025-12-16T17:37:07Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-12-16T18:02:36Z

/azp run

azure-pipelines · 2025-12-16T18:02:51Z

Azure Pipelines successfully started running 1 pipeline(s).

nnelluri-cisco · 2025-12-17T19:35:36Z

/azp run

azure-pipelines · 2025-12-17T19:35:43Z

Commenter does not have sufficient privileges for PR 21174 in repo sonic-net/sonic-mgmt

mssonicbld · 2025-12-17T22:14:19Z

/azp run

azure-pipelines · 2025-12-17T22:14:34Z

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: nnelluri-cisco <nnelluri@cisco.com>

mssonicbld · 2026-01-05T22:37:29Z

/azp run

azure-pipelines · 2026-01-05T22:37:43Z

Azure Pipelines successfully started running 1 pipeline(s).

KrisNey-MSFT · 2026-01-29T19:53:26Z

hi guys, are all of the fixes in here?

nnelluri-cisco · 2026-01-29T20:10:17Z

yes @KrisNey-MSFT
Can you please request some one to merge from MSFT side.

KrisNey-MSFT · 2026-01-29T20:11:52Z

hi @prsunny or @prabhataravind - could we have someone to review/merge on the SONiC team please?

KrisNey-MSFT · 2026-02-09T21:44:01Z

@vvolam to possibly help?

prabhataravind · 2026-02-18T21:03:36Z

@rameshraghupathy is this needed now that port "role" is part of the image itself?

nnelluri-cisco · 2026-03-26T00:44:53Z

@rameshraghupathy
we need this change other wise deploy-mg still fails.
TASK [create new minigraph file for SONiC device] **********************************************************************************************************
An exception occurred during task execution. To see the full traceback, use -vvv. The error was: ansible.errors.AnsibleUndefinedVariable: 'port_name' is undefined
fatal: [MtFuji-dut01]: FAILED! => {"changed": false, "msg": "AnsibleUndefinedVariable: 'port_name' is undefined"}
An exception occurred during task execution. To see the full traceback, use -vvv. The error was: ansible.errors.AnsibleUndefinedVariable: 'port_name' is undefined
fatal: [MtFuji-dut02]: FAILED! => {"changed": false, "msg": "AnsibleUndefinedVariable: 'port_name' is undefined"}

PLAY RECAP *************************************************************************************************************************************************
MtFuji-dut01 : ok=55 changed=4 unreachable=0 failed=1 skipped=41 rescued=0 ignored=0
MtFuji-dut02 : ok=55 changed=4 unreachable=0 failed=1 skipped=40 rescued=0 ignored=0

sco@swicth1:~$ show ver | head

SONiC Software Version: SONiC.20251110.16
SONiC OS Version: 13
Distribution: Debian 13.3
Kernel: 6.12.41+deb13-sonic-amd64
Build commit: 0c2696527c
Build date: Sat Mar 14 02:38:41 UTC 2026
Built by: azureuser@b02344a1c000000

nnelluri-cisco requested review from wangxin and yxieca as code owners November 3, 2025 05:35

prabhataravind approved these changes Nov 7, 2025

View reviewed changes

nnelluri-cisco force-pushed the smartswicth-litmode branch from 2c55666 to 68e1ac0 Compare November 19, 2025 00:56

prabhataravind added the Request for msft-202506 Branch label Nov 25, 2025

prabhataravind added Request for 202511 branch Request to backport a change to 202511 branch Approved for msft-202506 Branch labels Dec 15, 2025

vmittal-msft added the Approved for 202511 branch label Dec 15, 2025

vmittal-msft enabled auto-merge (squash) December 15, 2025 18:33

vmittal-msft self-requested a review December 15, 2025 18:33

vmittal-msft previously approved these changes Dec 15, 2025

View reviewed changes

yxieca reviewed Dec 15, 2025

View reviewed changes

prabhataravind requested changes Dec 15, 2025

View reviewed changes

prabhataravind removed Request for 202511 branch Request to backport a change to 202511 branch Approved for 202511 branch labels Dec 15, 2025

auto-merge was automatically disabled December 16, 2025 00:42
Head branch was pushed to by a user without write access

nnelluri-cisco dismissed vmittal-msft’s stale review via bfd1843 December 16, 2025 00:42

rameshraghupathy reviewed Dec 16, 2025

View reviewed changes

nnelluri-cisco requested a review from prabhataravind December 16, 2025 17:15

rameshraghupathy approved these changes Dec 16, 2025

View reviewed changes

nnelluri-cisco force-pushed the smartswicth-litmode branch from bfd1843 to 977dbdf Compare December 16, 2025 17:36

nnelluri-cisco force-pushed the smartswicth-litmode branch from 977dbdf to 3e1cac5 Compare December 16, 2025 18:02

nnelluri-cisco force-pushed the smartswicth-litmode branch from 3e1cac5 to c8ebdc4 Compare December 17, 2025 22:13

nnelluri-cisco added 3 commits January 5, 2026 14:36

deploy script changes for smartswitch lit mode

f82b5aa

Signed-off-by: nnelluri-cisco <nnelluri@cisco.com>

removed unwanted code added in previous commit

85a40ea

Signed-off-by: nnelluri-cisco <nnelluri@cisco.com>

Fix Dpc role logic: derive Ethernet index from port alias

b8138f1

Signed-off-by: nnelluri-cisco <nnelluri@cisco.com>

nnelluri-cisco force-pushed the smartswicth-litmode branch from c8ebdc4 to b8138f1 Compare January 5, 2026 22:37

Conversation

nnelluri-cisco commented Nov 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of PR

Type of change

Back port request

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Uh oh!

mssonicbld commented Nov 3, 2025

Uh oh!

azure-pipelines bot commented Nov 3, 2025

Uh oh!

nnelluri-cisco commented Nov 3, 2025

Uh oh!

mssonicbld commented Nov 3, 2025

Uh oh!

azure-pipelines bot commented Nov 3, 2025

Uh oh!

prabhataravind commented Nov 7, 2025

Uh oh!

azure-pipelines bot commented Nov 7, 2025

Uh oh!

KrisNey-MSFT commented Nov 18, 2025

Uh oh!

mssonicbld commented Nov 19, 2025

Uh oh!

azure-pipelines bot commented Nov 19, 2025

Uh oh!

nnelluri-cisco commented Nov 19, 2025

Uh oh!

KrisNey-MSFT commented Nov 19, 2025

Uh oh!

prabhataravind commented Dec 15, 2025

Uh oh!

yxieca Dec 15, 2025

Choose a reason for hiding this comment

Uh oh!

yxieca Dec 15, 2025

Choose a reason for hiding this comment

Uh oh!

prabhataravind Dec 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

prabhataravind Dec 15, 2025

Choose a reason for hiding this comment

Uh oh!

prabhataravind Dec 15, 2025

Choose a reason for hiding this comment

Uh oh!

nnelluri-cisco Dec 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

prabhataravind left a comment

Choose a reason for hiding this comment

Uh oh!

mssonicbld commented Dec 16, 2025

Uh oh!

azure-pipelines bot commented Dec 16, 2025

Uh oh!

azure-pipelines bot commented Dec 16, 2025

Uh oh!

rameshraghupathy Dec 16, 2025

Choose a reason for hiding this comment

Uh oh!

nnelluri-cisco Dec 16, 2025

Choose a reason for hiding this comment

Uh oh!

rameshraghupathy commented Dec 16, 2025

Uh oh!

mssonicbld commented Dec 16, 2025

Uh oh!

azure-pipelines bot commented Dec 16, 2025

nnelluri-cisco commented Nov 3, 2025 •

edited

Loading

prabhataravind Dec 15, 2025 •

edited

Loading

nnelluri-cisco Dec 16, 2025 •

edited

Loading