Skip to content

[dualotr] Fix disruptions after config reload#20095

Merged
bingwang-ms merged 1 commit intosonic-net:masterfrom
lolyu:fix_disruption_reload
Aug 7, 2025
Merged

[dualotr] Fix disruptions after config reload#20095
bingwang-ms merged 1 commit intosonic-net:masterfrom
lolyu:fix_disruption_reload

Conversation

@lolyu
Copy link
Collaborator

@lolyu lolyu commented Aug 6, 2025 •
edited
Loading

The device could be unstable after config reload, which results in possible packet drop and test failure.
Let's wait for more time after config reload.
And decrease the I/O verification time to 60s to reduce the test runtime.

Description of PR

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202205
  • 202305
  • 202311
  • 202405
  • 202411
  • 202505

Approach

What is the motivation for this PR?

The device could be unstable after config reload, which results in
possible packet drop and test failure.
Let's wait for more time after config reload.
And decrease the I/O verification time to 60s to reduce the test runtime.

Signed-off-by: Longxiang Lyu <lolv@microsoft.com

How did you do it?

Reload with safe_reload and wait_for_bgp to allow the DUT to recover.

How did you verify/test it?

dualtor_io/test_link_failure.py::test_active_link_admin_down_config_reload_downstream[active-active-1-10] PASSED                         [ 10%]
dualtor_io/test_link_failure.py::test_active_link_admin_down_config_reload_downstream[active-active-2-10] PASSED                         [ 20%]
dualtor_io/test_link_failure.py::test_active_link_admin_down_config_reload_downstream[active-active-3-10] PASSED                         [ 30%]
dualtor_io/test_link_failure.py::test_active_link_admin_down_config_reload_downstream[active-active-4-10] PASSED                         [ 40%]
dualtor_io/test_link_failure.py::test_active_link_admin_down_config_reload_downstream[active-active-5-10] PASSED                         [ 50%]
dualtor_io/test_link_failure.py::test_active_link_admin_down_config_reload_downstream[active-active-6-10] PASSED                         [ 60%]
dualtor_io/test_link_failure.py::test_active_link_admin_down_config_reload_downstream[active-active-7-10] PASSED                         [ 70%]
dualtor_io/test_link_failure.py::test_active_link_admin_down_config_reload_downstream[active-active-8-10] PASSED                                                  [ 80%]
dualtor_io/test_link_failure.py::test_active_link_admin_down_config_reload_downstream[active-active-9-10] PASSED                         [ 90%]
dualtor_io/test_link_failure.py::test_active_link_admin_down_config_reload_downstream[active-active-10-10] PASSED                        [100%]

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@mssonicbld
Copy link
Collaborator

mssonicbld commented Aug 6, 2025

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Aug 6, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@lolyu
[dualotr] Fix disruptions after config reload
6977f79 
The device could be unstable after config reload, which results in
possible packet drop and test failure.
Let's wait for more time after config reload.
And decrease the I/O verification time to 60s to reduce the test runtime.

Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
@lolyu lolyu force-pushed the fix_disruption_reload branch from 1b9c2b7 to 6977f79 Compare August 7, 2025 01:53
@mssonicbld
Copy link
Collaborator

mssonicbld commented Aug 7, 2025

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Aug 7, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@lolyu lolyu requested a review from bingwang-ms August 7, 2025 01:55
bingwang-ms
bingwang-ms approved these changes Aug 7, 2025
View reviewed changes
Copy link
Collaborator

@bingwang-ms bingwang-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix

@bingwang-ms bingwang-ms merged commit 02bbcd3 into sonic-net:master Aug 7, 2025
18 of 20 checks passed
mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Aug 7, 2025
@lolyu @mssonicbld
[dualotr] Fix disruptions after config reload (sonic-net#20095)
bf76675 
The device could be unstable after config reload, which results in
possible packet drop and test failure.
Let's wait for more time after config reload.
And decrease the I/O verification time to 60s to reduce the test runtime.

Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
@mssonicbld
Copy link
Collaborator

mssonicbld commented Aug 7, 2025

Cherry-pick PR to 202411: #20121

@mssonicbld mssonicbld mentioned this pull request Aug 7, 2025
Closed
11 tasks
nissampa pushed a commit to nissampa/sonic-mgmt_dpu_test that referenced this pull request Aug 7, 2025
@lolyu @nissampa
[dualotr] Fix disruptions after config reload (sonic-net#20095)
1f903ff 
The device could be unstable after config reload, which results in
possible packet drop and test failure.
Let's wait for more time after config reload.
And decrease the I/O verification time to 60s to reduce the test runtime.

Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Aug 8, 2025
@lolyu @mssonicbld
[dualotr] Fix disruptions after config reload (sonic-net#20095)
5b97654 
The device could be unstable after config reload, which results in
possible packet drop and test failure.
Let's wait for more time after config reload.
And decrease the I/O verification time to 60s to reduce the test runtime.

Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
@mssonicbld
Copy link
Collaborator

mssonicbld commented Aug 8, 2025

Cherry-pick PR to 202505: #20137

@mssonicbld mssonicbld mentioned this pull request Aug 8, 2025
Merged
11 tasks
mssonicbld pushed a commit that referenced this pull request Aug 8, 2025
@lolyu @mssonicbld
[dualotr] Fix disruptions after config reload (#20095)
150b361 
The device could be unstable after config reload, which results in
possible packet drop and test failure.
Let's wait for more time after config reload.
And decrease the I/O verification time to 60s to reduce the test runtime.

Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Aug 13, 2025
@lolyu @mssonicbld
[dualotr] Fix disruptions after config reload (sonic-net#20095)
b43cd9b 
The device could be unstable after config reload, which results in
possible packet drop and test failure.
Let's wait for more time after config reload.
And decrease the I/O verification time to 60s to reduce the test runtime.

Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
@mssonicbld
Copy link
Collaborator

mssonicbld commented Aug 13, 2025

Cherry-pick PR to 202411: #20222

@mssonicbld mssonicbld mentioned this pull request Aug 13, 2025
Open
11 tasks
ashutosh-agrawal pushed a commit to ashutosh-agrawal/sonic-mgmt that referenced this pull request Aug 14, 2025
@lolyu @ashutosh-agrawal
[dualotr] Fix disruptions after config reload (sonic-net#20095)
88cf6f4 
The device could be unstable after config reload, which results in
possible packet drop and test failure.
Let's wait for more time after config reload.
And decrease the I/O verification time to 60s to reduce the test runtime.

Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
vidyac86 pushed a commit to vidyac86/sonic-mgmt that referenced this pull request Oct 23, 2025
@lolyu @vidyac86
[dualotr] Fix disruptions after config reload (sonic-net#20095)
8b6766e 
The device could be unstable after config reload, which results in
possible packet drop and test failure.
Let's wait for more time after config reload.
And decrease the I/O verification time to 60s to reduce the test runtime.

Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
opcoder0 pushed a commit to opcoder0/sonic-mgmt that referenced this pull request Dec 8, 2025
@lolyu
[dualotr] Fix disruptions after config reload (sonic-net#20095)
10cb751 
The device could be unstable after config reload, which results in
possible packet drop and test failure.
Let's wait for more time after config reload.
And decrease the I/O verification time to 60s to reduce the test runtime.

Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Dec 16, 2025
@lolyu @gshemesh2
[dualotr] Fix disruptions after config reload (sonic-net#20095)
cc7dc0e 
The device could be unstable after config reload, which results in
possible packet drop and test failure.
Let's wait for more time after config reload.
And decrease the I/O verification time to 60s to reduce the test runtime.

Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
AharonMalkin pushed a commit to AharonMalkin/sonic-mgmt that referenced this pull request Dec 16, 2025
@lolyu @AharonMalkin
[dualotr] Fix disruptions after config reload (sonic-net#20095)
7097607 
The device could be unstable after config reload, which results in
possible packet drop and test failure.
Let's wait for more time after config reload.
And decrease the I/O verification time to 60s to reduce the test runtime.

Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
Signed-off-by: Aharon Malkin <amalkin@nvidia.com>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Dec 21, 2025
@lolyu @gshemesh2
[dualotr] Fix disruptions after config reload (sonic-net#20095)
834ee45 
The device could be unstable after config reload, which results in
possible packet drop and test failure.
Let's wait for more time after config reload.
And decrease the I/O verification time to 60s to reduce the test runtime.

Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
venu-nexthop pushed a commit to venu-nexthop/sonic-mgmt that referenced this pull request Jan 13, 2026
@lolyu @venu-nexthop
[dualotr] Fix disruptions after config reload (sonic-net#20095)
da0b3c1 
The device could be unstable after config reload, which results in
possible packet drop and test failure.
Let's wait for more time after config reload.
And decrease the I/O verification time to 60s to reduce the test runtime.

Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Jan 26, 2026
@lolyu @gshemesh2
[dualotr] Fix disruptions after config reload (sonic-net#20095)
e9fcafb 
The device could be unstable after config reload, which results in
possible packet drop and test failure.
Let's wait for more time after config reload.
And decrease the I/O verification time to 60s to reduce the test runtime.

Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
ytzur1 pushed a commit to ytzur1/sonic-mgmt that referenced this pull request Feb 2, 2026
@lolyu @ytzur1
[dualotr] Fix disruptions after config reload (sonic-net#20095)
d347786 
The device could be unstable after config reload, which results in
possible packet drop and test failure.
Let's wait for more time after config reload.
And decrease the I/O verification time to 60s to reduce the test runtime.

Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
Signed-off-by: Yael Tzur <ytzur@nvidia.com>
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
@yxieca
Revert "[ci/build]: Upgrade SONiC package versions (sonic-net#20095)" (…
f97f69d 
…sonic-net#20124)

This reverts commit 652b388.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bingwang-ms bingwang-ms bingwang-ms approved these changes

Assignees

No one assigned

Labels

Approved for 202411 branch Approved for 202505 branch Created PR to 202411 branch Included in 202505 branch Request for 202411 branch Request for 202505 branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lolyu @mssonicbld @bingwang-ms @yejianquan