Fix shutdown/startup flow in test_reset to support multi-asic #20120
Merged
roy-sror merged 10 commits intosonic-net:masterfrom Aug 10, 2025
Merged
Fix shutdown/startup flow in test_reset to support multi-asic #20120roy-sror merged 10 commits intosonic-net:masterfrom
roy-sror merged 10 commits intosonic-net:masterfrom
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
ytzur1
force-pushed
the
fix_multi_asic_flow
branch
from
21c2232 to
146ee37
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
11 tasks
Contributor
|
@YatishSVC - can u approve this PR? |
Contributor
Thanks @ytzur1, lgtm, I'll approve |
Contributor
|
@mihirpat1, @prgeor, |
YatishSVC
added
Request for 202505 branch
and removed
Cherry Pick Conflict_msft-202412
labels
mihirpat1
approved these changes
Aug 7, 2025
roy-sror
approved these changes
Aug 10, 2025
Collaborator
|
hi @ytzur1 , will need some help to pick this one to 202412 |
Collaborator
|
@ytzur1 PR conflicts with 202505 branch |
arlakshm
pushed a commit
to Azure/sonic-mgmt.msft
that referenced
this pull request
Aug 11, 2025
…ptics (#635) Cherry pick conflicts, so created new pull request. Pr's: sonic-net/sonic-mgmt#18772 sonic-net/sonic-mgmt#20120 sonic-net/sonic-mgmt#19691 Adding a check for Cloudlight optics. Adding multi asic support for test_reset Co-authored-by: yatishkoul <[email protected]>
ytzur1
added a commit
to ytzur1/sonic-mgmt
that referenced
this pull request
Aug 11, 2025
…net#20120) Fixed shutdown/startup flow in test_reset to support multi-asic for multi-asic devices, shutdown and startup commands with be preformed for each port and not in bulk Fix sonic-net#18772
ytzur1
added a commit
to ytzur1/sonic-mgmt
that referenced
this pull request
Aug 11, 2025
…net#20120) Fixed shutdown/startup flow in test_reset to support multi-asic for multi-asic devices, shutdown and startup commands with be preformed for each port and not in bulk Fix sonic-net#18772
Contributor
Author
added the fix to open PR - https://github.com/sonic-net/sonic-mgmt/pull/20096/files |
11 tasks
Collaborator
|
hi @ytzur1 , please let me know, once the PR is in 202412. |
Collaborator
|
also, if this is multi-asic only, it might not be land in 202412 branch as well. please let me know. |
Contributor
Author
|
Hi @r12f |
Collaborator
|
got it! thanks @ytzur1 ! kicked off CI and will follow up. |
r12f
added
Included in msft-202412 Branch
and removed
Cherry Pick Conflict_msft-202412
labels
ashutosh-agrawal
pushed a commit
to ashutosh-agrawal/sonic-mgmt
that referenced
this pull request
Aug 14, 2025
…net#20120) Fixed shutdown/startup flow in test_reset to support multi-asic for multi-asic devices, shutdown and startup commands with be preformed for each port and not in bulk Fix sonic-net#18772
roy-sror
pushed a commit
that referenced
this pull request
Aug 18, 2025
For test_sfp.py::test_reset - preformed shutdown and startup to all interfaces in bulk, instead of running the commands one by one on each port to improve running time Runtime Stats: before improvement: 00:20:45 avg after improvement: 00:01:35 avg includes the fix for multi-asic shutdown and startup #20120
vidyac86
pushed a commit
to vidyac86/sonic-mgmt
that referenced
this pull request
Oct 23, 2025
…net#20120) Fixed shutdown/startup flow in test_reset to support multi-asic for multi-asic devices, shutdown and startup commands with be preformed for each port and not in bulk Fix sonic-net#18772
opcoder0
pushed a commit
to opcoder0/sonic-mgmt
that referenced
this pull request
Dec 8, 2025
…net#20120) Fixed shutdown/startup flow in test_reset to support multi-asic for multi-asic devices, shutdown and startup commands with be preformed for each port and not in bulk Fix sonic-net#18772 Signed-off-by: opcoder0 <[email protected]>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 16, 2025
…net#20120) Fixed shutdown/startup flow in test_reset to support multi-asic for multi-asic devices, shutdown and startup commands with be preformed for each port and not in bulk Fix sonic-net#18772 Signed-off-by: Guy Shemesh <[email protected]>
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Dec 16, 2025
…net#20120) Fixed shutdown/startup flow in test_reset to support multi-asic for multi-asic devices, shutdown and startup commands with be preformed for each port and not in bulk Fix sonic-net#18772 Signed-off-by: Aharon Malkin <[email protected]>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 21, 2025
…net#20120) Fixed shutdown/startup flow in test_reset to support multi-asic for multi-asic devices, shutdown and startup commands with be preformed for each port and not in bulk Fix sonic-net#18772 Signed-off-by: Guy Shemesh <[email protected]>
venu-nexthop
pushed a commit
to venu-nexthop/sonic-mgmt
that referenced
this pull request
Jan 13, 2026
…net#20120) Fixed shutdown/startup flow in test_reset to support multi-asic for multi-asic devices, shutdown and startup commands with be preformed for each port and not in bulk Fix sonic-net#18772
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Jan 26, 2026
…net#20120) Fixed shutdown/startup flow in test_reset to support multi-asic for multi-asic devices, shutdown and startup commands with be preformed for each port and not in bulk Fix sonic-net#18772 Signed-off-by: Guy Shemesh <[email protected]>
ytzur1
added a commit
to ytzur1/sonic-mgmt
that referenced
this pull request
Feb 2, 2026
…net#20120) Fixed shutdown/startup flow in test_reset to support multi-asic for multi-asic devices, shutdown and startup commands with be preformed for each port and not in bulk Fix sonic-net#18772 Signed-off-by: Yael Tzur <[email protected]>
venu-nexthop
pushed a commit
to venu-nexthop/sonic-mgmt
that referenced
this pull request
Mar 27, 2026
…net#20120) Fixed shutdown/startup flow in test_reset to support multi-asic for multi-asic devices, shutdown and startup commands with be preformed for each port and not in bulk Fix sonic-net#18772
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Fixed shutdown/startup flow in test_reset to support multi-asic
for multi-asic devices, shutdown and startup commands with be preformed for each port and not in bulk
Fix #18772
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Fix #18772
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation