Revert "Improve runtime of test_check_sfp_presence"

This reverts commit 9e38b25.

Author: ytzur1

tests/platform_tests/mellanox/test_check_sfp_presence.py

@@ -13,45 +13,20 @@
 ]
 
 
-def parse_sfp_presence_output(sfp_presence_output):
-    """Parse the output of 'show interface transceiver presence' command.
-    Args:
-        sfp_presence_output: List of strings from the command output
-    Returns:
-        Dictionary mapping interface names to their presence status
-    """
-    table_header_length = 2
-    if not sfp_presence_output or len(sfp_presence_output) < table_header_length:
-        raise ValueError("Invalid output format: expected at least 2 lines")
-    sfp_presence_parsed = {}
-    for line in sfp_presence_output[table_header_length:]:
-        parts = line.split()
-        if len(parts) != 2:
-            raise ValueError(f"Invalid line: {line}")
-        port, status = parts
-        sfp_presence_parsed[port] = status
-    return sfp_presence_parsed
-
-
 def test_check_sfp_presence(duthosts, rand_one_dut_hostname, conn_graph_facts, dpu_npu_port_list):     # noqa F811
     """This test case is to check SFP presence status with CLI and sysfs.
     """
     duthost = duthosts[rand_one_dut_hostname]
     ports_config = json.loads(duthost.command("sudo sonic-cfggen -d --var-json PORT")["stdout"])    # noqa F841
-    check_intf_presence_command = 'show interface transceiver presence'
+    check_intf_presence_command = 'show interface transceiver presence {}'
 
     logging.info("Use show interface status information")
-    check_presence_output = duthost.command(check_intf_presence_command)
-    assert check_presence_output["rc"] == 0, \
-        f"Command '{check_intf_presence_command}' failed with return code {check_presence_output['rc']}"
-
-    presence_stdout_lines = check_presence_output["stdout_lines"]
-    presence_dict = parse_sfp_presence_output(presence_stdout_lines)
-    logging.info(f"Found {len(presence_dict)} interfaces with presence status: {presence_dict}")
-    intfs = conn_graph_facts["device_conn"][duthost.hostname]
-    intf_list_to_check = {intf for intf in intfs if intf not in dpu_npu_port_list[duthost.hostname]}
-    logging.info(f"Interfaces to check: {intf_list_to_check}")
-    intf_not_present = intf_list_to_check - set(presence_dict.keys())
-    assert len(intf_not_present) == 0, \
-        f"Missing interfaces in presence output: {intf_not_present}"
-    logging.info("All expected interfaces are present in the output")
+    for intf in conn_graph_facts["device_conn"][duthost.hostname]:
+        if intf not in dpu_npu_port_list[duthost.hostname]:
+            check_presence_output = duthost.command(check_intf_presence_command.format(intf))
+            assert check_presence_output["rc"] == 0, "Failed to read interface %s transceiver presence" % intf
+            logging.info(str(check_presence_output["stdout_lines"][2]))
+            presence_list = check_presence_output["stdout_lines"][2].split()
+            logging.info(str(presence_list))
+            assert intf in presence_list, "Wrong interface name in the output %s" % str(presence_list)
+            assert 'Present' in presence_list, "Status is not expected, output %s" % str(presence_list)