improve running time of test_sfp::test_reset#20096
Merged
roy-sror merged 3 commits intosonic-net:202505from Aug 18, 2025
Merged
improve running time of test_sfp::test_reset#20096roy-sror merged 3 commits intosonic-net:202505from
roy-sror merged 3 commits intosonic-net:202505from
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
Hi @ytzur1 , can you comment the PR to the master? |
Contributor
Author
|
Hi @yejianquan |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
roy-sror
previously approved these changes
Aug 11, 2025
…net#20120) Fixed shutdown/startup flow in test_reset to support multi-asic for multi-asic devices, shutdown and startup commands with be preformed for each port and not in bulk Fix sonic-net#18772
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
11 tasks
Collaborator
Thanks @ytzur1 , approved, can you fill in the 'How did you verify/test it?' in PR description so that I can merge it? |
Contributor
Author
|
Hi @yejianquan, I filled all fields. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
For test_sfp.py::test_reset - preformed shutdown and startup to all interfaces in bulk, instead of running the commands one by one on each port to improve running time
Runtime Stats:
before improvement: 00:20:45 avg
after improvement: 00:01:35 avg
includes the fix for multi-asic shutdown and startup #20120
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Runtime Optimization
How did you do it?
Reduced calls from test to switch to save on overhead time.
How did you verify/test it?
Internal Nightly Reg.
Any platform specific information?
Supported testbed topology if it's a new test case?
not a new test
Documentation