update autoneg setting to support 'off' when deploy-mg#20030
Merged
StormLiangMS merged 1 commit intosonic-net:masterfrom Aug 5, 2025
Merged
update autoneg setting to support 'off' when deploy-mg#20030StormLiangMS merged 1 commit intosonic-net:masterfrom
StormLiangMS merged 1 commit intosonic-net:masterfrom
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
r12f
approved these changes
Aug 4, 2025
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Aug 5, 2025
Summary: Current 'autoneg' column in links.csv only support 'on'. If it's 'off' or other settings, it will default to platform.json behavior. This PR add the support for 'off' settings. For DUT which want to use the default behavior, it can leave that column empty, or use any other value, e.g. 'none' Note: There will be a behavior change if user is using off in links.csv already for their DUT. old behavior: the autoneg settings will be derived from platform.json, which chould be on or off or not defined. new behavior: will be off always. If users is using off already, they need to update their links.csv to leave autoneg field as empty if they want to use the default settings in platform.json. What is the motivation for this PR? update autoneg setting to support 'off' How did you do it? Check autoneg value for both on and off in minigraph
Collaborator
|
Cherry-pick PR to 202505: #20063 |
11 tasks
r12f
added
Approved for msft-202412 Branch
and removed
Approved for msft-202412 Branch
labels
Collaborator
|
Cherry-pick PR to msft-202412: Azure/sonic-mgmt.msft#632 |
mssonicbld
added
Included in msft-202412 Branch
and removed
Created PR to msft-202412 Branch
labels
nissampa
pushed a commit
to nissampa/sonic-mgmt_dpu_test
that referenced
this pull request
Aug 7, 2025
Summary: Current 'autoneg' column in links.csv only support 'on'. If it's 'off' or other settings, it will default to platform.json behavior. This PR add the support for 'off' settings. For DUT which want to use the default behavior, it can leave that column empty, or use any other value, e.g. 'none' Note: There will be a behavior change if user is using off in links.csv already for their DUT. old behavior: the autoneg settings will be derived from platform.json, which chould be on or off or not defined. new behavior: will be off always. If users is using off already, they need to update their links.csv to leave autoneg field as empty if they want to use the default settings in platform.json. What is the motivation for this PR? update autoneg setting to support 'off' How did you do it? Check autoneg value for both on and off in minigraph
sdszhang
added
Approved for 202505 branch
and removed
Approved for 202505 branch
Created PR to 202505 branch
labels
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Aug 9, 2025
Summary: Current 'autoneg' column in links.csv only support 'on'. If it's 'off' or other settings, it will default to platform.json behavior. This PR add the support for 'off' settings. For DUT which want to use the default behavior, it can leave that column empty, or use any other value, e.g. 'none' Note: There will be a behavior change if user is using off in links.csv already for their DUT. old behavior: the autoneg settings will be derived from platform.json, which chould be on or off or not defined. new behavior: will be off always. If users is using off already, they need to update their links.csv to leave autoneg field as empty if they want to use the default settings in platform.json. What is the motivation for this PR? update autoneg setting to support 'off' How did you do it? Check autoneg value for both on and off in minigraph
Collaborator
|
Cherry-pick PR to 202505: #20166 |
11 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Aug 11, 2025
Summary: Current 'autoneg' column in links.csv only support 'on'. If it's 'off' or other settings, it will default to platform.json behavior. This PR add the support for 'off' settings. For DUT which want to use the default behavior, it can leave that column empty, or use any other value, e.g. 'none' Note: There will be a behavior change if user is using off in links.csv already for their DUT. old behavior: the autoneg settings will be derived from platform.json, which chould be on or off or not defined. new behavior: will be off always. If users is using off already, they need to update their links.csv to leave autoneg field as empty if they want to use the default settings in platform.json. What is the motivation for this PR? update autoneg setting to support 'off' How did you do it? Check autoneg value for both on and off in minigraph
mssonicbld
added
Included in 202505 branch
and removed
Created PR to 202505 branch
labels
ashutosh-agrawal
pushed a commit
to ashutosh-agrawal/sonic-mgmt
that referenced
this pull request
Aug 14, 2025
Summary: Current 'autoneg' column in links.csv only support 'on'. If it's 'off' or other settings, it will default to platform.json behavior. This PR add the support for 'off' settings. For DUT which want to use the default behavior, it can leave that column empty, or use any other value, e.g. 'none' Note: There will be a behavior change if user is using off in links.csv already for their DUT. old behavior: the autoneg settings will be derived from platform.json, which chould be on or off or not defined. new behavior: will be off always. If users is using off already, they need to update their links.csv to leave autoneg field as empty if they want to use the default settings in platform.json. What is the motivation for this PR? update autoneg setting to support 'off' How did you do it? Check autoneg value for both on and off in minigraph
kanchanavelusamy
pushed a commit
to kanchanavelusamy/sonic-mgmt
that referenced
this pull request
Oct 7, 2025
Summary: Current 'autoneg' column in links.csv only support 'on'. If it's 'off' or other settings, it will default to platform.json behavior. This PR add the support for 'off' settings. For DUT which want to use the default behavior, it can leave that column empty, or use any other value, e.g. 'none' Note: There will be a behavior change if user is using off in links.csv already for their DUT. old behavior: the autoneg settings will be derived from platform.json, which chould be on or off or not defined. new behavior: will be off always. If users is using off already, they need to update their links.csv to leave autoneg field as empty if they want to use the default settings in platform.json. What is the motivation for this PR? update autoneg setting to support 'off' How did you do it? Check autoneg value for both on and off in minigraph
vidyac86
pushed a commit
to vidyac86/sonic-mgmt
that referenced
this pull request
Oct 23, 2025
Summary: Current 'autoneg' column in links.csv only support 'on'. If it's 'off' or other settings, it will default to platform.json behavior. This PR add the support for 'off' settings. For DUT which want to use the default behavior, it can leave that column empty, or use any other value, e.g. 'none' Note: There will be a behavior change if user is using off in links.csv already for their DUT. old behavior: the autoneg settings will be derived from platform.json, which chould be on or off or not defined. new behavior: will be off always. If users is using off already, they need to update their links.csv to leave autoneg field as empty if they want to use the default settings in platform.json. What is the motivation for this PR? update autoneg setting to support 'off' How did you do it? Check autoneg value for both on and off in minigraph
opcoder0
pushed a commit
to opcoder0/sonic-mgmt
that referenced
this pull request
Dec 8, 2025
Summary: Current 'autoneg' column in links.csv only support 'on'. If it's 'off' or other settings, it will default to platform.json behavior. This PR add the support for 'off' settings. For DUT which want to use the default behavior, it can leave that column empty, or use any other value, e.g. 'none' Note: There will be a behavior change if user is using off in links.csv already for their DUT. old behavior: the autoneg settings will be derived from platform.json, which chould be on or off or not defined. new behavior: will be off always. If users is using off already, they need to update their links.csv to leave autoneg field as empty if they want to use the default settings in platform.json. What is the motivation for this PR? update autoneg setting to support 'off' How did you do it? Check autoneg value for both on and off in minigraph Signed-off-by: opcoder0 <[email protected]>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 16, 2025
Summary: Current 'autoneg' column in links.csv only support 'on'. If it's 'off' or other settings, it will default to platform.json behavior. This PR add the support for 'off' settings. For DUT which want to use the default behavior, it can leave that column empty, or use any other value, e.g. 'none' Note: There will be a behavior change if user is using off in links.csv already for their DUT. old behavior: the autoneg settings will be derived from platform.json, which chould be on or off or not defined. new behavior: will be off always. If users is using off already, they need to update their links.csv to leave autoneg field as empty if they want to use the default settings in platform.json. What is the motivation for this PR? update autoneg setting to support 'off' How did you do it? Check autoneg value for both on and off in minigraph Signed-off-by: Guy Shemesh <[email protected]>
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Dec 16, 2025
Summary: Current 'autoneg' column in links.csv only support 'on'. If it's 'off' or other settings, it will default to platform.json behavior. This PR add the support for 'off' settings. For DUT which want to use the default behavior, it can leave that column empty, or use any other value, e.g. 'none' Note: There will be a behavior change if user is using off in links.csv already for their DUT. old behavior: the autoneg settings will be derived from platform.json, which chould be on or off or not defined. new behavior: will be off always. If users is using off already, they need to update their links.csv to leave autoneg field as empty if they want to use the default settings in platform.json. What is the motivation for this PR? update autoneg setting to support 'off' How did you do it? Check autoneg value for both on and off in minigraph Signed-off-by: Aharon Malkin <[email protected]>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 21, 2025
Summary: Current 'autoneg' column in links.csv only support 'on'. If it's 'off' or other settings, it will default to platform.json behavior. This PR add the support for 'off' settings. For DUT which want to use the default behavior, it can leave that column empty, or use any other value, e.g. 'none' Note: There will be a behavior change if user is using off in links.csv already for their DUT. old behavior: the autoneg settings will be derived from platform.json, which chould be on or off or not defined. new behavior: will be off always. If users is using off already, they need to update their links.csv to leave autoneg field as empty if they want to use the default settings in platform.json. What is the motivation for this PR? update autoneg setting to support 'off' How did you do it? Check autoneg value for both on and off in minigraph Signed-off-by: Guy Shemesh <[email protected]>
venu-nexthop
pushed a commit
to venu-nexthop/sonic-mgmt
that referenced
this pull request
Jan 13, 2026
Summary: Current 'autoneg' column in links.csv only support 'on'. If it's 'off' or other settings, it will default to platform.json behavior. This PR add the support for 'off' settings. For DUT which want to use the default behavior, it can leave that column empty, or use any other value, e.g. 'none' Note: There will be a behavior change if user is using off in links.csv already for their DUT. old behavior: the autoneg settings will be derived from platform.json, which chould be on or off or not defined. new behavior: will be off always. If users is using off already, they need to update their links.csv to leave autoneg field as empty if they want to use the default settings in platform.json. What is the motivation for this PR? update autoneg setting to support 'off' How did you do it? Check autoneg value for both on and off in minigraph
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Jan 26, 2026
Summary: Current 'autoneg' column in links.csv only support 'on'. If it's 'off' or other settings, it will default to platform.json behavior. This PR add the support for 'off' settings. For DUT which want to use the default behavior, it can leave that column empty, or use any other value, e.g. 'none' Note: There will be a behavior change if user is using off in links.csv already for their DUT. old behavior: the autoneg settings will be derived from platform.json, which chould be on or off or not defined. new behavior: will be off always. If users is using off already, they need to update their links.csv to leave autoneg field as empty if they want to use the default settings in platform.json. What is the motivation for this PR? update autoneg setting to support 'off' How did you do it? Check autoneg value for both on and off in minigraph Signed-off-by: Guy Shemesh <[email protected]>
ytzur1
pushed a commit
to ytzur1/sonic-mgmt
that referenced
this pull request
Feb 2, 2026
Summary: Current 'autoneg' column in links.csv only support 'on'. If it's 'off' or other settings, it will default to platform.json behavior. This PR add the support for 'off' settings. For DUT which want to use the default behavior, it can leave that column empty, or use any other value, e.g. 'none' Note: There will be a behavior change if user is using off in links.csv already for their DUT. old behavior: the autoneg settings will be derived from platform.json, which chould be on or off or not defined. new behavior: will be off always. If users is using off already, they need to update their links.csv to leave autoneg field as empty if they want to use the default settings in platform.json. What is the motivation for this PR? update autoneg setting to support 'off' How did you do it? Check autoneg value for both on and off in minigraph Signed-off-by: Yael Tzur <[email protected]>
This was referenced Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Current 'autoneg' column in links.csv only support 'on'. If it's 'off' or other settings, it will default to platform.json behavior.
This PR add the support for 'off' settings.
For DUT which want to use the default behavior, it can leave that column empty, or use any other value, e.g. 'none'
Note: There will be a behavior change if user is using
offin links.csv already for their DUT.onoroffor not defined.other values
If users is using
offalready, they need to update their links.csv to leave autoneg field as empty if they want to use the default settings in platform.json.Type of change
Back port request
Approach
What is the motivation for this PR?
update autoneg setting to support 'off'
How did you do it?
Check autoneg value for both
onandoffin minigraphHow did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation