[action] [PR:20030] update autoneg setting to support 'off' when deploy-mg#20063
Closed
mssonicbld wants to merge 1 commit intosonic-net:202505from
Closed
[action] [PR:20030] update autoneg setting to support 'off' when deploy-mg#20063mssonicbld wants to merge 1 commit intosonic-net:202505from
mssonicbld wants to merge 1 commit intosonic-net:202505from
Conversation
Summary: Current 'autoneg' column in links.csv only support 'on'. If it's 'off' or other settings, it will default to platform.json behavior. This PR add the support for 'off' settings. For DUT which want to use the default behavior, it can leave that column empty, or use any other value, e.g. 'none' Note: There will be a behavior change if user is using off in links.csv already for their DUT. old behavior: the autoneg settings will be derived from platform.json, which chould be on or off or not defined. new behavior: will be off always. If users is using off already, they need to update their links.csv to leave autoneg field as empty if they want to use the default settings in platform.json. What is the motivation for this PR? update autoneg setting to support 'off' How did you do it? Check autoneg value for both on and off in minigraph
11 tasks
Collaborator
Author
|
Original PR: #20030 |
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
close due to pipeline error. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Current 'autoneg' column in links.csv only support 'on'. If it's 'off' or other settings, it will default to platform.json behavior.
This PR add the support for 'off' settings.
For DUT which want to use the default behavior, it can leave that column empty, or use any other value, e.g. 'none'
Note: There will be a behavior change if user is using
offin links.csv already for their DUT.old behavior: the autoneg settings will be derived from platform.json, which chould be
onoroffor not defined.new behavior: will be
offalways.If users is using
offalready, they need to update their links.csv to leave autoneg field as empty if they want to use the default settings in platform.json.Type of change
Back port request
Approach
What is the motivation for this PR?
update autoneg setting to support 'off'
How did you do it?
Check autoneg value for both
onandoffin minigraphHow did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation