Set autoneg off for t0-f2 server-facing ports in golden config#23363
Closed
sdszhang wants to merge 1 commit intosonic-net:masterfrom
Closed
Set autoneg off for t0-f2 server-facing ports in golden config#23363sdszhang wants to merge 1 commit intosonic-net:masterfrom
sdszhang wants to merge 1 commit intosonic-net:masterfrom
Conversation
Collaborator
|
/azp run |
Signed-off-by: Dashuai Zhang <[email protected]>
sdszhang
force-pushed
the
link_training_autoneg_off
branch
from
842fa8b to
23a809e
Compare
Collaborator
|
/azp run |
sdszhang
added
Request for msft-202503 Branch
Request for 202511 branch
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
sdszhang
removed
Request for msft-202503 Branch
Request for 202511 branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Update golden config generation for
t0-f2-d40u8topology to setautoneg=offon server-facing ports alongside the existinglink_training=onsetting.Type of change
Back port request
Approach
What is the motivation for this PR?
Link training was enabled for t0-f2 server-facing ports in #23107, but
autonegwas not explicitly set tooff. On some branches which doesn't have the fix for #20030, autoneg can defaults to 'on', causing interfaces to fail to establish links.How did you do it?
Added
config["autoneg"] = "off"for server-facing ports ingenerate_t0_f2_golden_config_db()inansible/library/generate_golden_config_db.py.How did you verify/test it?
Verified on physical testbed with t0-f2-d40u8 topology. Server-facing interfaces come up correctly with autoneg disabled.
Any platform specific information?
Applies to t0-f2-d40u8 topology only.
Supported testbed topology if it is a new test case?
N/A
Documentation
N/A