support dynamic saithrift URL generation#19528
Merged
StormLiangMS merged 4 commits intosonic-net:masterfrom Jul 25, 2025
Merged
support dynamic saithrift URL generation#19528StormLiangMS merged 4 commits intosonic-net:masterfrom
StormLiangMS merged 4 commits intosonic-net:masterfrom
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ZhaohuiS
reviewed
Jul 11, 2025
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
@ZhaohuiS @StormLiangMS can you help to review and approve? |
ZhaohuiS
reviewed
Jul 21, 2025
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
@StormLiangMS can you help to review this change? It can automatically correct saithrift package URL for image later than 202405. |
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Jul 25, 2025
What is the motivation for this PR? When the Debian codename changes, the saithrift package URL must be updated accordingly outside the test code. Otherwise, the package download may silently fail, leading to QoS SAI test failures. This change dynamically generates the correct saithrift package URL based on the current Debian codename and explicitly reports test failure if the download fails. How did you do it? This change dynamically generates the correct saithrift package URL based on the current Debian codename and explicitly reports test failure if the download fails. How did you verify/test it? passed local tests
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Jul 25, 2025
What is the motivation for this PR? When the Debian codename changes, the saithrift package URL must be updated accordingly outside the test code. Otherwise, the package download may silently fail, leading to QoS SAI test failures. This change dynamically generates the correct saithrift package URL based on the current Debian codename and explicitly reports test failure if the download fails. How did you do it? This change dynamically generates the correct saithrift package URL based on the current Debian codename and explicitly reports test failure if the download fails. How did you verify/test it? passed local tests
Collaborator
|
Cherry-pick PR to 202411: #19825 |
Collaborator
|
Cherry-pick PR to 202405: #19826 |
This was referenced Jul 25, 2025
mssonicbld
pushed a commit
that referenced
this pull request
Jul 25, 2025
What is the motivation for this PR? When the Debian codename changes, the saithrift package URL must be updated accordingly outside the test code. Otherwise, the package download may silently fail, leading to QoS SAI test failures. This change dynamically generates the correct saithrift package URL based on the current Debian codename and explicitly reports test failure if the download fails. How did you do it? This change dynamically generates the correct saithrift package URL based on the current Debian codename and explicitly reports test failure if the download fails. How did you verify/test it? passed local tests
mssonicbld
added
Included in 202411 branch
and removed
Created PR to 202411 branch
labels
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Jul 28, 2025
What is the motivation for this PR? When the Debian codename changes, the saithrift package URL must be updated accordingly outside the test code. Otherwise, the package download may silently fail, leading to QoS SAI test failures. This change dynamically generates the correct saithrift package URL based on the current Debian codename and explicitly reports test failure if the download fails. How did you do it? This change dynamically generates the correct saithrift package URL based on the current Debian codename and explicitly reports test failure if the download fails. How did you verify/test it? passed local tests
Collaborator
|
Cherry-pick PR to 202505: #19852 |
11 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Jul 28, 2025
What is the motivation for this PR? When the Debian codename changes, the saithrift package URL must be updated accordingly outside the test code. Otherwise, the package download may silently fail, leading to QoS SAI test failures. This change dynamically generates the correct saithrift package URL based on the current Debian codename and explicitly reports test failure if the download fails. How did you do it? This change dynamically generates the correct saithrift package URL based on the current Debian codename and explicitly reports test failure if the download fails. How did you verify/test it? passed local tests
mssonicbld
added
Included in 202505 branch
and removed
Created PR to 202505 branch
labels
Contributor
|
@XuChen-MSFT @StormLiangMS @ZhaohuiS this is causing failures on Mellanox smartswitch platform where all packages are on bookworm in 202411. @prsunny for viz. |
nissampa
pushed a commit
to nissampa/sonic-mgmt_dpu_test
that referenced
this pull request
Aug 7, 2025
What is the motivation for this PR? When the Debian codename changes, the saithrift package URL must be updated accordingly outside the test code. Otherwise, the package download may silently fail, leading to QoS SAI test failures. This change dynamically generates the correct saithrift package URL based on the current Debian codename and explicitly reports test failure if the download fails. How did you do it? This change dynamically generates the correct saithrift package URL based on the current Debian codename and explicitly reports test failure if the download fails. How did you verify/test it? passed local tests
ashutosh-agrawal
pushed a commit
to ashutosh-agrawal/sonic-mgmt
that referenced
this pull request
Aug 14, 2025
What is the motivation for this PR? When the Debian codename changes, the saithrift package URL must be updated accordingly outside the test code. Otherwise, the package download may silently fail, leading to QoS SAI test failures. This change dynamically generates the correct saithrift package URL based on the current Debian codename and explicitly reports test failure if the download fails. How did you do it? This change dynamically generates the correct saithrift package URL based on the current Debian codename and explicitly reports test failure if the download fails. How did you verify/test it? passed local tests
Contributor
Author
|
@prabhataravind Could you please share the complete test log? I've reviewed the code and don't believe the issue is related to whether the URL uses a DNS name or IP address. I need to analyze the full test log to identify the root cause. |
vidyac86
pushed a commit
to vidyac86/sonic-mgmt
that referenced
this pull request
Oct 23, 2025
What is the motivation for this PR? When the Debian codename changes, the saithrift package URL must be updated accordingly outside the test code. Otherwise, the package download may silently fail, leading to QoS SAI test failures. This change dynamically generates the correct saithrift package URL based on the current Debian codename and explicitly reports test failure if the download fails. How did you do it? This change dynamically generates the correct saithrift package URL based on the current Debian codename and explicitly reports test failure if the download fails. How did you verify/test it? passed local tests
wangxin
pushed a commit
to wangxin/sonic-mgmt
that referenced
this pull request
Oct 27, 2025
Code sync sonic-net/sonic-mgmt:202411 => 202412 ``` * c3fd4c0 (HEAD -> code-sync-202412, origin/code-sync-202412) r12f 250802:1704 - Merge remote-tracking branch 'base/202411' into code-sync-202412 |\ | * a7a638a (base/202411) nnelluri-cisco 250722:1131 - cherry pick for the PR#17101 (sonic-net#19748) | * fd4ae21 siva-prasad-cisco 250731:0002 - Ignore log analyzer error message related to source port GID mapping in kernel (sonic-net#19879) | * f986cfa Xu Chen 250730:2120 - Fix saithrift URL generation for Mellanox on internal-202411 branch sonic-net#19899 | * a07fb04 nnelluri-cisco 250604:1347 - filterd backplane ports while checking 'sudo sfputil show error-status' (sonic-net#17859) | * d707fcf nnelluri-cisco 250729:1208 - Added DPC role support for SmartSwitch. (sonic-net#18157) | * 80ea05a dypet 250414:1059 - Fix BFD status check and ipv6 PTF intermittent issue. (sonic-net#17819) | * fc623da Xu Chen 250725:1036 - support dynamic saithrift URL generation (sonic-net#19528) | * 0e5fc8a Mai Bui 250724:1807 - [202411] Ignore auditd error in loganalyzer (sonic-net#19767) | * d03770d Hua Liu 250218:1409 - [TACACS] Increase tacacs server reachability check timeout (sonic-net#16971) | * e8111ac nnelluri-cisco 250717:1033 - Generate new npu-dpu ports Ethernet224 To Ethernet280 for cisco smartswicth "Cisco-8102-28FH-DPU-O" (sonic-net#19257) | * e0060fa Zain Budhwani 250716:1109 - Remove yang_validate option from 202411 (sonic-net#19674) | * 89c4281 AharonMalkin 250715:2042 - Add Nvidia to supported platforms on intf_fec test (sonic-net#19398) | * f35fc20 mssonicbld 250716:0129 - Fix buffer queue cnt test to account for different BUFFER_QUEUE configs (sonic-net#19310) (sonic-net#19466) | * 3e0cabd Chuan Wu 250704:0327 - Update vlan ping test to override the affection of secondary vlan ip (sonic-net#18867) | * ff9d112 Longxiang Lyu 250714:1508 - [dualtor-io] Fix `test_active_link_admin_down_config_reload_link_up_downstream_standby` on Cisco/MLNX (sonic-net#18829) (sonic-net#19511) | * e870d66 Yawen 250714:1246 - [manual cherry-pick] add topo dualtor-aa-64-breakout to qos_sai_base.py (sonic-net#19543) | * 8369780 prabhataravind 250711:0929 - Enable skipped BFD and VxLAN tests on smartswitch T1 (sonic-net#19498) ```
opcoder0
pushed a commit
to opcoder0/sonic-mgmt
that referenced
this pull request
Dec 8, 2025
What is the motivation for this PR? When the Debian codename changes, the saithrift package URL must be updated accordingly outside the test code. Otherwise, the package download may silently fail, leading to QoS SAI test failures. This change dynamically generates the correct saithrift package URL based on the current Debian codename and explicitly reports test failure if the download fails. How did you do it? This change dynamically generates the correct saithrift package URL based on the current Debian codename and explicitly reports test failure if the download fails. How did you verify/test it? passed local tests Signed-off-by: opcoder0 <110003254+opcoder0@users.noreply.github.com>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 16, 2025
What is the motivation for this PR? When the Debian codename changes, the saithrift package URL must be updated accordingly outside the test code. Otherwise, the package download may silently fail, leading to QoS SAI test failures. This change dynamically generates the correct saithrift package URL based on the current Debian codename and explicitly reports test failure if the download fails. How did you do it? This change dynamically generates the correct saithrift package URL based on the current Debian codename and explicitly reports test failure if the download fails. How did you verify/test it? passed local tests Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Dec 16, 2025
What is the motivation for this PR? When the Debian codename changes, the saithrift package URL must be updated accordingly outside the test code. Otherwise, the package download may silently fail, leading to QoS SAI test failures. This change dynamically generates the correct saithrift package URL based on the current Debian codename and explicitly reports test failure if the download fails. How did you do it? This change dynamically generates the correct saithrift package URL based on the current Debian codename and explicitly reports test failure if the download fails. How did you verify/test it? passed local tests Signed-off-by: Aharon Malkin <amalkin@nvidia.com>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 21, 2025
What is the motivation for this PR? When the Debian codename changes, the saithrift package URL must be updated accordingly outside the test code. Otherwise, the package download may silently fail, leading to QoS SAI test failures. This change dynamically generates the correct saithrift package URL based on the current Debian codename and explicitly reports test failure if the download fails. How did you do it? This change dynamically generates the correct saithrift package URL based on the current Debian codename and explicitly reports test failure if the download fails. How did you verify/test it? passed local tests Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
venu-nexthop
pushed a commit
to venu-nexthop/sonic-mgmt
that referenced
this pull request
Jan 13, 2026
What is the motivation for this PR? When the Debian codename changes, the saithrift package URL must be updated accordingly outside the test code. Otherwise, the package download may silently fail, leading to QoS SAI test failures. This change dynamically generates the correct saithrift package URL based on the current Debian codename and explicitly reports test failure if the download fails. How did you do it? This change dynamically generates the correct saithrift package URL based on the current Debian codename and explicitly reports test failure if the download fails. How did you verify/test it? passed local tests
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Jan 26, 2026
What is the motivation for this PR? When the Debian codename changes, the saithrift package URL must be updated accordingly outside the test code. Otherwise, the package download may silently fail, leading to QoS SAI test failures. This change dynamically generates the correct saithrift package URL based on the current Debian codename and explicitly reports test failure if the download fails. How did you do it? This change dynamically generates the correct saithrift package URL based on the current Debian codename and explicitly reports test failure if the download fails. How did you verify/test it? passed local tests Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
ytzur1
pushed a commit
to ytzur1/sonic-mgmt
that referenced
this pull request
Feb 2, 2026
What is the motivation for this PR? When the Debian codename changes, the saithrift package URL must be updated accordingly outside the test code. Otherwise, the package download may silently fail, leading to QoS SAI test failures. This change dynamically generates the correct saithrift package URL based on the current Debian codename and explicitly reports test failure if the download fails. How did you do it? This change dynamically generates the correct saithrift package URL based on the current Debian codename and explicitly reports test failure if the download fails. How did you verify/test it? passed local tests Signed-off-by: Yael Tzur <ytzur@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
When the Debian codename changes, the saithrift package URL must be updated accordingly outside the test code. Otherwise, the package download may silently fail, leading to QoS SAI test failures.
This change dynamically generates the correct saithrift package URL based on the current Debian codename and explicitly reports test failure if the download fails.
How did you do it?
This change dynamically generates the correct saithrift package URL based on the current Debian codename and explicitly reports test failure if the download fails.
How did you verify/test it?
passed local tests
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation