[action] [PR:19528] support dynamic saithrift URL generation#19826
Open
mssonicbld wants to merge 1 commit intosonic-net:202405from
Open
[action] [PR:19528] support dynamic saithrift URL generation#19826mssonicbld wants to merge 1 commit intosonic-net:202405from
mssonicbld wants to merge 1 commit intosonic-net:202405from
Conversation
What is the motivation for this PR? When the Debian codename changes, the saithrift package URL must be updated accordingly outside the test code. Otherwise, the package download may silently fail, leading to QoS SAI test failures. This change dynamically generates the correct saithrift package URL based on the current Debian codename and explicitly reports test failure if the download fails. How did you do it? This change dynamically generates the correct saithrift package URL based on the current Debian codename and explicitly reports test failure if the download fails. How did you verify/test it? passed local tests
11 tasks
Collaborator
Author
|
Original PR: #19528 |
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
Author
|
/azp run Azure.sonic-mgmt |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
Author
|
/azp run Azure.sonic-mgmt |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
When the Debian codename changes, the saithrift package URL must be updated accordingly outside the test code. Otherwise, the package download may silently fail, leading to QoS SAI test failures.
This change dynamically generates the correct saithrift package URL based on the current Debian codename and explicitly reports test failure if the download fails.
How did you do it?
This change dynamically generates the correct saithrift package URL based on the current Debian codename and explicitly reports test failure if the download fails.
How did you verify/test it?
passed local tests
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation