Generate new npu-dpu ports Ethernet224 To Ethernet280 for cisco smartswicth "Cisco-8102-28FH-DPU-O" by nnelluri-cisco · Pull Request #19257 · sonic-net/sonic-mgmt

nnelluri-cisco · 2025-06-30T05:57:39Z

Description of PR

Summary:Generate new npu-dpu ports Ethernet224 To Ethernet280 for cisco smartswicth "Cisco-8102-28FH-DPU-O-T1"
Fixes # (issue)

Type of change

Bug fix
[X ] Testbed and Framework(new/improvement)
New Test case
- Skipped for non-supported platforms
Test case improvement

Back port request

202205
202305
202311
[ X] 202405
[X ] 202411
202505

Approach

used existing file generate_golden_config_db.py to generate the config

What is the motivation for this PR?

The fix is to generate npu-dpu ports for the cisco platform Cisco-8102-28FH-DPU-O-T1.
These ports stay in dark mode.

How did you do it?

Using generate_golden_config_db.py generated new config for npu-dpu ports.

How did you verify/test it?

Deployed the minigraph tool, cross-verified the config_db.json file, and ensured that ports Ethernet224 to Ethernet280 appear in the configuration.

Any platform specific information?

"Cisco-8102-28FH-DPU-O"

Supported testbed topology if it's a new test case?

t1-28-lag

Documentation

…swicth

mssonicbld · 2025-06-30T05:57:47Z

/azp run

azure-pipelines · 2025-06-30T05:57:58Z

Azure Pipelines successfully started running 1 pipeline(s).

nnelluri-cisco · 2025-06-30T05:59:05Z

@prabhataravind
closed old PR #17716 (since it is tool old too commit and it had pipeline issues)
and opened new PR for the same commit

mssonicbld · 2025-07-01T21:57:25Z

/azp run

azure-pipelines · 2025-07-01T21:57:36Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-07-01T22:04:17Z

/azp run

azure-pipelines · 2025-07-01T22:04:28Z

Azure Pipelines successfully started running 1 pipeline(s).

ansible/library/generate_golden_config_db.py

prabhataravind · 2025-07-01T23:51:30Z

@nnelluri-cisco please add the same PR in 202505 and master

mssonicbld · 2025-07-14T22:44:48Z

/azp run

azure-pipelines · 2025-07-14T22:45:00Z

Azure Pipelines successfully started running 1 pipeline(s).

prabhataravind · 2025-07-15T01:34:34Z

@wen587 pls review

prabhataravind · 2025-07-15T01:38:02Z

@congh-nvidia pls review common code under ansible.

congh-nvidia · 2025-07-15T03:30:53Z

Hi @prabhataravind @nnelluri-cisco, we are good with 202411 since we don't run light mode with it. But the code base has already differentiated in master. I will review when the PR for master/202505/202506 is created.

wen587 · 2025-07-15T05:08:04Z

ansible/library/generate_golden_config_db.py

        if self.topo_name == "mx" or "m0" in self.topo_name:
            config = self.generate_mgfx_golden_config_db()
-        elif self.topo_name == "t1-28-lag":
+        elif self.topo_name in ["t1-28-lag", "t1-48-lag", "t0-28"]:


Have we tested for t1-48-lag and t0-28? are these two specific for Smartswitch>

@wen587
Yes tested t1-48-lag and t0-28 topos for smartswitch.

@nnelluri-cisco is this tested on t1-28-lag just to make sure there are no regressions there?

wen587 · 2025-07-15T05:09:23Z

ansible/library/generate_golden_config_db.py

+            "FEATURE": copy.deepcopy(ori_config_db["FEATURE"]),
+            "INTERFACE": copy.deepcopy(ori_config_db["INTERFACE"]),
+            "PORT": copy.deepcopy(ori_config_db["PORT"]),
+            "CHASSIS_MODULE": copy.deepcopy(ori_config_db["CHASSIS_MODULE"]),


Can you share some content of the golden_config_db.json in PR description that it is correctly generated?

golden_config_db.json

@wen587
please find attached generated golden_config_db.json.

prabhataravind

lgtm, please wait for approval from jingwen.

nnelluri-cisco · 2025-07-15T17:07:20Z

Hi @prabhataravind @nnelluri-cisco, we are good with 202411 since we don't run light mode with it. But the code base has already differentiated in master. I will review when the PR for master/202505/202506 is created.

Thanks @congh-nvidia
yes I will create separate PR for master/202505/202506 since code base is different for these release.

wen587 · 2025-07-17T03:44:14Z

ansible/library/generate_golden_config_db.py

+
+            if port_key in ori_config_db["PORT"]:
+                ori_config_db["PORT"][port_key]["admin_status"] = "down"
+                ori_config_db["PORT"][port_key]["role"] = "Dpc"


Hi @prabhataravind , this should fix the xcvrd issue you mentioned.

Code sync sonic-net/sonic-mgmt:202411 => 202412 ``` * c3fd4c0 (HEAD -> code-sync-202412, origin/code-sync-202412) r12f 250802:1704 - Merge remote-tracking branch 'base/202411' into code-sync-202412 |\ | * a7a638a (base/202411) nnelluri-cisco 250722:1131 - cherry pick for the PR#17101 (sonic-net#19748) | * fd4ae21 siva-prasad-cisco 250731:0002 - Ignore log analyzer error message related to source port GID mapping in kernel (sonic-net#19879) | * f986cfa Xu Chen 250730:2120 - Fix saithrift URL generation for Mellanox on internal-202411 branch sonic-net#19899 | * a07fb04 nnelluri-cisco 250604:1347 - filterd backplane ports while checking 'sudo sfputil show error-status' (sonic-net#17859) | * d707fcf nnelluri-cisco 250729:1208 - Added DPC role support for SmartSwitch. (sonic-net#18157) | * 80ea05a dypet 250414:1059 - Fix BFD status check and ipv6 PTF intermittent issue. (sonic-net#17819) | * fc623da Xu Chen 250725:1036 - support dynamic saithrift URL generation (sonic-net#19528) | * 0e5fc8a Mai Bui 250724:1807 - [202411] Ignore auditd error in loganalyzer (sonic-net#19767) | * d03770d Hua Liu 250218:1409 - [TACACS] Increase tacacs server reachability check timeout (sonic-net#16971) | * e8111ac nnelluri-cisco 250717:1033 - Generate new npu-dpu ports Ethernet224 To Ethernet280 for cisco smartswicth "Cisco-8102-28FH-DPU-O" (sonic-net#19257) | * e0060fa Zain Budhwani 250716:1109 - Remove yang_validate option from 202411 (sonic-net#19674) | * 89c4281 AharonMalkin 250715:2042 - Add Nvidia to supported platforms on intf_fec test (sonic-net#19398) | * f35fc20 mssonicbld 250716:0129 - Fix buffer queue cnt test to account for different BUFFER_QUEUE configs (sonic-net#19310) (sonic-net#19466) | * 3e0cabd Chuan Wu 250704:0327 - Update vlan ping test to override the affection of secondary vlan ip (sonic-net#18867) | * ff9d112 Longxiang Lyu 250714:1508 - [dualtor-io] Fix `test_active_link_admin_down_config_reload_link_up_downstream_standby` on Cisco/MLNX (sonic-net#18829) (sonic-net#19511) | * e870d66 Yawen 250714:1246 - [manual cherry-pick] add topo dualtor-aa-64-breakout to qos_sai_base.py (sonic-net#19543) | * 8369780 prabhataravind 250711:0929 - Enable skipped BFD and VxLAN tests on smartswitch T1 (sonic-net#19498) ```

Generate new npu-dpu ports Ethernet224 To Ethernet280 for cisco smart…

23af8af

…swicth

nnelluri-cisco requested a review from prgeor as a code owner July 1, 2025 21:57

nnelluri-cisco force-pushed the test-npu-dpu-darkmode-fix branch from 4d1ef40 to 23af8af Compare July 1, 2025 22:04

prabhataravind reviewed Jul 1, 2025

View reviewed changes

ansible/library/generate_golden_config_db.py Outdated Show resolved Hide resolved

nnelluri-cisco mentioned this pull request Jul 10, 2025

added hwsku Cisco-8102-28FH-DPU-O into sonic-mgmt #17936

Merged

8 tasks

consoldated all the cisco hwsku's for generatting golden config

d33feef

nnelluri-cisco mentioned this pull request Jul 14, 2025

Added new code (Minigraph deployment) to support cisco hwsku Cisco-8102-28FH-DPU-O8C40 #19240

Closed

8 tasks

prabhataravind requested a review from wen587 July 15, 2025 01:34

wen587 reviewed Jul 15, 2025

View reviewed changes

prabhataravind approved these changes Jul 15, 2025

View reviewed changes

wen587 approved these changes Jul 16, 2025

View reviewed changes

wen587 reviewed Jul 17, 2025

View reviewed changes

kperumalbfn merged commit e8111ac into sonic-net:202411 Jul 17, 2025
14 checks passed

prabhataravind mentioned this pull request Jul 29, 2025

Added DPC role support for SmartSwitch. #18157

Merged

8 tasks

Conversation

nnelluri-cisco commented Jun 30, 2025

Description of PR

Type of change

Back port request

Uh oh!

mssonicbld commented Jun 30, 2025

Uh oh!

azure-pipelines bot commented Jun 30, 2025

Uh oh!

nnelluri-cisco commented Jun 30, 2025

Uh oh!

mssonicbld commented Jul 1, 2025

Uh oh!

azure-pipelines bot commented Jul 1, 2025

Uh oh!

mssonicbld commented Jul 1, 2025

Uh oh!

azure-pipelines bot commented Jul 1, 2025

Uh oh!

Uh oh!

prabhataravind commented Jul 1, 2025

Uh oh!

mssonicbld commented Jul 14, 2025

Uh oh!

azure-pipelines bot commented Jul 14, 2025

Uh oh!

prabhataravind commented Jul 15, 2025

Uh oh!

prabhataravind commented Jul 15, 2025

Uh oh!

congh-nvidia commented Jul 15, 2025

Uh oh!

wen587 Jul 15, 2025

Choose a reason for hiding this comment

Uh oh!

nnelluri-cisco Jul 15, 2025

Choose a reason for hiding this comment

Uh oh!

prabhataravind Jul 15, 2025

Choose a reason for hiding this comment

Uh oh!

wen587 Jul 15, 2025

Choose a reason for hiding this comment

Uh oh!

nnelluri-cisco Jul 15, 2025

Choose a reason for hiding this comment

Uh oh!

prabhataravind left a comment

Choose a reason for hiding this comment

Uh oh!

nnelluri-cisco commented Jul 15, 2025

Uh oh!

wen587 Jul 17, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants