[202012] Check if BGP has Loopback0 IP as its router ID (#8576)#9195
Merged
wangxin merged 2 commits intosonic-net:202012from Aug 1, 2023
Merged
[202012] Check if BGP has Loopback0 IP as its router ID (#8576)#9195wangxin merged 2 commits intosonic-net:202012from
wangxin merged 2 commits intosonic-net:202012from
Conversation
kellyyeh
changed the title
kellyyeh
changed the title
wangxin
approved these changes
Aug 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
This is a cherry-pick PR for #8576 and #9090
Summary: Skip check_bgp_router_id on T2 devices
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
An issue was found that T0 did not announce Loopback to T1, this check is to bridge the test gap to ensure bgp router identifier matches Loopback0 IP.
How did you do it?
Added in sanity_check to match bgp router id and loopback0 ip
How did you verify/test it?
Ran a advanced_reboot manually and checked expected log: BGP router identifier:
https://elastictest.org/scheduler/testplan/649c780c75768730ce0de9f3
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation