[docs] Add style/documentation guidelines for pytest#1926
Merged
daall merged 2 commits intosonic-net:masterfrom Jul 20, 2020
Merged
[docs] Add style/documentation guidelines for pytest#1926daall merged 2 commits intosonic-net:masterfrom
daall merged 2 commits intosonic-net:masterfrom
Conversation
Signed-off-by: Danny Allen <daall@microsoft.com>
yxieca
approved these changes
Jul 20, 2020
Contributor
|
retest this please |
jleveque
reviewed
Jul 20, 2020
jleveque
approved these changes
Jul 20, 2020
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
Submodule update for sonic-utilities with following change: ec9e5ee Backport [generate_dump] remove secrets from dump files sonic-net#1886 to 202012 (sonic-net#1938) ce3b856 [fdbshow]: Handle FDB cleanup gracefully. (sonic-net#1926) 1437bf2 [202012] Add DHCPv6 Relay counter and ipv6 helper CLI (sonic-net#1917)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Danny Allen daall@microsoft.com
Description of PR
Summary: Add some guidelines for style and documentation for pytest.
Type of change
Approach
What is the motivation for this PR?
We want to move towards a more consistent structure throughout the
mgmtrepo, so this is an initial set of guidelines to give people some idea of what the code should look like.Soon we will add a proper linter(s) which will enforce these checks on PR submissions, and this will be noted in the guide at this point.