fix: correct DUT variable name in startup tsa pretest#18699
Merged
yejianquan merged 1 commit intosonic-net:masterfrom May 30, 2025
Merged
fix: correct DUT variable name in startup tsa pretest#18699yejianquan merged 1 commit intosonic-net:masterfrom
yejianquan merged 1 commit intosonic-net:masterfrom
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
LGTM |
Javier-Tan
approved these changes
May 30, 2025
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
May 30, 2025
Description of PR Fix the dut variable name in test_disable_startup_tsa_tsb_service() in test_pretest.py added in sonic-net#17247 Summary: Fixes # (issue) Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Back port request 202205 202305 202311 202405 202411 202505 Approach What is the motivation for this PR? When using multithreading parallel run, we cannot refer to the duthost variable, we need to use dut instead.
Merged
11 tasks
Collaborator
|
Cherry-pick PR to 202505: #18711 |
11 tasks
Collaborator
|
Cherry-pick PR to msft-202405: Azure/sonic-mgmt.msft#344 |
mssonicbld
pushed a commit
that referenced
this pull request
May 30, 2025
Description of PR Fix the dut variable name in test_disable_startup_tsa_tsb_service() in test_pretest.py added in #17247 Summary: Fixes # (issue) Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Back port request 202205 202305 202311 202405 202411 202505 Approach What is the motivation for this PR? When using multithreading parallel run, we cannot refer to the duthost variable, we need to use dut instead.
mssonicbld
added
Included in 202505 branch
and removed
Created PR to 202505 branch
labels
bachalla
pushed a commit
to bachalla/sonic-mgmt
that referenced
this pull request
Jun 2, 2025
Description of PR Fix the dut variable name in test_disable_startup_tsa_tsb_service() in test_pretest.py added in sonic-net#17247 Summary: Fixes # (issue) Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Back port request 202205 202305 202311 202405 202411 202505 Approach What is the motivation for this PR? When using multithreading parallel run, we cannot refer to the duthost variable, we need to use dut instead.
Contributor
|
I see this PR is merged into |
Contributor
Author
Will fix asap |
Contributor
Author
Revert PR: Azure/sonic-mgmt.msft#359 |
yejianquan
added a commit
to Azure/sonic-mgmt.msft
that referenced
this pull request
Jun 4, 2025
… tsa pretest (#344)" (#359) This reverts commit 7551587. I thought we cherry picked the multithreading run of pretest PR (sonic-net/sonic-mgmt#17493) into msft.202405 but we never did, so the PR sonic-net/sonic-mgmt#18699 should never be cherry picked into msft.202405 as it's only a fix when test_pretest.py runs with multithreading. In msft.202405 branch, we are running test_pretest.py (e.g. test_disable_startup_tsa_tsb_service()) in a normal for loop: https://github.com/Azure/sonic-mgmt.msft/blob/202405/tests/test_pretest.py#L385, so we should use duthost instead of dut
Contributor
Author
|
@vkjammala-arista Revert PR merged, sorry for the confusion and inconvenience. Thanks @yejianquan for merging! |
Contributor
Thanks @cyw233 for the very quick resolution. |
opcoder0
pushed a commit
to opcoder0/sonic-mgmt
that referenced
this pull request
Dec 8, 2025
Description of PR Fix the dut variable name in test_disable_startup_tsa_tsb_service() in test_pretest.py added in sonic-net#17247 Summary: Fixes # (issue) Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Back port request 202205 202305 202311 202405 202411 202505 Approach What is the motivation for this PR? When using multithreading parallel run, we cannot refer to the duthost variable, we need to use dut instead. Signed-off-by: opcoder0 <110003254+opcoder0@users.noreply.github.com>
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Dec 16, 2025
Description of PR Fix the dut variable name in test_disable_startup_tsa_tsb_service() in test_pretest.py added in sonic-net#17247 Summary: Fixes # (issue) Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Back port request 202205 202305 202311 202405 202411 202505 Approach What is the motivation for this PR? When using multithreading parallel run, we cannot refer to the duthost variable, we need to use dut instead. Signed-off-by: Aharon Malkin <amalkin@nvidia.com>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 21, 2025
Description of PR Fix the dut variable name in test_disable_startup_tsa_tsb_service() in test_pretest.py added in sonic-net#17247 Summary: Fixes # (issue) Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Back port request 202205 202305 202311 202405 202411 202505 Approach What is the motivation for this PR? When using multithreading parallel run, we cannot refer to the duthost variable, we need to use dut instead. Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
venu-nexthop
pushed a commit
to venu-nexthop/sonic-mgmt
that referenced
this pull request
Jan 13, 2026
Description of PR Fix the dut variable name in test_disable_startup_tsa_tsb_service() in test_pretest.py added in sonic-net#17247 Summary: Fixes # (issue) Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Back port request 202205 202305 202311 202405 202411 202505 Approach What is the motivation for this PR? When using multithreading parallel run, we cannot refer to the duthost variable, we need to use dut instead.
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Jan 26, 2026
Description of PR Fix the dut variable name in test_disable_startup_tsa_tsb_service() in test_pretest.py added in sonic-net#17247 Summary: Fixes # (issue) Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Back port request 202205 202305 202311 202405 202411 202505 Approach What is the motivation for this PR? When using multithreading parallel run, we cannot refer to the duthost variable, we need to use dut instead. Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Fix the dut variable name in
test_disable_startup_tsa_tsb_service()intest_pretest.pyadded in #17247Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
When using multithreading parallel run, we cannot refer to the
duthostvariable, we need to usedutinstead.How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation