Ensure TSB is saved in config after deploy-mg and during pretest#17247
Merged
arlakshm merged 2 commits intosonic-net:masterfrom Mar 26, 2025
Merged
Ensure TSB is saved in config after deploy-mg and during pretest#17247arlakshm merged 2 commits intosonic-net:masterfrom
arlakshm merged 2 commits intosonic-net:masterfrom
Conversation
* Add config save after performing TSB in pretest Signed-off-by: Javier Tan [email protected]
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Javier-Tan
changed the title
Contributor
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
… deploy-mg * Execute TSB before config save during deploy-mg Signed-off-by: Javier Tan [email protected]
Javier-Tan
force-pushed
the
pretest_tsb_config_save
branch
from
af50809 to
34862d4
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Javier-Tan
changed the title
arlakshm
approved these changes
Mar 26, 2025
Collaborator
|
Cherry-pick PR to msft-202405: Azure/sonic-mgmt.msft#172 |
mssonicbld
added
Included in msft-202405 Branch
and removed
Created PR to msft-202405 Branch
labels
amulyan7
pushed a commit
to amulyan7/sonic-mgmt
that referenced
this pull request
Mar 31, 2025
…ic-net#17247) What is the motivation for this PR? Make sure tsa_enabled = false when startup_tsa_tsb is disabled through pretest How did you do it? Add config save after TSB is executed How did you verify/test it? Output tsa_enabled before and after pretest to make sure it is working is intended Signed-off-by: Javier Tan [email protected]
nnelluri-cisco
pushed a commit
to nnelluri-cisco/sonic-mgmt
that referenced
this pull request
Mar 31, 2025
…ic-net#17247) What is the motivation for this PR? Make sure tsa_enabled = false when startup_tsa_tsb is disabled through pretest How did you do it? Add config save after TSB is executed How did you verify/test it? Output tsa_enabled before and after pretest to make sure it is working is intended Signed-off-by: Javier Tan [email protected]
OriTrabelsi
pushed a commit
to OriTrabelsi/sonic-mgmt
that referenced
this pull request
Apr 1, 2025
…ic-net#17247) What is the motivation for this PR? Make sure tsa_enabled = false when startup_tsa_tsb is disabled through pretest How did you do it? Add config save after TSB is executed How did you verify/test it? Output tsa_enabled before and after pretest to make sure it is working is intended Signed-off-by: Javier Tan [email protected]
11 tasks
yejianquan
pushed a commit
that referenced
this pull request
May 30, 2025
Description of PR Fix the dut variable name in test_disable_startup_tsa_tsb_service() in test_pretest.py added in #17247 Summary: Fixes # (issue) Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Back port request 202205 202305 202311 202405 202411 202505 Approach What is the motivation for this PR? When using multithreading parallel run, we cannot refer to the duthost variable, we need to use dut instead.
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
May 30, 2025
Description of PR Fix the dut variable name in test_disable_startup_tsa_tsb_service() in test_pretest.py added in sonic-net#17247 Summary: Fixes # (issue) Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Back port request 202205 202305 202311 202405 202411 202505 Approach What is the motivation for this PR? When using multithreading parallel run, we cannot refer to the duthost variable, we need to use dut instead.
11 tasks
mssonicbld
pushed a commit
that referenced
this pull request
May 30, 2025
Description of PR Fix the dut variable name in test_disable_startup_tsa_tsb_service() in test_pretest.py added in #17247 Summary: Fixes # (issue) Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Back port request 202205 202305 202311 202405 202411 202505 Approach What is the motivation for this PR? When using multithreading parallel run, we cannot refer to the duthost variable, we need to use dut instead.
bachalla
pushed a commit
to bachalla/sonic-mgmt
that referenced
this pull request
Jun 2, 2025
Description of PR Fix the dut variable name in test_disable_startup_tsa_tsb_service() in test_pretest.py added in sonic-net#17247 Summary: Fixes # (issue) Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Back port request 202205 202305 202311 202405 202411 202505 Approach What is the motivation for this PR? When using multithreading parallel run, we cannot refer to the duthost variable, we need to use dut instead.
opcoder0
pushed a commit
to opcoder0/sonic-mgmt
that referenced
this pull request
Dec 8, 2025
…ic-net#17247) What is the motivation for this PR? Make sure tsa_enabled = false when startup_tsa_tsb is disabled through pretest How did you do it? Add config save after TSB is executed How did you verify/test it? Output tsa_enabled before and after pretest to make sure it is working is intended Signed-off-by: Javier Tan [email protected]
opcoder0
pushed a commit
to opcoder0/sonic-mgmt
that referenced
this pull request
Dec 8, 2025
Description of PR Fix the dut variable name in test_disable_startup_tsa_tsb_service() in test_pretest.py added in sonic-net#17247 Summary: Fixes # (issue) Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Back port request 202205 202305 202311 202405 202411 202505 Approach What is the motivation for this PR? When using multithreading parallel run, we cannot refer to the duthost variable, we need to use dut instead. Signed-off-by: opcoder0 <[email protected]>
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Dec 16, 2025
Description of PR Fix the dut variable name in test_disable_startup_tsa_tsb_service() in test_pretest.py added in sonic-net#17247 Summary: Fixes # (issue) Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Back port request 202205 202305 202311 202405 202411 202505 Approach What is the motivation for this PR? When using multithreading parallel run, we cannot refer to the duthost variable, we need to use dut instead. Signed-off-by: Aharon Malkin <[email protected]>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 21, 2025
…ic-net#17247) What is the motivation for this PR? Make sure tsa_enabled = false when startup_tsa_tsb is disabled through pretest How did you do it? Add config save after TSB is executed How did you verify/test it? Output tsa_enabled before and after pretest to make sure it is working is intended Signed-off-by: Javier Tan [email protected] Signed-off-by: Guy Shemesh <[email protected]>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 21, 2025
Description of PR Fix the dut variable name in test_disable_startup_tsa_tsb_service() in test_pretest.py added in sonic-net#17247 Summary: Fixes # (issue) Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Back port request 202205 202305 202311 202405 202411 202505 Approach What is the motivation for this PR? When using multithreading parallel run, we cannot refer to the duthost variable, we need to use dut instead. Signed-off-by: Guy Shemesh <[email protected]>
venu-nexthop
pushed a commit
to venu-nexthop/sonic-mgmt
that referenced
this pull request
Jan 13, 2026
Description of PR Fix the dut variable name in test_disable_startup_tsa_tsb_service() in test_pretest.py added in sonic-net#17247 Summary: Fixes # (issue) Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Back port request 202205 202305 202311 202405 202411 202505 Approach What is the motivation for this PR? When using multithreading parallel run, we cannot refer to the duthost variable, we need to use dut instead.
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Jan 26, 2026
…ic-net#17247) What is the motivation for this PR? Make sure tsa_enabled = false when startup_tsa_tsb is disabled through pretest How did you do it? Add config save after TSB is executed How did you verify/test it? Output tsa_enabled before and after pretest to make sure it is working is intended Signed-off-by: Javier Tan [email protected] Signed-off-by: Guy Shemesh <[email protected]>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Jan 26, 2026
Description of PR Fix the dut variable name in test_disable_startup_tsa_tsb_service() in test_pretest.py added in sonic-net#17247 Summary: Fixes # (issue) Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Back port request 202205 202305 202311 202405 202411 202505 Approach What is the motivation for this PR? When using multithreading parallel run, we cannot refer to the duthost variable, we need to use dut instead. Signed-off-by: Guy Shemesh <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes #17246
Type of change
Back port request
Approach
What is the motivation for this PR?
Make sure tsa_enabled = false when startup_tsa_tsb is disabled through pretest
How did you do it?
Add config save after TSB is executed
How did you verify/test it?
Output
tsa_enabledbefore and after pretest to make sure it is working is intendedAny platform specific information?
N/A
Supported testbed topology if it's a new test case?
N/A
Documentation