Skip to content

Commit 367f007

Browse files
authored
Revert "[action] [PR:18699] fix: correct DUT variable name in startup tsa pretest (#344)" (#359)
This reverts commit 7551587. I thought we cherry picked the multithreading run of pretest PR (sonic-net/sonic-mgmt#17493) into msft.202405 but we never did, so the PR sonic-net/sonic-mgmt#18699 should never be cherry picked into msft.202405 as it's only a fix when test_pretest.py runs with multithreading. In msft.202405 branch, we are running test_pretest.py (e.g. test_disable_startup_tsa_tsb_service()) in a normal for loop: https://github.com/Azure/sonic-mgmt.msft/blob/202405/tests/test_pretest.py#L385, so we should use duthost instead of dut
2 parents 7551587 + 542c1ec commit 367f007

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

tests/test_pretest.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -394,7 +394,7 @@ def test_disable_startup_tsa_tsb_service(duthosts, localhost):
394394
duthost.shell("sudo mv {} {}".format(startup_tsa_tsb_file_path, backup_tsa_tsb_file_path))
395395
output = duthost.shell("TSB", module_ignore_errors=True)
396396
pytest_assert(not output['rc'], "Failed TSB")
397-
dut.shell("sudo config save -y")
397+
duthost.shell("sudo config save -y")
398398
else:
399399
logger.info("{} file does not exist in the specified path on dut {}".
400400
format(startup_tsa_tsb_file_path, duthost.hostname))

0 commit comments

Comments
 (0)