[dualtor] Fix `test_orchagent_slb` by lolyu · Pull Request #18666 · sonic-net/sonic-mgmt

lolyu · 2025-05-28T04:19:30Z

Description of PR

Summary:
Fixes # (issue)

Type of change

Back port request

Approach

What is the motivation for this PR?

Fix test_orchagent_slb:

the exabgp log collection log has an issue that the logs might not exists before test, so it will error in this case.
when the slb sessions withdraw the route, the upper ToR slb session withdraws first, then the lower ToR; so there is a time period that, the route is withdrawed from the upper ToR but not the lower ToR, T1s still have this route learnt from the lower ToR so that the upper ToR have this route in its FIB that is learnt from T1s and has nexthops as T1s.
So, let's wait for more time to allow the lower ToR withdraw to happen.

How did you do it?

ignore exabgp log not exist error in log collection.
add wait_until logic for the withdraw check.

How did you verify/test it?

dualtor/test_orchagent_slb.py::test_orchagent_slb[ipv4-active-standby] PASSED                                                                                                                                                                                          [100%]

============================================================================================================================== warnings summary ==============================================================================================================================
../../../../../usr/local/lib/python3.8/dist-packages/paramiko/transport.py:236
  /usr/local/lib/python3.8/dist-packages/paramiko/transport.py:236: CryptographyDeprecationWarning: Blowfish has been deprecated
    "class": algorithms.Blowfish,

dualtor/test_orchagent_slb.py: 96 warnings
  /usr/local/lib/python3.8/dist-packages/ptf/mask.py:69: DeprecationWarning: "set_do_not_care_scapy" is going to be deprecated, please switch to the new one: "set_do_not_care_packet"
    warnings.warn(

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
========================================================================================================== 1 passed, 3 deselected, 97 warnings in 554.61s (0:09:14) ==========================================================================================================

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Signed-off-by: Longxiang Lyu <lolv@microsoft.com>

mssonicbld · 2025-05-28T04:19:37Z

/azp run

azure-pipelines · 2025-05-28T04:19:50Z

Azure Pipelines successfully started running 1 pipeline(s).

bingwang-ms · 2025-05-28T15:13:08Z

LGTM

Signed-off-by: Longxiang Lyu <lolv@microsoft.com>

mssonicbld · 2025-05-30T03:35:39Z

Cherry-pick PR to 202411: #18720

Signed-off-by: Longxiang Lyu <lolv@microsoft.com>

mssonicbld · 2025-05-30T07:07:49Z

Cherry-pick PR to 202505: #18723

Signed-off-by: Longxiang Lyu <lolv@microsoft.com>

Code sync sonic-net/sonic-mgmt:202411 => 202412 ``` * 1f86dab (HEAD -> code-sync-202412, origin/code-sync-202412) r12f 250610:2314 - Merge remote-tracking branch 'base/202411' into code-sync-202412 |\ | * 2ba104e (base/202411) xwjiang-ms 250610:1604 - [202411] Use ceos 4.32.5M as default ceos image version (sonic-net#18878) | * 5fa5cda Longxiang Lyu 250610:0818 - [202411][dualtor-aa] Add `dualtor_aa` support to `test_nvgre_hash` (sonic-net#18883) | * afecbbf zitingguo-ms 250609:1334 - [Cherry-pick][ACL] Collect all upstream ports and Include service port into upstream neighbors in ACL tests (sonic-net#18847) | * 2e4247b pragnya-arista 250609:0632 - [202411][sonic-mgmt]Fix decap/test_subnet_decap.py::test_vlan_subnet_decap (sonic-net#18778) | * 0bfc7a8 Longxiang Lyu 250606:0943 - [dualtor-io] Fix duplication merge condition (sonic-net#18828) | * 52d3771 Zhaohui Sun 250605:2046 - Restore configuration after vxlan module (sonic-net#18714) | * 3d0922f Yaqiang Zhu 250605:2259 - [202411][pktgen] Skip test_pktgen in m0/mx/m1 (sonic-net#18822) | * 3de20a6 Zhaohui Sun 250516:1325 - Add secondary subnet config for t0 topologies (sonic-net#18399) | * bb3e0f9 Zhaohui Sun 250605:1416 - Xfail test_dir_bcast.py due to known issue on Broadcom platform (sonic-net#18787) | * 158c562 Justin Wong 250604:2058 - Add snmp lldp state check after config_reload (sonic-net#18805) | * e39c891 eyakubch 250605:0415 - bug: added fast reboot into reboot_type check (sonic-net#18551) | * 8c7dd3b Cong Hou 250604:1433 - Remove the skip/xfail for the dualtor_io link failure test (sonic-net#18712) | * 5dbc53d mssonicbld 250604:0952 - [dualtor-io] fix dualtor sniffer start slow issue (sonic-net#18758) (sonic-net#18776) | * 105cdf6 StormLiangMS 250603:0844 - [CRM AVAILABLE] To enhance the crm tests for TD3 and Cisco devices (sonic-net#18733) | * 4251b38 andywongarista 250601:1828 - Add restore_image fixture to test_multi_hop_upgrade_path (sonic-net#18230) (sonic-net#18532) | * 85a55d8 Longxiang Lyu 250528:2313 - [dualtor] Fix `test_orchagent_slb` (sonic-net#18666) | * 95a8764 Vivek Verma 250227:0656 - Fix fixture invocation order in qos_sai_base.py to prevent teardown failure. (sonic-net#17180) | * 9a72265 Justin Wong 250514:1844 - Add PTF parameter for ceos neighbor lacp multiplier (sonic-net#18215) | * cd1375d Longxiang Lyu 250529:1029 - [dualtor-io] Validate and recover active-active setup (sonic-net#18675) | * 763c1b3 Longxiang Lyu 250528:2314 - [dualtor] Fix loganalyzer not exist issue (sonic-net#18674) ```

Signed-off-by: Longxiang Lyu <lolv@microsoft.com>

Signed-off-by: Longxiang Lyu <lolv@microsoft.com> Signed-off-by: Aharon Malkin <amalkin@nvidia.com>

Signed-off-by: Longxiang Lyu <lolv@microsoft.com> Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>

[dualtor] Fix test_orchagent_slb

499fb6e

Signed-off-by: Longxiang Lyu <lolv@microsoft.com>

lolyu requested review from bingwang-ms and yxieca May 28, 2025 10:39

bingwang-ms approved these changes May 28, 2025

View reviewed changes

bingwang-ms merged commit abd3049 into sonic-net:master May 28, 2025
12 checks passed

lolyu added Request for 202411 branch Request for 202505 branch Approved for 202411 branch labels May 30, 2025

mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request May 30, 2025

[dualtor] Fix test_orchagent_slb (sonic-net#18666)

9cb29ff

Signed-off-by: Longxiang Lyu <lolv@microsoft.com>

mssonicbld added the Created PR to 202411 branch label May 30, 2025

mssonicbld mentioned this pull request May 30, 2025

[action] [PR:18666] [dualtor] Fix test_orchagent_slb #18720

Merged

11 tasks

mssonicbld pushed a commit that referenced this pull request May 30, 2025

[dualtor] Fix test_orchagent_slb (#18666)

85a55d8

Signed-off-by: Longxiang Lyu <lolv@microsoft.com>

mssonicbld added Included in 202411 branch and removed Created PR to 202411 branch labels May 30, 2025

yejianquan added the Approved for 202505 branch label May 30, 2025

mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request May 30, 2025

[dualtor] Fix test_orchagent_slb (sonic-net#18666)

6d0dd00

Signed-off-by: Longxiang Lyu <lolv@microsoft.com>

mssonicbld added the Created PR to 202505 branch label May 30, 2025

mssonicbld mentioned this pull request May 30, 2025

[action] [PR:18666] [dualtor] Fix test_orchagent_slb #18723

Merged

11 tasks

mssonicbld pushed a commit that referenced this pull request May 30, 2025

[dualtor] Fix test_orchagent_slb (#18666)

43aca71

Signed-off-by: Longxiang Lyu <lolv@microsoft.com>

mssonicbld added Included in 202505 branch and removed Created PR to 202505 branch labels May 30, 2025

bachalla pushed a commit to bachalla/sonic-mgmt that referenced this pull request Jun 2, 2025

[dualtor] Fix test_orchagent_slb (sonic-net#18666)

5519cbd

Signed-off-by: Longxiang Lyu <lolv@microsoft.com>

opcoder0 pushed a commit to opcoder0/sonic-mgmt that referenced this pull request Dec 8, 2025

[dualtor] Fix test_orchagent_slb (sonic-net#18666)

e86a6cf

Signed-off-by: Longxiang Lyu <lolv@microsoft.com>

AharonMalkin pushed a commit to AharonMalkin/sonic-mgmt that referenced this pull request Dec 16, 2025

[dualtor] Fix test_orchagent_slb (sonic-net#18666)

7aaf08c

Signed-off-by: Longxiang Lyu <lolv@microsoft.com> Signed-off-by: Aharon Malkin <amalkin@nvidia.com>

gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Dec 21, 2025

[dualtor] Fix test_orchagent_slb (sonic-net#18666)

84e1712

Signed-off-by: Longxiang Lyu <lolv@microsoft.com> Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>

gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Jan 26, 2026

[dualtor] Fix test_orchagent_slb (sonic-net#18666)

ac16892

Signed-off-by: Longxiang Lyu <lolv@microsoft.com> Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[dualtor] Fix `test_orchagent_slb`#18666

[dualtor] Fix `test_orchagent_slb`#18666
bingwang-ms merged 1 commit intosonic-net:masterfrom
lolyu:fix_dualtor_slb2

lolyu commented May 28, 2025 •

edited

Loading

Uh oh!

mssonicbld commented May 28, 2025

Uh oh!

azure-pipelines bot commented May 28, 2025

Uh oh!

bingwang-ms commented May 28, 2025

Uh oh!

Uh oh!

mssonicbld commented May 30, 2025

Uh oh!

mssonicbld commented May 30, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

lolyu commented May 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of PR

Type of change

Back port request

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Uh oh!

mssonicbld commented May 28, 2025

Uh oh!

azure-pipelines bot commented May 28, 2025

Uh oh!

bingwang-ms commented May 28, 2025

Uh oh!

Uh oh!

mssonicbld commented May 30, 2025

Uh oh!

mssonicbld commented May 30, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

lolyu commented May 28, 2025 •

edited

Loading