[TACACS][IPv6]: Enable IPv6 in ptf-docker and add TACACS IPv6 test case by SuvarnaMeenakshi · Pull Request #1851 · sonic-net/sonic-mgmt

SuvarnaMeenakshi · 2020-07-06T16:19:43Z

Description of PR

Summary:
Fixes # (issue)

Type of change

Bug fix
Testbed and Framework(new/improvement)
Test case(new/improvement)

Approach

What is the motivation for this PR?

Enable IPv6 in ptf-docker, to test TACACS on IPv6.

How did you do it?

Add ptf_ipv6 parameter which will have ipv6 address in veos and vtestbed.csv
Add ansible_hostv6 parameter which will have IPv6 address for DUT; this is done in “lab” inventory file.
Changes in parser to accept above changes.
Change to add mgmt. v6 address to ptf-docker
Change in minigraph template to use the ansible_hostv6 address provided in the inventory file.
Modify tacacs test case to run with ipv6 address.

How did you verify/test it?

Bring up VS testbed
ptf-docker should come up with IPV6 mgmt IP address and sonic-vs image should come up with ipv6 address.
Run tacacs test.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

- Add new field ptf_ipv6 in testbed.csv file and update parser to read the new field. - Add new field ansible_hostv6 in veos.vtb and update parser to read this. - Add function to run TACACS test with IPv6 ptf address. Signed-off-by: SuvarnaMeenakshi <[email protected]>

and DUT. - Update function to add Ipv6 address to ptf-docker - Update lab file to add ansible_hostv6 - Update minigraph template to add IPv6 management address. Signed-off-by: SuvarnaMeenakshi <[email protected]>

lgtm-com · 2020-07-06T16:30:31Z

This pull request introduces 1 alert when merging 328186c into de77268 - view on LGTM.com

new alerts:

1 for Unused import

Signed-off-by: SuvarnaMeenakshi <[email protected]>

ansible/testbed_add_vm_topology.yml

ansible/vtestbed.csv

tests/vtestbed.csv

Signed-off-by: SuvarnaMeenakshi <[email protected]>

yxieca · 2020-07-14T00:51:27Z

retest vsimage please

lguohan · 2020-07-14T08:46:42Z

I am curious why this test does not run in the kvmtest? https://sonic-jenkins.westus2.cloudapp.azure.com/job/common/job/sonic-mgmt-testing/job/sonic-mgmt-pr/392/testReport/tacacs/test_ro_user/test_ro_user/

no ipv6 version run.

@daall , do you know why?

lguohan · 2020-07-14T08:55:00Z

ansible/lab

-vlab-01           ansible_host=10.250.0.101
-vlab-03           ansible_host=10.250.0.105
-vlab-04           ansible_host=10.250.0.107
+lab-s6000-01      ansible_host=10.251.0.189    ansible_hostv6=fec0:0:0:0:0:ffff:afa:9


this can be simplified as fec0::ffff:afa:9

fixed as per comment.

lguohan · 2020-07-14T08:56:45Z

tests/veos.vtb

-vlab-02 ansible_host=10.250.0.102 type=kvm hwsku=Force10-S6100 ansible_password=password
-vlab-03 ansible_host=10.250.0.105 type=kvm hwsku=Force10-S6000 ansible_password=password ansible_user=admin
-vlab-04 ansible_host=10.250.0.107 type=kvm hwsku=Force10-S6000 ansible_password=password ansible_user=admin
+vlab-01 ansible_host=10.250.0.101 ansible_hostv6=fec0:0:0:0:0:ffff:afa:1 type=kvm hwsku=Force10-S6000 ansible_password=password ansible_user=admin


simplify the v6 ip address: fec0::ffff:afa:1

fixed as per comment.

lguohan · 2020-07-14T08:57:05Z

ansible/testbed_refresh_dut.yml

 # -e dut_name=str-msn2700-01 - the name of target dut
 # -e VM_base=VM0300          - the VM name which is used to as base to calculate VM name for this set
 # -e ptf_ip=10.255.0.255/23 - the ip address and prefix of ptf container mgmt interface
+# -e ptf_ipv6=fec0:0:0:0:0:ffff:afa:1/64 - the ipv6 address and prefix of ptf container mgmt interface


simplify the ipv6 address

fixed as per comment.

SuvarnaMeenakshi · 2020-07-14T15:42:47Z

I am curious why this test does not run in the kvmtest? https://sonic-jenkins.westus2.cloudapp.azure.com/job/common/job/sonic-mgmt-testing/job/sonic-mgmt-pr/392/testReport/tacacs/test_ro_user/test_ro_user/

no ipv6 version run.

@daall , do you know why?

test_ro_user does not have new function added to test with ipv6, Will update the test file.

yxieca · 2020-07-14T18:03:35Z

retest vsimage please

Signed-off-by: SuvarnaMeenakshi <[email protected]>

lgtm-com · 2020-07-17T21:25:10Z

This pull request introduces 1 alert when merging b4b8d55 into d17246a - view on LGTM.com

new alerts:

1 for Variable defined multiple times

Signed-off-by: SuvarnaMeenakshi <[email protected]>

tests/common/plugins/tacacs.py

Signed-off-by: SuvarnaMeenakshi <[email protected]>

lguohan · 2020-07-18T10:20:54Z

retest this please

SuvarnaMeenakshi · 2020-07-19T06:06:58Z

retest this please

NazarTkachuk · 2020-07-20T12:11:55Z

@SuvarnaMeenakshi TestbedProcessing.py is broken.
see traceback bellow

PROCESS STARTED
BACKUP PROCESS STARTED
Error: could not back up group_vars/eos/creds.yml
BACKUP PROCESS COMPLETED
LOADING PROCESS STARTED
LOADING: bfn-testbed.yaml
TestbedProcessing.py:532: YAMLLoadWarning: calling yaml.load() without Loader=... is deprecated, as the default Loader is unsafe. Please read https://msg.pyyaml.org/load for full details.
  doc = yaml.load(open(args.i, 'r'))
LOADING PROCESS COMPLETED
GENERATING FILES FROM CONFIG FILE
        CREATING SONIC LAB LINKS: files/sonic_lab_links.csv
        CREATING SONIC LAB DEVICES: files/sonic_lab_devices.csv
        CREATING TEST BED: testbed.csv
Traceback (most recent call last):
  File "TestbedProcessing.py", line 583, in <module>
    main()
  File "TestbedProcessing.py", line 559, in main
    makeTestbed(testbed, args.basedir + testbed_file)  # Generate testbed.csv (TESTBED)
  File "TestbedProcessing.py", line 230, in makeTestbed
    if not ptf_ipv6:
UnboundLocalError: local variable 'ptf_ipv6' referenced before assignment

… advance submodule head (sonic-net#11518) sairedis: * 38c0bb1 2022-07-21 | [sairedis] Fix reopen recoding file (sonic-net#1087) (HEAD -> 202205, github/202205) [Kamil Cudnik] platform-daemon: * 17587b6 2022-07-22 | [ycabled] add secure channel support for grpc dualtor active-active connectivity (sonic-net#275) (HEAD -> 202205, github/202205) [vdahiya12] linkmgrd: * c911ec7 2022-07-21 | Avoid unnecessary error logs from `handleGetServerMacAddressNotification` (sonic-net#96) (HEAD -> 202205) [Jing Zhang] * bbae81d 2022-07-18 | Add support for reconciliation after warm restart (sonic-net#76) [Jing Zhang] utilities: * bcc1206 2022-07-20 | Change db_migrator major version on master branch from version 2 to 3 (sonic-net#2272) (HEAD -> 202205) [Vaibhav Hemant Dixit] * ad40697 2022-07-21 | Fix test for pfcwd_sw_enable in db_migrator_test (sonic-net#2253) [bingwang-ms] * 886f612 2022-07-22 | Revert "show commands for SYSTEM READY (sonic-net#1851) (sonic-net#2261)" (sonic-net#2274) (github/202205) [Ying Xie] * a6404b7 2022-07-17 | show commands for SYSTEM READY (sonic-net#1851) (sonic-net#2261) [Senthil Kumar Guruswamy] swss-common: * 509b265 2022-07-06 | Add device global table definition (sonic-net#645) (HEAD -> 202205) [tjchadaga] Signed-off-by: Ying Xie <[email protected]>

SuvarnaMeenakshi added 2 commits July 1, 2020 11:40

[IPv6][Tacacs]: Updates required to add ipv6 address in ptf-docker

328186c

and DUT. - Update function to add Ipv6 address to ptf-docker - Update lab file to add ansible_hostv6 - Update minigraph template to add IPv6 management address. Signed-off-by: SuvarnaMeenakshi <[email protected]>

SuvarnaMeenakshi requested review from renukamanavalan and yxieca July 6, 2020 16:20

SuvarnaMeenakshi added 2 commits July 6, 2020 09:34

Removed debug code.

d736efb

Signed-off-by: SuvarnaMeenakshi <[email protected]>

[ipv6]: Add ipv6 argument in renumber and refresh dut tasks.

cbf38c7

Signed-off-by: SuvarnaMeenakshi <[email protected]>

neethajohn reviewed Jul 7, 2020

View reviewed changes

ansible/testbed_add_vm_topology.yml Outdated Show resolved Hide resolved

ansible/vtestbed.csv Outdated Show resolved Hide resolved

ansible/vtestbed.csv Outdated Show resolved Hide resolved

tests/vtestbed.csv Outdated Show resolved Hide resolved

Fix review comments.

cb8506e

Signed-off-by: SuvarnaMeenakshi <[email protected]>

neethajohn approved these changes Jul 11, 2020

View reviewed changes

Merge remote-tracking branch 'azure/master' into tacacs_ipv6

5e8c081

Signed-off-by: SuvarnaMeenakshi <[email protected]>

lguohan reviewed Jul 14, 2020

View reviewed changes

SuvarnaMeenakshi added 3 commits July 16, 2020 17:40

Simplify IPv6 address.

df8ba1a

Signed-off-by: SuvarnaMeenakshi <[email protected]>

[IPv6]: Add test case for IPv6 TACACS.

f0e46d5

Signed-off-by: SuvarnaMeenakshi <[email protected]>

Remove test username.

b4b8d55

Signed-off-by: SuvarnaMeenakshi <[email protected]>

Fix function name.

1fe6dcc

Signed-off-by: SuvarnaMeenakshi <[email protected]>

lguohan reviewed Jul 18, 2020

View reviewed changes

tests/common/plugins/tacacs.py Outdated Show resolved Hide resolved

SuvarnaMeenakshi added 2 commits July 18, 2020 01:45

Modify function names as per review comments.

9dd4964

Signed-off-by: SuvarnaMeenakshi <[email protected]>

Modify function name as per review comment.

b257201

Signed-off-by: SuvarnaMeenakshi <[email protected]>

lguohan approved these changes Jul 18, 2020

View reviewed changes

lguohan merged commit 564ae51 into sonic-net:master Jul 20, 2020

SuvarnaMeenakshi mentioned this pull request Jul 21, 2020

[IPv6]: Add ptf ipv6 address in testbed file #1937

Merged

3 tasks

NazarTkachuk mentioned this pull request Jul 28, 2020

Generate minigraph with default ansible_hostv6 #1983

Merged

3 tasks

Conversation

SuvarnaMeenakshi commented Jul 6, 2020

Description of PR

Type of change

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Uh oh!

lgtm-com bot commented Jul 6, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yxieca commented Jul 14, 2020

Uh oh!

lguohan commented Jul 14, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lguohan Jul 14, 2020

Choose a reason for hiding this comment

Uh oh!

SuvarnaMeenakshi Jul 17, 2020

Choose a reason for hiding this comment

Uh oh!

lguohan Jul 14, 2020

Choose a reason for hiding this comment

Uh oh!

SuvarnaMeenakshi Jul 17, 2020

Choose a reason for hiding this comment

Uh oh!

lguohan Jul 14, 2020

Choose a reason for hiding this comment

Uh oh!

SuvarnaMeenakshi Jul 17, 2020

Choose a reason for hiding this comment

Uh oh!

SuvarnaMeenakshi commented Jul 14, 2020

Uh oh!

yxieca commented Jul 14, 2020

Uh oh!

lgtm-com bot commented Jul 17, 2020

Uh oh!

Uh oh!

lguohan commented Jul 18, 2020

Uh oh!

SuvarnaMeenakshi commented Jul 19, 2020

Uh oh!

NazarTkachuk commented Jul 20, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

lguohan commented Jul 14, 2020 •

edited

Loading

NazarTkachuk commented Jul 20, 2020 •

edited

Loading