Skip to content

create new test to verify incremental config changes via CLI#1087

Open
joej164 wants to merge 7 commits intosonic-net:masterfrom
IGNW:lafe-73-merge-incremental-config-into-azure-master
Open

create new test to verify incremental config changes via CLI#1087
joej164 wants to merge 7 commits intosonic-net:masterfrom
IGNW:lafe-73-merge-incremental-config-into-azure-master

Conversation

@joej164
Copy link
Contributor

@joej164 joej164 commented Aug 28, 2019

incremental_config_t1_eight_output.log
incremental_config_t0_eight_output.log

Description of PR

Adding a test to verify the incremental config cli components

Summary:
Adds new test that will walk the incremental config sections of the cli

NOTE: The command config portchannel member add doesn't add both members so this test fails.

Type of change

  • [] Bug fix
  • [] Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Approach

How did you do it?

Wrote commands to update the DUT, then did show commands to verify the command actually worked.

How did you verify/test it?

using show commands

Any platform specific information?

The DUT needs at least 2 active Ethernet interfaces

Supported testbed topology if it's a new test case?

most t0 and t1 testbeds should work. This was tested on a t0-8 and t1-8 topology.

Documentation

I updated the README.text.md file

Test Results

Command: ansible-playbook -i lab test_sonic.yml -e testbed_name=t0-eight -e testcase_name=incremental_config

Results:
PLAY RECAP *********************************************************************
lab-ignw-seastone-dut-li1 : ok=114 changed=38 unreachable=0 failed=0

Monday 26 August 2019 22:37:26 +0000 (0:00:00.067) 0:01:59.614 *********

TASK: test : create inactive interface list ---------------------------- 15.20s
TASK: test : pull current portchannel status ---------------------------- 5.45s
TASK: test : pull current portchannel status ---------------------------- 4.65s
TASK: test : verify the ports have been removed ------------------------- 4.60s
TASK: test : pull out lines from output for the portchannel ports ------- 4.02s
TASK: test : verify the portchannel has been removed -------------------- 3.89s
TASK: test : add initial role to the device ----------------------------- 3.52s
TASK: test : copy test files -------------------------------------------- 3.21s
TASK: test : add members to the portchannel ----------------------------- 2.79s
TASK: test : remove the members from the port channel ------------------- 2.76s
TASK: test : Get interface facts ---------------------------------------- 2.11s
TASK: test : Verify port channel interfaces are up correctly ------------ 2.04s
TASK: test : gather system version information -------------------------- 1.80s
TASK: test : get the current state of the roles ------------------------- 1.78s
TASK: test : get the current state of the roles ------------------------- 1.71s
TASK: test : update the role to allow everything ------------------------ 1.65s
TASK: test : get the current state of the roles ------------------------- 1.64s
TASK: test : validate all interfaces are up after test ------------------ 1.59s
TASK: test : Ansible | List all known variables and facts --------------- 1.55s
TASK: test : delete the acl --------------------------------------------- 1.43s

Command: ansible-playbook -i lab test_sonic.yml -e testbed_name=t1-eight -e testcase_name=incremental_config

Results:
PLAY RECAP *********************************************************************
lab-ignw-seastone-dut-li1 : ok=110 changed=40 unreachable=0 failed=0

Monday 26 August 2019 23:33:41 +0000 (0:00:00.078) 0:01:44.199 *********

TASK: test : create inactive interface list ---------------------------- 15.17s
TASK: test : add initial role to the device ----------------------------- 3.52s
TASK: test : copy test files -------------------------------------------- 3.22s
TASK: test : add members to the portchannel ----------------------------- 2.76s
TASK: test : remove the members from the port channel ------------------- 2.74s
TASK: test : pull current portchannel status ---------------------------- 2.41s
TASK: test : verify the ports have been removed ------------------------- 2.37s
TASK: test : pull current portchannel status ---------------------------- 2.37s
TASK: test : pull out lines from output for the portchannel ports ------- 1.97s
TASK: test : gather system version information -------------------------- 1.83s
TASK: test : verify the portchannel has been removed -------------------- 1.81s
TASK: test : get the current state of the roles ------------------------- 1.74s
TASK: test : get the current state of the roles ------------------------- 1.70s
TASK: test : get the current state of the roles ------------------------- 1.69s
TASK: test : Ansible | List all known variables and facts --------------- 1.62s
TASK: test : validate all interfaces are up after test ------------------ 1.61s
TASK: test : update the role to allow everything ------------------------ 1.59s
TASK: test : delete the acl --------------------------------------------- 1.46s
TASK: test : confirm IP was removed from the interface ------------------ 1.38s
TASK: test : confirm IP was added to the interface ---------------------- 1.35s

Joe Lazaro and others added 4 commits July 25, 2019 15:52
@joej164
Copy link
Contributor Author

joej164 commented Sep 5, 2019

closing to modify based on request to verify traffic works is transmitted on the interface

@joej164 joej164 closed this Sep 5, 2019
@joej164
Copy link
Contributor Author

joej164 commented Sep 6, 2019

improved test by requiring to use active interfaces

@joej164 joej164 reopened this Sep 6, 2019
Copy link
Member

@praveen-li praveen-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I notice PTF usage on apr-clear already, I think we need PTF traffic test here as well. Thx,

@joej164 joej164 requested a review from a team as a code owner March 2, 2022 17:37
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
This brings in the following changes:

```
21f3d7c Add SAI_OBJECT_TYPE_TUNNEL object to break-before-make list (sonic-net#1075)
8ac3aa7 [sairedis] Fix reopen recoding file (sonic-net#1087)
0bbbb02 Transfer organization from Azure to sonic-net (sonic-net#1096)
3406c57 [sairedis] Perform log rotate on request (sonic-net#1083)
```
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
… advance submodule head (sonic-net#11518)

sairedis:
* 38c0bb1 2022-07-21 | [sairedis] Fix reopen recoding file (sonic-net#1087) (HEAD -> 202205, github/202205) [Kamil Cudnik]

platform-daemon:
* 17587b6 2022-07-22 | [ycabled] add secure channel support for grpc dualtor active-active connectivity  (sonic-net#275) (HEAD -> 202205, github/202205) [vdahiya12]

linkmgrd:
* c911ec7 2022-07-21 | Avoid unnecessary error logs from `handleGetServerMacAddressNotification` (sonic-net#96) (HEAD -> 202205) [Jing Zhang]
* bbae81d 2022-07-18 | Add support for reconciliation after warm restart  (sonic-net#76) [Jing Zhang]

utilities:
* bcc1206 2022-07-20 | Change db_migrator major version on master branch from version 2 to 3 (sonic-net#2272) (HEAD -> 202205) [Vaibhav Hemant Dixit]
* ad40697 2022-07-21 | Fix test for pfcwd_sw_enable in db_migrator_test (sonic-net#2253) [bingwang-ms]
* 886f612 2022-07-22 | Revert "show commands for SYSTEM READY (sonic-net#1851) (sonic-net#2261)" (sonic-net#2274) (github/202205) [Ying Xie]
* a6404b7 2022-07-17 | show commands for SYSTEM READY (sonic-net#1851) (sonic-net#2261) [Senthil Kumar Guruswamy]

swss-common:
* 509b265 2022-07-06 | Add device global table definition (sonic-net#645) (HEAD -> 202205) [tjchadaga]

Signed-off-by: Ying Xie <[email protected]>
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
Revert "Revert " [201911]show interface counters for multi ASIC devices
(sonic-net#1104)""
 Revert "Revert "Pfcstat (sonic-net#1097)""
  [show] Fix 'show int neighbor expected' (sonic-net#1106)
   Update argument for docker exec it->i (sonic-net#1118)
     Update to make config load/reload backward compatible. (sonic-net#1115)
     Handling deletion of Port Channel before deletion of its members
     (sonic-net#1062)
    Skip default route present in ASIC-DB but not in APP-DB. (sonic-net#1107)
     [CLI][PFCWD][Multi-ASIC] Added multi ASIC support to 'pfcwd' CLI
     (sonic-net#1102)
       [201911]  Multi asic platform config interface portchannel, show
       transceiver  (sonic-net#1087)
       [drop counters] Fix configuration for counters with lowercase
       names (sonic-net#1103)

Signed-off-by: Abhishek Dosi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants