feat: add override feature for variables.py#18067
Merged
yejianquan merged 1 commit intosonic-net:masterfrom May 9, 2025
Merged
feat: add override feature for variables.py#18067yejianquan merged 1 commit intosonic-net:masterfrom
yejianquan merged 1 commit intosonic-net:masterfrom
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
auspham
force-pushed
the
austinpham/32317078-enhance-overwrite-variables
branch
from
abee13e to
726c830
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
auspham
force-pushed
the
austinpham/32317078-enhance-overwrite-variables
branch
from
726c830 to
ae6ad43
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
auspham
force-pushed
the
austinpham/32317078-enhance-overwrite-variables
branch
from
ae6ad43 to
97a1eef
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
auspham
force-pushed
the
austinpham/32317078-enhance-overwrite-variables
branch
from
97a1eef to
69087b4
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
auspham
force-pushed
the
austinpham/32317078-enhance-overwrite-variables
branch
from
69087b4 to
22d16ca
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
auspham
force-pushed
the
austinpham/32317078-enhance-overwrite-variables
branch
from
22d16ca to
5ebc1e8
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
auspham
force-pushed
the
austinpham/32317078-enhance-overwrite-variables
branch
from
5ebc1e8 to
db65efd
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
auspham
force-pushed
the
austinpham/32317078-enhance-overwrite-variables
branch
from
db65efd to
6068f8a
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
auspham
force-pushed
the
austinpham/32317078-enhance-overwrite-variables
branch
from
6068f8a to
7c3970e
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
auspham
force-pushed
the
austinpham/32317078-enhance-overwrite-variables
branch
from
7c3970e to
2e0c162
Compare
Contributor
|
@amitpawar12 @kamalsahu0001 for review. |
sdszhang
reviewed
Apr 30, 2025
sdszhang
reviewed
Apr 30, 2025
| @@ -0,0 +1,34 @@ | |||
| vms-snappi-sonic-multidut: | |||
auspham
force-pushed
the
austinpham/32317078-enhance-overwrite-variables
branch
from
34feb1a to
520032d
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
11 tasks
Signed-off-by: Austin Pham <[email protected]>
auspham
force-pushed
the
austinpham/32317078-enhance-overwrite-variables
branch
from
520032d to
be6c08b
Compare
Collaborator
|
/azp run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
Contributor
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
sdszhang
approved these changes
May 9, 2025
11 tasks
opcoder0
pushed a commit
to opcoder0/sonic-mgmt
that referenced
this pull request
Dec 8, 2025
Description of PR Summary: This PR adds the following features: Enable options to overwrite dynamic port selection introduced by [Snappi] - Infra change for dynamic port selection from the setup replacing variables.py file. sonic-net#15069. We can force running dynamic-port selection feature by adding --enable-snappi-dynamic-ports in the CLI. We can override by using variables.override.yml. The config is similar to our variable.py but in yaml. Add option to overwrite pfcQueueGroupSize as well and the default fallback value. So we can adjust per testbed. Fix some minimal issue from [Snappi] - Infra change for dynamic port selection from the setup replacing variables.py file. sonic-net#15069 Create folder and subfolder if it does not exist correctly for metadata.json Revert the tx_rx port in the dynamic snappi port selection Refactor the use of snappi_dut_base_config needed for consistency when toggle on and off dynamic ports selection make sure everything still work Fixes # (issue) 32317078 Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Back port request 202012 202205 202305 202311 202405 202411 Approach What is the motivation for this PR? How did you do it? How did you verify/test it? Any platform specific information? Supported testbed topology if it's a new test case? Documentation without --enable-snappi-dynamic-ports image with --enable-snappi-dynamic-ports image Signed-off-by: Austin Pham <[email protected]>
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Dec 16, 2025
Description of PR Summary: This PR adds the following features: Enable options to overwrite dynamic port selection introduced by [Snappi] - Infra change for dynamic port selection from the setup replacing variables.py file. sonic-net#15069. We can force running dynamic-port selection feature by adding --enable-snappi-dynamic-ports in the CLI. We can override by using variables.override.yml. The config is similar to our variable.py but in yaml. Add option to overwrite pfcQueueGroupSize as well and the default fallback value. So we can adjust per testbed. Fix some minimal issue from [Snappi] - Infra change for dynamic port selection from the setup replacing variables.py file. sonic-net#15069 Create folder and subfolder if it does not exist correctly for metadata.json Revert the tx_rx port in the dynamic snappi port selection Refactor the use of snappi_dut_base_config needed for consistency when toggle on and off dynamic ports selection make sure everything still work Fixes # (issue) 32317078 Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Back port request 202012 202205 202305 202311 202405 202411 Approach What is the motivation for this PR? How did you do it? How did you verify/test it? Any platform specific information? Supported testbed topology if it's a new test case? Documentation without --enable-snappi-dynamic-ports image with --enable-snappi-dynamic-ports image Signed-off-by: Austin Pham <[email protected]> Signed-off-by: Aharon Malkin <[email protected]>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 21, 2025
Description of PR Summary: This PR adds the following features: Enable options to overwrite dynamic port selection introduced by [Snappi] - Infra change for dynamic port selection from the setup replacing variables.py file. sonic-net#15069. We can force running dynamic-port selection feature by adding --enable-snappi-dynamic-ports in the CLI. We can override by using variables.override.yml. The config is similar to our variable.py but in yaml. Add option to overwrite pfcQueueGroupSize as well and the default fallback value. So we can adjust per testbed. Fix some minimal issue from [Snappi] - Infra change for dynamic port selection from the setup replacing variables.py file. sonic-net#15069 Create folder and subfolder if it does not exist correctly for metadata.json Revert the tx_rx port in the dynamic snappi port selection Refactor the use of snappi_dut_base_config needed for consistency when toggle on and off dynamic ports selection make sure everything still work Fixes # (issue) 32317078 Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Back port request 202012 202205 202305 202311 202405 202411 Approach What is the motivation for this PR? How did you do it? How did you verify/test it? Any platform specific information? Supported testbed topology if it's a new test case? Documentation without --enable-snappi-dynamic-ports image with --enable-snappi-dynamic-ports image Signed-off-by: Austin Pham <[email protected]> Signed-off-by: Guy Shemesh <[email protected]>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Jan 26, 2026
Description of PR Summary: This PR adds the following features: Enable options to overwrite dynamic port selection introduced by [Snappi] - Infra change for dynamic port selection from the setup replacing variables.py file. sonic-net#15069. We can force running dynamic-port selection feature by adding --enable-snappi-dynamic-ports in the CLI. We can override by using variables.override.yml. The config is similar to our variable.py but in yaml. Add option to overwrite pfcQueueGroupSize as well and the default fallback value. So we can adjust per testbed. Fix some minimal issue from [Snappi] - Infra change for dynamic port selection from the setup replacing variables.py file. sonic-net#15069 Create folder and subfolder if it does not exist correctly for metadata.json Revert the tx_rx port in the dynamic snappi port selection Refactor the use of snappi_dut_base_config needed for consistency when toggle on and off dynamic ports selection make sure everything still work Fixes # (issue) 32317078 Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Back port request 202012 202205 202305 202311 202405 202411 Approach What is the motivation for this PR? How did you do it? How did you verify/test it? Any platform specific information? Supported testbed topology if it's a new test case? Documentation without --enable-snappi-dynamic-ports image with --enable-snappi-dynamic-ports image Signed-off-by: Austin Pham <[email protected]> Signed-off-by: Guy Shemesh <[email protected]>
12 tasks
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
This PR adds the following features:
--enable-snappi-dynamic-portsin the CLI.We can override by using
variables.override.yml. The config is similar to our variable.py but in yaml.snappi_dut_base_configneeded for consistency when toggle on and off dynamic ports selection make sure everything still workFixes # (issue) 32317078
Type of change
Back port request
Approach
What is the motivation for this PR?
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation
without
--enable-snappi-dynamic-portswith
--enable-snappi-dynamic-ports