Skip to content

Enable dynamic port selection from setup in snappi pfcwd test#18536

Closed
ysmanman wants to merge 4 commits intosonic-net:masterfrom
ysmanman:snappi_pfcwd
Closed

Enable dynamic port selection from setup in snappi pfcwd test#18536
ysmanman wants to merge 4 commits intosonic-net:masterfrom
ysmanman:snappi_pfcwd

Conversation

@ysmanman
Copy link
Copy Markdown
Contributor

@ysmanman ysmanman commented May 21, 2025

Description of PR

Enable dynamic port selection from setup in snappi pfcwd test

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405
  • 202411

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@ysmanman
Copy link
Copy Markdown
Contributor Author

@sdszhang @kenneth-arista

@ysmanman ysmanman moved this to In Progress in SONiC Snappi May 21, 2025
@sdszhang
Copy link
Copy Markdown
Contributor

@ysmanman can you upload the test result once it's ready.

N/A
"""
testbed_config, port_config_list, snappi_ports = setup_ports_and_dut
multidut_port_info = tgen_port_info
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After #18067, this part of code needs to be changed.
You can refer to the changes in 4613e88#diff-912c62180b5b6381f1a14d8abc87ff10b45231902932c1f0e4ad8500b2801afe

@sdszhang
Copy link
Copy Markdown
Contributor

@ysmanman, any update on this one?

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command.

@ysmanman
Copy link
Copy Markdown
Contributor Author

ysmanman commented Jul 2, 2025

@ysmanman, any update on this one?

Hi @sdszhang addressed the review comments.

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@sdszhang
Copy link
Copy Markdown
Contributor

sdszhang commented Jul 9, 2025

@ysmanman can you fix the static anlysis error and upload the test result?

@sdszhang sdszhang moved this from In Progress to In Review in SONiC Snappi Aug 13, 2025
@sdszhang
Copy link
Copy Markdown
Contributor

@ysmanman , can you fix the static analysis error? Then I can help to verify on our testbed.

@ysmanman
Copy link
Copy Markdown
Contributor Author

/Azpw run Azure.sonic-mgmt

@mssonicbld
Copy link
Copy Markdown
Collaborator

/AzurePipelines run Azure.sonic-mgmt

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@ysmanman
Copy link
Copy Markdown
Contributor Author

@ysmanman , can you fix the static analysis error? Then I can help to verify on our testbed.

Hi @sdszhang , fixed static analysis error.

@sdszhang
Copy link
Copy Markdown
Contributor

@ysmanman I got the following error when testing it on my testbed. can you take a look?

_ ERROR at setup of test_pfcwd_basic_single_lossless_prio[multidut_port_info0-tgen_port_info0-True] _
ScopeMismatch: You tried to access the function scoped fixture number_of_tx_rx_ports with a module scoped request object, involved factories:
common/snappi_tests/snappi_fixtures.py:1429:  def snappi_port_selection(get_snappi_ports, number_of_tx_rx_ports, mixed_speed=None)
snappi_tests/pfcwd/test_pfcwd_basic_with_snappi.py:30:  def number_of_tx_rx_ports()

@sdszhang sdszhang moved this from In Review to Todo in SONiC Snappi Jan 14, 2026
@sdszhang
Copy link
Copy Markdown
Contributor

@ediwibowo-msft can you pick up this PR and raise a new PR to get this one merged?

@sdszhang
Copy link
Copy Markdown
Contributor

merged in #23225 with test logs. closing this one.

@sdszhang sdszhang closed this Mar 27, 2026
@github-project-automation github-project-automation bot moved this from Todo to Done in SONiC Snappi Mar 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants