[Snappi] - Test Changes to support Infra changes for dynamic port selection from the setup replacing variables.py file by YatishSVC · Pull Request #18091 · sonic-net/sonic-mgmt

YatishSVC · 2025-04-23T05:17:00Z

Description of PR

Summary:
Fixes # (issue)
#13769

Type of change

Back port request

Approach

What is the motivation for this PR?

To support infra changes in snappi tests introduced by this Pull Request - #15069

How did you do it?

We don't need the setup_ports_and_dut now and we can simply call the snappi_testbed_config in the test itself and iterate through the available ports.

How did you verify/test it?

Ran in Microsoft Lab on T2 Arista Chassis.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

mssonicbld · 2025-04-23T05:17:08Z

/azp run

azure-pipelines · 2025-04-23T05:17:14Z

Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command.

mssonicbld · 2025-04-23T05:17:20Z

/azp run

azure-pipelines · 2025-04-23T05:17:31Z

Azure Pipelines successfully started running 1 pipeline(s).

YatishSVC · 2025-04-23T05:20:02Z

@amitpawar12, @kamalsahu0001 For viz.

sdszhang · 2025-04-23T07:59:21Z

@YatishSVC can you share the test result on T0 testbed?

sdszhang · 2025-04-23T23:13:02Z

@amitpawar12 can you review this?

sdszhang · 2025-04-23T23:21:53Z

pending on #17920

sdszhang · 2025-05-05T06:22:33Z

pending on #18067

sdszhang · 2025-06-04T23:47:53Z

@YatishSVC can you resolve the conflicts and upload a test result as well. Thanks!

mssonicbld · 2025-06-06T17:27:52Z

/azp run

azure-pipelines · 2025-06-06T17:27:58Z

Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command.

mssonicbld · 2025-06-06T17:38:39Z

/azp run

azure-pipelines · 2025-06-06T17:38:45Z

Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command.

mssonicbld · 2025-06-06T17:43:48Z

/azp run

azure-pipelines · 2025-06-06T17:44:01Z

Azure Pipelines successfully started running 1 pipeline(s).

…ection from the setup replacing variables.py file (sonic-net#18091) Description of PR Summary: Fixes # (issue) sonic-net#13769 Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Approach What is the motivation for this PR? To support infra changes in snappi tests introduced by this Pull Request - sonic-net#15069 How did you do it? We don't need the setup_ports_and_dut now and we can simply call the snappi_testbed_config in the test itself and iterate through the available ports. How did you verify/test it? Ran in Microsoft Lab on T2 Arista Chassis. Co-authored-by: yatishkoul <yatishkoul@gmail.com>

mssonicbld · 2025-06-09T01:01:08Z

Cherry-pick PR to 202505: #18858

…ection from the setup replacing variables.py file (#18091) Description of PR Summary: Fixes # (issue) #13769 Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Approach What is the motivation for this PR? To support infra changes in snappi tests introduced by this Pull Request - #15069 How did you do it? We don't need the setup_ports_and_dut now and we can simply call the snappi_testbed_config in the test itself and iterate through the available ports. How did you verify/test it? Ran in Microsoft Lab on T2 Arista Chassis. Co-authored-by: yatishkoul <yatishkoul@gmail.com>

…ection from the setup replacing variables.py file (sonic-net#18091) Description of PR Summary: Fixes # (issue) sonic-net#13769 Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Approach What is the motivation for this PR? To support infra changes in snappi tests introduced by this Pull Request - sonic-net#15069 How did you do it? We don't need the setup_ports_and_dut now and we can simply call the snappi_testbed_config in the test itself and iterate through the available ports. How did you verify/test it? Ran in Microsoft Lab on T2 Arista Chassis. Co-authored-by: yatishkoul <yatishkoul@gmail.com>

…ection from the setup replacing variables.py file (sonic-net#18091) Description of PR Summary: Fixes # (issue) sonic-net#13769 Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Approach What is the motivation for this PR? To support infra changes in snappi tests introduced by this Pull Request - sonic-net#15069 How did you do it? We don't need the setup_ports_and_dut now and we can simply call the snappi_testbed_config in the test itself and iterate through the available ports. How did you verify/test it? Ran in Microsoft Lab on T2 Arista Chassis. Co-authored-by: yatishkoul <yatishkoul@gmail.com> Signed-off-by: opcoder0 <110003254+opcoder0@users.noreply.github.com>

…ection from the setup replacing variables.py file (sonic-net#18091) Description of PR Summary: Fixes # (issue) sonic-net#13769 Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Approach What is the motivation for this PR? To support infra changes in snappi tests introduced by this Pull Request - sonic-net#15069 How did you do it? We don't need the setup_ports_and_dut now and we can simply call the snappi_testbed_config in the test itself and iterate through the available ports. How did you verify/test it? Ran in Microsoft Lab on T2 Arista Chassis. Co-authored-by: yatishkoul <yatishkoul@gmail.com> Signed-off-by: Aharon Malkin <amalkin@nvidia.com>

…ection from the setup replacing variables.py file (sonic-net#18091) Description of PR Summary: Fixes # (issue) sonic-net#13769 Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Approach What is the motivation for this PR? To support infra changes in snappi tests introduced by this Pull Request - sonic-net#15069 How did you do it? We don't need the setup_ports_and_dut now and we can simply call the snappi_testbed_config in the test itself and iterate through the available ports. How did you verify/test it? Ran in Microsoft Lab on T2 Arista Chassis. Co-authored-by: yatishkoul <yatishkoul@gmail.com> Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>

…ection from the setup replacing variables.py file (sonic-net#18091) Description of PR Summary: Fixes # (issue) sonic-net#13769 Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Approach What is the motivation for this PR? To support infra changes in snappi tests introduced by this Pull Request - sonic-net#15069 How did you do it? We don't need the setup_ports_and_dut now and we can simply call the snappi_testbed_config in the test itself and iterate through the available ports. How did you verify/test it? Ran in Microsoft Lab on T2 Arista Chassis. Co-authored-by: yatishkoul <yatishkoul@gmail.com>

…ection from the setup replacing variables.py file (sonic-net#18091) Description of PR Summary: Fixes # (issue) sonic-net#13769 Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Approach What is the motivation for this PR? To support infra changes in snappi tests introduced by this Pull Request - sonic-net#15069 How did you do it? We don't need the setup_ports_and_dut now and we can simply call the snappi_testbed_config in the test itself and iterate through the available ports. How did you verify/test it? Ran in Microsoft Lab on T2 Arista Chassis. Co-authored-by: yatishkoul <yatishkoul@gmail.com> Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>

…ection from the setup replacing variables.py file (sonic-net#18091) Description of PR Summary: Fixes # (issue) sonic-net#13769 Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Approach What is the motivation for this PR? To support infra changes in snappi tests introduced by this Pull Request - sonic-net#15069 How did you do it? We don't need the setup_ports_and_dut now and we can simply call the snappi_testbed_config in the test itself and iterate through the available ports. How did you verify/test it? Ran in Microsoft Lab on T2 Arista Chassis. Co-authored-by: yatishkoul <yatishkoul@gmail.com> Signed-off-by: Yael Tzur <ytzur@nvidia.com>

…ection from the setup replacing variables.py file (sonic-net#18091) Description of PR Summary: Fixes # (issue) sonic-net#13769 Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Approach What is the motivation for this PR? To support infra changes in snappi tests introduced by this Pull Request - sonic-net#15069 How did you do it? We don't need the setup_ports_and_dut now and we can simply call the snappi_testbed_config in the test itself and iterate through the available ports. How did you verify/test it? Ran in Microsoft Lab on T2 Arista Chassis. Co-authored-by: yatishkoul <yatishkoul@gmail.com>

yatishkoul and others added 14 commits March 31, 2025 10:12

Changes to support RDMA Tests for VOQ Chassis

8868b8a

Merge branch 'sonic-net:master' into snappi_tests_fixes

eea612b

Enhancements

cd1eab4

Merge branch 'sonic-net:master' into snappi_tests_fixes

d876bc1

Added changes to separate voq and non-voq chassis checks

d0cff24

Updating some limits for loss %ages

2894678

Adding some more changes

65a68a0

Merge branch 'sonic-net:master' into snappi_tests_fixes

79b904b

Merge branch 'sonic-net:master' into snappi_tests_fixes

b4e472d

Adding New infra Changes for testcases

d58b50c

Adding New infra Changes for testcases:pre-commit hooks

9cb17fd

Update snappi_fixtures.py

73130a5

Update test_pretest.py

6c1834c

Update conftest.py

7765b2e

Merge branch 'sonic-net:master' into snappi_tests_fixes

dd8ac2c

YatishSVC requested review from sdszhang and vmittal-msft April 23, 2025 05:17

YatishSVC requested a review from auspham April 23, 2025 05:20

YatishSVC added this to SONiC Snappi Apr 23, 2025

YatishSVC moved this to In Progress in SONiC Snappi Apr 23, 2025

sdszhang approved these changes Apr 23, 2025

View reviewed changes

Resolving Merge Conflicts 01

b24b0c5

resolve merge conflicts

889c27d

Merge branch 'master' into snappi_tests_fixes

6e818cf

sdszhang moved this from In Progress to To be Merged in SONiC Snappi Jun 8, 2025

sdszhang added the Request for 202505 branch label Jun 8, 2025

yejianquan merged commit 6621a0f into sonic-net:master Jun 9, 2025
11 checks passed

github-project-automation bot moved this from To be Merged to Done in SONiC Snappi Jun 9, 2025

yejianquan added the Approved for 202505 branch label Jun 9, 2025

mssonicbld added the Created PR to 202505 branch label Jun 9, 2025

mssonicbld mentioned this pull request Jun 9, 2025

[action] [PR:18091] [Snappi] - Test Changes to support Infra changes for dynamic port selection from the setup replacing variables.py file #18858

Merged

11 tasks

mssonicbld added Included in 202505 branch and removed Created PR to 202505 branch labels Jun 9, 2025

Conversation

YatishSVC commented Apr 23, 2025

Description of PR

Type of change

Back port request

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Uh oh!

mssonicbld commented Apr 23, 2025

Uh oh!

azure-pipelines bot commented Apr 23, 2025

Uh oh!

mssonicbld commented Apr 23, 2025

Uh oh!

azure-pipelines bot commented Apr 23, 2025

Uh oh!

YatishSVC commented Apr 23, 2025

Uh oh!

sdszhang commented Apr 23, 2025

Uh oh!

sdszhang commented Apr 23, 2025

Uh oh!

sdszhang commented Apr 23, 2025

Uh oh!

sdszhang commented May 5, 2025

Uh oh!

sdszhang commented Jun 4, 2025

Uh oh!

mssonicbld commented Jun 6, 2025

Uh oh!

azure-pipelines bot commented Jun 6, 2025

Uh oh!

mssonicbld commented Jun 6, 2025

Uh oh!

azure-pipelines bot commented Jun 6, 2025

Uh oh!

mssonicbld commented Jun 6, 2025

Uh oh!

azure-pipelines bot commented Jun 6, 2025

Uh oh!

Uh oh!

mssonicbld commented Jun 9, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants