Generate PFC storm using PFC backpressure on additional Arista devices#18033
Merged
StormLiangMS merged 9 commits intosonic-net:masterfrom Apr 24, 2025
Merged
Conversation
Add a pfc_gen script that generates storm by directly setting PFC backpressure status in hardware (using broadcom shell commands) and modify pfc_storm to use this new script if the port is connected to th5 MPC. Intended to upstream for MSFT.
…m-gen-via-pfc-backpres
…m-gen-via-pfc-backpres
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
11 tasks
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
Thanks @andywongarista , If you have a chance to verify this enhancement with the case "test_pfcwd_timer_accuracy"? If yes, could you please provide the "sorted all detect time" value with this enhancement, thanks a lot |
Contributor
Author
From a 7260 testbed: |
Collaborator
|
Cherry-pick PR to msft-202412: Azure/sonic-mgmt.msft#222 |
mssonicbld
added
Included in msft-202412 Branch
and removed
Created PR to msft-202412 Branch
labels
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
May 8, 2025
sonic-net#18033) What is the motivation for this PR? Adds more reliable PFC storm generation for interfaces connected to Arista fanout devices How did you do it? How did you verify/test it? Ran sonic-mgmt pfcwd tests on testbed with Arista fanout switches of the listed SKUs running EOS. Ran the pfc_gen script manually on Arista switches running Sonic.
Collaborator
|
Cherry-pick PR to 202411: #18285 |
Open
11 tasks
8 tasks
opcoder0
pushed a commit
to opcoder0/sonic-mgmt
that referenced
this pull request
Dec 8, 2025
sonic-net#18033) What is the motivation for this PR? Adds more reliable PFC storm generation for interfaces connected to Arista fanout devices How did you do it? How did you verify/test it? Ran sonic-mgmt pfcwd tests on testbed with Arista fanout switches of the listed SKUs running EOS. Ran the pfc_gen script manually on Arista switches running Sonic. Signed-off-by: opcoder0 <110003254+opcoder0@users.noreply.github.com>
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Dec 16, 2025
sonic-net#18033) What is the motivation for this PR? Adds more reliable PFC storm generation for interfaces connected to Arista fanout devices How did you do it? How did you verify/test it? Ran sonic-mgmt pfcwd tests on testbed with Arista fanout switches of the listed SKUs running EOS. Ran the pfc_gen script manually on Arista switches running Sonic. Signed-off-by: Aharon Malkin <amalkin@nvidia.com>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 21, 2025
sonic-net#18033) What is the motivation for this PR? Adds more reliable PFC storm generation for interfaces connected to Arista fanout devices How did you do it? How did you verify/test it? Ran sonic-mgmt pfcwd tests on testbed with Arista fanout switches of the listed SKUs running EOS. Ran the pfc_gen script manually on Arista switches running Sonic. Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Jan 26, 2026
sonic-net#18033) What is the motivation for this PR? Adds more reliable PFC storm generation for interfaces connected to Arista fanout devices How did you do it? How did you verify/test it? Ran sonic-mgmt pfcwd tests on testbed with Arista fanout switches of the listed SKUs running EOS. Ran the pfc_gen script manually on Arista switches running Sonic. Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
NOTE: This is a duplicate of #17971, as @veronica-arista is away.
Add a pfc_gen script for Arista fanout devices to generate pfc pause frames by setting PFC backpressure status in hardware. Enable the storm generation to use this script on interfaces that are connected to Arista fanout devices running EOS or Sonic. Currently supports the following Arista devices:
Arista-7060X6
Arista-7060DX5
Arista-7060PX5
Arista-7060CX
Arista-7260CX3
Arista-7260QX3
This is implemented on top of PR #15594
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Adds more reliable PFC storm generation for interfaces connected to Arista fanout devices
How did you do it?
How did you verify/test it?
Ran sonic-mgmt pfcwd tests on testbed with Arista fanout switches of the listed SKUs running EOS.
Ran the pfc_gen script manually on Arista switches running Sonic.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation