Generate PFC storm using PFC backpressure on additional Arista devices by veronica-arista · Pull Request #17971 · sonic-net/sonic-mgmt

veronica-arista · 2025-04-12T05:51:27Z

Description of PR

Add a pfc_gen script for Arista fanout devices to generate pfc pause frames by setting PFC backpressure status in hardware. Enable the storm generation to use this script on interfaces that are connected to Arista fanout devices running EOS or Sonic. Currently supports the following Arista devices:
Arista-7060X6
Arista-7060DX5
Arista-7060PX5
Arista-7060CX
Arista-7260CX3
Arista-7260QX3

This is implemented on top of PR #15594

Summary:
Fixes # (issue)

Type of change

Back port request

Approach

What is the motivation for this PR?

Adds more reliable PFC storm generation for interfaces connected to Arista fanout devices

How did you do it?

How did you verify/test it?

Ran sonic-mgmt pfcwd tests on testbed with Arista fanout switches of the listed SKUs running EOS.
Ran the pfc_gen script manually on Arista switches running Sonic.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Add a pfc_gen script that generates storm by directly setting PFC backpressure status in hardware (using broadcom shell commands) and modify pfc_storm to use this new script if the port is connected to th5 MPC. Intended to upstream for MSFT.

…m-gen-via-pfc-backpres

mssonicbld · 2025-04-12T05:51:35Z

/azp run

azure-pipelines · 2025-04-12T05:51:46Z

Azure Pipelines successfully started running 1 pipeline(s).

lipxu · 2025-04-15T06:05:42Z

Thanks @veronica-arista , can you please run the test_pfcwd_timer_accuracy case and share the logs of "sorted all detect time", thanks a lot

lipxu · 2025-04-15T06:09:12Z

tests/common/templates/pfc_storm_arista_eos.j2

+bash
+cd {{pfc_gen_dir}}
+{% if (pfc_asym is defined) and (pfc_asym == True) %}
+{% if pfc_storm_defer_time is defined %}sleep {{pfc_storm_defer_time}} &&{% endif %} sudo python3 {{pfc_gen_file}} -c {{pfc_gen_chip_name}} -p {{pfc_queue_index}} -i {{pfc_fanout_interface | replace("Ethernet", "et") | replace("/", "_")}} > /dev/null 2>&1 &


Does this new feature only support python3? Are there any limitations, thanks

There is no testing on python2. Python2 is long out of support.

XuChen-MSFT · 2025-04-15T06:56:59Z

@veronica-arista Nice change. May I ask how much delay there is when enabling and disabling PFC via hardware?
Also, do you have a test report?

XuChen-MSFT

approved

XuChen-MSFT · 2025-04-17T05:10:45Z

@veronica-arista need to address below pre-commit failure

Pre-commit check results:
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Failed

hook id: flake8
exit code: 1

tests/common/helpers/pfc_gen_brcm_xgs.py:7:1: F401 'binascii' imported but unused
tests/common/helpers/pfc_gen_brcm_xgs.py:46:121: E501 line too long (132 > 120 characters)
tests/common/helpers/pfc_gen_brcm_xgs.py:79:31: F541 f-string is missing placeholders
tests/common/helpers/pfc_gen_brcm_xgs.py:82:52: W605 invalid escape sequence '\S'
tests/common/helpers/pfc_gen_brcm_xgs.py:82:83: W605 invalid escape sequence '\S'
tests/common/helpers/pfc_gen_brcm_xgs.py:82:98: W605 invalid escape sequence '['
tests/common/helpers/pfc_gen_brcm_xgs.py:82:106: W605 invalid escape sequence '\d'
tests/common/helpers/pfc_gen_brcm_xgs.py:82:109: W605 invalid escape sequence ']'
tests/common/helpers/pfc_gen_brcm_xgs.py:82:121: E501 line too long (137 > 120 characters)
tests/common/helpers/pfc_gen_brcm_xgs.py:82:126: W605 invalid escape sequence '\S'
tests/common/helpers/pfc_gen_brcm_xgs.py:100:20: E111 indentation is not a multiple of 4
tests/common/helpers/pfc_gen_brcm_xgs.py:117:20: E111 indentation is not a multiple of 4
tests/common/helpers/pfc_gen_brcm_xgs.py:221:5: F841 local variable 'fsCleanup' is assigned to but never used
tests/common/helpers/pfc_gen_brcm_xgs.py:232:8: E111 indentation is not a multiple of 4
tests/common/helpers/pfc_gen_brcm_xgs.py:234:1: E302 expected 2 blank lines, found 1
tests/common/helpers/pfc_gen_brcm_xgs.py:235:4: E111 indentation is not a multiple of 4
tests/common/helpers/pfc_storm.py:15:1: E302 expected 2 blank lines, found 1
tests/common/helpers/pfc_storm.py:34:1: E302 expected 2 blank lines, found 1
tests/common/helpers/pfc_storm.py:177:15: E271 multiple spaces after keyword
tests/common/helpers/pfc_storm.py:266:121: E501 line too long (128 > 120 characters)
tests/common/helpers/pfc_storm.py:267:121: E501 line too long (126 > 120 characters)
tests/common/helpers/pfc_storm.py:289:121: E501 line too long (128 > 120 characters)
tests/common/helpers/pfc_storm.py:290:121: E501 line too long (126 > 120 characters)

flake8...............................................(no files to check)Skipped
check conditional mark sort..........................(no files to check)Skipped

##[error]Bash exited with code '1'.
Finishing: Run pre-commit check

andywongarista · 2025-04-17T19:07:50Z

@XuChen-MSFT Since @veronica-arista is away I have duplicated this PR with pre-commit errors fixed, please review: #18033

@veronica-arista

### Description of PR NOTE: This is a duplicate of sonic-net/sonic-mgmt#17971, as @veronica-arista is away. Add a pfc_gen script for Arista fanout devices to generate pfc pause frames by setting PFC backpressure status in hardware. Enable the storm generation to use this script on interfaces that are connected to Arista fanout devices running EOS or Sonic. Currently supports the following Arista devices: Arista-7060X6 Arista-7060DX5 Arista-7060PX5 Arista-7060CX Arista-7260CX3 Arista-7260QX3 This is implemented on top of PR sonic-net/sonic-mgmt#15594 Summary: Fixes # (issue) ### Type of change  - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [x] Test case improvement ### Back port request - [x] 202012 - [ ] 202205 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [x] 202411 ### Approach #### What is the motivation for this PR? Adds more reliable PFC storm generation for interfaces connected to Arista fanout devices #### How did you do it? #### How did you verify/test it? Ran sonic-mgmt pfcwd tests on testbed with Arista fanout switches of the listed SKUs running EOS. Ran the pfc_gen script manually on Arista switches running Sonic. #### Any platform specific information? #### Supported testbed topology if it's a new test case? ### Documentation

@veronica-arista

…tional Arista devices (#222)  ### Description of PR NOTE: This is a duplicate of sonic-net/sonic-mgmt#17971, as @veronica-arista is away. Add a pfc_gen script for Arista fanout devices to generate pfc pause frames by setting PFC backpressure status in hardware. Enable the storm generation to use this script on interfaces that are connected to Arista fanout devices running EOS or Sonic. Currently supports the following Arista devices: Arista-7060X6 Arista-7060DX5 Arista-7060PX5 Arista-7060CX Arista-7260CX3 Arista-7260QX3 This is implemented on top of PR sonic-net/sonic-mgmt#15594 Summary: Fixes # (issue) ### Type of change  - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [x] Test case improvement ### Back port request - [x] 202012 - [ ] 202205 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [x] 202411 ### Approach #### What is the motivation for this PR? Adds more reliable PFC storm generation for interfaces connected to Arista fanout devices #### How did you do it? #### How did you verify/test it? Ran sonic-mgmt pfcwd tests on testbed with Arista fanout switches of the listed SKUs running EOS. Ran the pfc_gen script manually on Arista switches running Sonic. #### Any platform specific information? #### Supported testbed topology if it's a new test case? ### Documentation

lipxu · 2025-04-28T08:13:29Z

@veronica-arista Could we close this PR since it should duplicate with #18033, thanks

veronica-arista · 2025-05-10T03:26:23Z

Closing since this change was merged as #18033

veronica-arista added 7 commits November 15, 2024 20:59

Update the pfc_gen with backpressure for Arista device to work on Sonic

44459e1

Merge remote-tracking branch 'upstream/master' into master-pfcwd-stor…

8364bf8

…m-gen-via-pfc-backpres

Fix indentation

bce1f84

Resolve pre-commit check errors

14eaaef

Merge remote-tracking branch 'upstream/master' into master-pfcwd-stor…

bfbe274

…m-gen-via-pfc-backpres

Add support for TH and TH2 chips for pfc_gen using backpresure

b08f825

veronica-arista mentioned this pull request Apr 12, 2025

Generate PFC storm using PFC backpressure on Arista DCS-7060X6 devices #15594

Closed

8 tasks

veronica-arista changed the title ~~Pfc gen backpressure th th2~~ Generate PFC storm using PFC backpressure on additional Arista devices Apr 12, 2025

lipxu reviewed Apr 15, 2025

View reviewed changes

lipxu approved these changes Apr 17, 2025

View reviewed changes

XuChen-MSFT approved these changes Apr 17, 2025

View reviewed changes

andywongarista mentioned this pull request Apr 17, 2025

Generate PFC storm using PFC backpressure on additional Arista devices #18033

Merged

11 tasks

mssonicbld mentioned this pull request Apr 24, 2025

[action] [PR:18033] Generate PFC storm using PFC backpressure on additional Arista devices Azure/sonic-mgmt.msft#222

Merged

11 tasks

mssonicbld mentioned this pull request May 8, 2025

[action] [PR:18033] Generate PFC storm using PFC backpressure on additional Arista devices #18285

Open

11 tasks

veronica-arista closed this May 10, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Generate PFC storm using PFC backpressure on additional Arista devices#17971

Generate PFC storm using PFC backpressure on additional Arista devices#17971
veronica-arista wants to merge 7 commits intosonic-net:masterfrom
veronica-arista:pfc_gen_backpressure_th_th2

veronica-arista commented Apr 12, 2025 •

edited

Loading

Uh oh!

mssonicbld commented Apr 12, 2025

Uh oh!

azure-pipelines bot commented Apr 12, 2025

Uh oh!

lipxu commented Apr 15, 2025

Uh oh!

lipxu Apr 15, 2025

Uh oh!

davidm-arista Apr 17, 2025

Uh oh!

XuChen-MSFT commented Apr 15, 2025

Uh oh!

XuChen-MSFT left a comment

Uh oh!

XuChen-MSFT commented Apr 17, 2025

Uh oh!

andywongarista commented Apr 17, 2025

Uh oh!

lipxu commented Apr 28, 2025

Uh oh!

veronica-arista commented May 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

veronica-arista commented Apr 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of PR

Type of change

Back port request

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Uh oh!

mssonicbld commented Apr 12, 2025

Uh oh!

azure-pipelines bot commented Apr 12, 2025

Uh oh!

lipxu commented Apr 15, 2025

Uh oh!

lipxu Apr 15, 2025

Choose a reason for hiding this comment

Uh oh!

davidm-arista Apr 17, 2025

Choose a reason for hiding this comment

Uh oh!

XuChen-MSFT commented Apr 15, 2025

Uh oh!

XuChen-MSFT left a comment

Choose a reason for hiding this comment

Uh oh!

XuChen-MSFT commented Apr 17, 2025

Uh oh!

andywongarista commented Apr 17, 2025

Uh oh!

lipxu commented Apr 28, 2025

Uh oh!

veronica-arista commented May 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

veronica-arista commented Apr 12, 2025 •

edited

Loading