Generate PFC storm using PFC backpressure on Arista DCS-7060X6 devices by veronica-arista · Pull Request #15594 · sonic-net/sonic-mgmt

veronica-arista · 2024-11-15T21:15:18Z

Description of PR

Add a pfc_gen script for Arista DCS-7060X6 fanout devices to generate pfc pause frames by setting PFC backpressure status in hardware. Enable the storm generation to use this script on interfaces that are connected to Arista DCS-7060X6 fanout devices running EOS.

Summary:
Fixes # (issue)

Type of change

Bug fix
Testbed and Framework(new/improvement)
Test case(new/improvement)

Back port request

Approach

What is the motivation for this PR?

Adds more reliable PFC storm generation for interfaces connected to Arista DCS-7060X6 fanout devices

How did you do it?

How did you verify/test it?

Ran the pfcwd tests on t1 switch with interfaces connected to Arista DCS-7060X6 device, ensured the new script was used and pfc storm was appropriately detected.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Add a pfc_gen script that generates storm by directly setting PFC backpressure status in hardware (using broadcom shell commands) and modify pfc_storm to use this new script if the port is connected to th5 MPC. Intended to upstream for MSFT.

mssonicbld · 2024-11-15T21:16:34Z

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Failed - hook id: trailing-whitespace - exit code: 1 - files were modified by this hook Fixing tests/common/helpers/pfc_gen_th5.py fix end of files.........................................................Passed check yaml...........................................(no files to check)Skipped check for added large files..............................................Passed check python ast.........................................................Passed flake8...................................................................Failed - hook id: flake8 - exit code: 1 tests/common/helpers/pfc_gen_th5.py:7:1: F401 'binascii' imported but unused tests/common/helpers/pfc_gen_th5.py:59:31: F541 f-string is missing placeholders tests/common/helpers/pfc_gen_th5.py:62:52: W605 invalid escape sequence 'S' tests/common/helpers/pfc_gen_th5.py:62:67: W605 invalid escape sequence '[' tests/common/helpers/pfc_gen_th5.py:62:75: W605 invalid escape sequence 'd' ... [truncated extra lines, please run pre-commit locally to view full check results]

To run the pre-commit checks locally, you can follow below steps:

Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
docker container.
Ensure that the pre-commit package is installed:

sudo pip install pre-commit

Go to repository root folder
Install the pre-commit hooks:

pre-commit install

Use pre-commit to check staged file:

pre-commit

Alternatively, you can check committed files using:

pre-commit run --from-ref <commit_id> --to-ref <commit_id>

auspham · 2024-12-22T23:38:28Z

hi @veronica-arista would this also be suitable for Arista-7260CX3?

mssonicbld · 2025-01-16T00:04:51Z

/azp run

azure-pipelines · 2025-01-16T00:04:57Z

Pull request contains merge conflicts.

…m-gen-via-pfc-backpres

mssonicbld · 2025-01-16T01:22:37Z

/azp run

azure-pipelines · 2025-01-16T01:22:48Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-01-22T22:57:37Z

/azp run

azure-pipelines · 2025-01-22T22:57:50Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-01-22T23:27:29Z

/azp run

azure-pipelines · 2025-01-22T23:27:41Z

Azure Pipelines successfully started running 1 pipeline(s).

StormLiangMS · 2025-02-27T02:10:54Z

/azp run

azure-pipelines · 2025-02-27T02:11:05Z

Azure Pipelines successfully started running 1 pipeline(s).

lipxu · 2025-03-04T05:50:24Z

tests/common/helpers/pfc_storm.py

        Deploy the pfc generation file on the fanout
        """
+        if self.peer_device.os in ('eos', 'sonic'):
+            if ((self.peer_device.os == 'eos' and self._get_eos_fanout_version()[0].startswith('Arista DCS-7060X6')) or


We have the fanout_hosts in this class, Can you check whether we could get this information from the fanout_hosts to avoid creating the new function here, thanks

What does fanout_hosts contain in your testbed? We only have testbeds with eos devices as fanouts and the device version is not populated in the testbeds I'm using.

(Pdb) p self.fanout_hosts {'nv681': { os: 'eos', hostname: 'nv681', device_type: 'FanoutLeaf' }}

lipxu · 2025-03-04T05:52:14Z

tests/common/helpers/pfc_storm.py

        """
+        if self.peer_device.os in ('eos', 'sonic'):
+            if ((self.peer_device.os == 'eos' and self._get_eos_fanout_version()[0].startswith('Arista DCS-7060X6')) or
+               (self.peer_device.os == 'sonic' and self._get_sonic_fanout_hwsku().startswith('Arista-7060X6-64'))):


Same with above, could you please double check, thanks a lot.

lipxu · 2025-03-04T05:54:07Z

tests/common/helpers/pfc_storm.py

        elif self.fanout_asic_type == 'mellanox' and self.peer_device.os == 'sonic':
            self.pfc_start_template = os.path.join(
                TEMPLATES_DIR, "pfc_storm_mlnx_{}.j2".format(self.peer_device.os))
+        elif ((self.peer_device.os == 'eos' and self._get_eos_fanout_version()[0].startswith('Arista DCS-7060X6')) or


We implement the support for 7060X6 in this PR, May I know what's the plan for other devices? like 7060,7260, thanks.

We are working on this currently, the 7060 support can be available sooner, the other listed devices will take longer.

StormLiangMS · 2025-03-24T01:42:50Z

/azp run

azure-pipelines · 2025-03-24T01:43:02Z

Azure Pipelines successfully started running 1 pipeline(s).

StormLiangMS · 2025-03-24T01:43:18Z

hi @lipxu any more comments for this PR? Let's assume this one is for 7060X6 only.

…m-gen-via-pfc-backpres

mssonicbld · 2025-04-12T04:39:41Z

/azp run

azure-pipelines · 2025-04-12T04:39:52Z

Azure Pipelines successfully started running 1 pipeline(s).

veronica-arista · 2025-04-12T06:03:57Z

Since you wanted to merge this PR as is now, I opened #17971 on top of these changes to add support for:
Arista-7060X6
Arista-7060CX
Arista-7260CX3
Arista-7260QX3

@veronica-arista

### Description of PR NOTE: This is a duplicate of sonic-net/sonic-mgmt#17971, as @veronica-arista is away. Add a pfc_gen script for Arista fanout devices to generate pfc pause frames by setting PFC backpressure status in hardware. Enable the storm generation to use this script on interfaces that are connected to Arista fanout devices running EOS or Sonic. Currently supports the following Arista devices: Arista-7060X6 Arista-7060DX5 Arista-7060PX5 Arista-7060CX Arista-7260CX3 Arista-7260QX3 This is implemented on top of PR sonic-net/sonic-mgmt#15594 Summary: Fixes # (issue) ### Type of change  - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [x] Test case improvement ### Back port request - [x] 202012 - [ ] 202205 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [x] 202411 ### Approach #### What is the motivation for this PR? Adds more reliable PFC storm generation for interfaces connected to Arista fanout devices #### How did you do it? #### How did you verify/test it? Ran sonic-mgmt pfcwd tests on testbed with Arista fanout switches of the listed SKUs running EOS. Ran the pfc_gen script manually on Arista switches running Sonic. #### Any platform specific information? #### Supported testbed topology if it's a new test case? ### Documentation

@veronica-arista

…tional Arista devices (#222)  ### Description of PR NOTE: This is a duplicate of sonic-net/sonic-mgmt#17971, as @veronica-arista is away. Add a pfc_gen script for Arista fanout devices to generate pfc pause frames by setting PFC backpressure status in hardware. Enable the storm generation to use this script on interfaces that are connected to Arista fanout devices running EOS or Sonic. Currently supports the following Arista devices: Arista-7060X6 Arista-7060DX5 Arista-7060PX5 Arista-7060CX Arista-7260CX3 Arista-7260QX3 This is implemented on top of PR sonic-net/sonic-mgmt#15594 Summary: Fixes # (issue) ### Type of change  - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [x] Test case improvement ### Back port request - [x] 202012 - [ ] 202205 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [x] 202411 ### Approach #### What is the motivation for this PR? Adds more reliable PFC storm generation for interfaces connected to Arista fanout devices #### How did you do it? #### How did you verify/test it? Ran sonic-mgmt pfcwd tests on testbed with Arista fanout switches of the listed SKUs running EOS. Ran the pfc_gen script manually on Arista switches running Sonic. #### Any platform specific information? #### Supported testbed topology if it's a new test case? ### Documentation

veronica-arista · 2025-10-23T17:26:09Z

Closing since https://github.com/sonic-net/sonic-mgmt/pull/18285 exists was merged

Update the pfc_gen with backpressure for Arista device to work on Sonic

44459e1

Merge remote-tracking branch 'upstream/master' into master-pfcwd-stor…

8364bf8

…m-gen-via-pfc-backpres

Fix indentation

bce1f84

Resolve pre-commit check errors

14eaaef

StormLiangMS requested review from lipxu and sdszhang February 27, 2025 02:12

lipxu reviewed Mar 4, 2025

View reviewed changes

Merge remote-tracking branch 'upstream/master' into master-pfcwd-stor…

bfbe274

…m-gen-via-pfc-backpres

veronica-arista mentioned this pull request Apr 12, 2025

Generate PFC storm using PFC backpressure on additional Arista devices #17971

Closed

11 tasks

lipxu approved these changes Apr 17, 2025

View reviewed changes

andywongarista mentioned this pull request Apr 17, 2025

Generate PFC storm using PFC backpressure on additional Arista devices #18033

Merged

11 tasks

mssonicbld mentioned this pull request Apr 24, 2025

[action] [PR:18033] Generate PFC storm using PFC backpressure on additional Arista devices Azure/sonic-mgmt.msft#222

Merged

11 tasks

mssonicbld mentioned this pull request May 8, 2025

[action] [PR:18033] Generate PFC storm using PFC backpressure on additional Arista devices #18285

Open

11 tasks

veronica-arista closed this Oct 23, 2025

Conversation

veronica-arista commented Nov 15, 2024

Description of PR

Type of change

Back port request

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Uh oh!

mssonicbld commented Nov 15, 2024

Uh oh!

auspham commented Dec 22, 2024

Uh oh!

mssonicbld commented Jan 16, 2025

Uh oh!

azure-pipelines bot commented Jan 16, 2025

Uh oh!

mssonicbld commented Jan 16, 2025

Uh oh!

azure-pipelines bot commented Jan 16, 2025

Uh oh!

mssonicbld commented Jan 22, 2025

Uh oh!

azure-pipelines bot commented Jan 22, 2025

Uh oh!

mssonicbld commented Jan 22, 2025

Uh oh!

azure-pipelines bot commented Jan 22, 2025

Uh oh!

StormLiangMS commented Feb 27, 2025

Uh oh!

azure-pipelines bot commented Feb 27, 2025

Uh oh!

lipxu Mar 4, 2025

Choose a reason for hiding this comment

Uh oh!

veronica-arista Mar 12, 2025

Choose a reason for hiding this comment

Uh oh!

lipxu Mar 4, 2025

Choose a reason for hiding this comment

Uh oh!

lipxu Mar 4, 2025

Choose a reason for hiding this comment

Uh oh!

veronica-arista Mar 12, 2025

Choose a reason for hiding this comment

Uh oh!

StormLiangMS commented Mar 24, 2025

Uh oh!

azure-pipelines bot commented Mar 24, 2025

Uh oh!

StormLiangMS commented Mar 24, 2025

Uh oh!

mssonicbld commented Apr 12, 2025

Uh oh!

azure-pipelines bot commented Apr 12, 2025

Uh oh!

veronica-arista commented Apr 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

veronica-arista commented Oct 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

veronica-arista commented Apr 12, 2025 •

edited

Loading