[Chassis] Fix flakiness of nhop_group, routes not programmed into har…#87
Merged
yejianquan merged 1 commit intoAzure:202405from Feb 14, 2025
Merged
Conversation
…dward after port toggle (#16959) …dward after port toggle Description of PR Summary: Fixes flakiness nhop_group failures on chassis. Approach What is the motivation for this PR? Fixes flakiness nhop_group failures on chassis. We observe flakiness failure on chassis devices Suspect it's because the route is not programmed into hardware Add external sleep to make sure route is in hardware How did you do it? Add extra waiting time for chassis device port toggle tests. How did you verify/test it? Run on PR test, and physical test passes ipfwd/test_nhop_group.py::test_nhop_group_member_count PASSED [ 20%] ipfwd/test_nhop_group.py::test_nhop_group_member_order_capability[str3-xx-1-2] SKIPPED (Order ECMP is not configured so skipping the test-case) [ 40%] ipfwd/test_nhop_group.py::test_nhop_group_interface_flap[str3-xx-1-2] PASSED [ 60%] ipfwd/test_nhop_group.py::test_nhop_group_member_order_capability[str3-xx-1-0] SKIPPED (Order ECMP is not configured so skipping the test-case) [ 80%] ipfwd/test_nhop_group.py::test_nhop_group_interface_flap[str3-xx-1-2] PASSED [100%] authorized by: jianquanye@microsoft.com
Merged
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…dward after port toggle (#16959)
…dward after port toggle
Description of PR
Summary:
Fixes flakiness nhop_group failures on chassis.
Approach
What is the motivation for this PR?
Fixes flakiness nhop_group failures on chassis.
We observe flakiness failure on chassis devices
Suspect it's because the route is not programmed into hardware Add external sleep to make sure route is in hardware
How did you do it?
Add extra waiting time for chassis device port toggle tests.
How did you verify/test it?
Run on PR test, and physical test passes
ipfwd/test_nhop_group.py::test_nhop_group_member_count PASSED [ 20%] ipfwd/test_nhop_group.py::test_nhop_group_member_order_capability[str3-xx-1-2] SKIPPED (Order ECMP is not configured so skipping the test-case) [ 40%] ipfwd/test_nhop_group.py::test_nhop_group_interface_flap[str3-xx-1-2] PASSED [ 60%] ipfwd/test_nhop_group.py::test_nhop_group_member_order_capability[str3-xx-1-0] SKIPPED (Order ECMP is not configured so skipping the test-case) [ 80%] ipfwd/test_nhop_group.py::test_nhop_group_interface_flap[str3-xx-1-2] PASSED [100%]
authorized by: jianquanye@microsoft.com
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation