Fix T2 duthosts tests_power_off_reboot.py bug again#16899
Merged
yejianquan merged 1 commit intosonic-net:masterfrom Feb 12, 2025
Merged
Fix T2 duthosts tests_power_off_reboot.py bug again#16899yejianquan merged 1 commit intosonic-net:masterfrom
yejianquan merged 1 commit intosonic-net:masterfrom
Conversation
…2 devices get test_power_off_reboot.py fix * Pass duthosts to reboot_and_check for non cisco T2 devices as well Signed-off-by: Javier Tan [email protected]
Collaborator
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
Javier-Tan
force-pushed
the
fix_power_off_reboot_bug_again
branch
from
6716451 to
e929856
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
auspham
approved these changes
Feb 12, 2025
Merged
11 tasks
Collaborator
|
@Javier-Tan PR conflicts with 202411 branch |
Collaborator
|
Cherry-pick PR to msft-202405: Azure/sonic-mgmt.msft#74 |
mssonicbld
added
Included in msft-202405 Branch
and removed
Created PR to msft-202405 Branch
labels
nnelluri-cisco
pushed a commit
to nnelluri-cisco/sonic-mgmt
that referenced
this pull request
Mar 15, 2025
…2 devices get test_power_off_reboot.py fix (sonic-net#16899) Description of PR Summary: Fixes sonic-net#16898 Approach What is the motivation for this PR? PR sonic-net#16736 reintroduces bug that we previously fixed in sonic-net#16313 by making it only applying it to Cisco chassis. How did you do it? Let duthosts be passed to reboot_and_check for all T2/chassis devices How did you verify/test it? Run on non Cisco T2 device Signed-off-by: Javier Tan [email protected]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes #16898
Type of change
Back port request
Approach
What is the motivation for this PR?
PR #16736 reintroduces bug that we previously fixed in #16313 by making it only applying it to Cisco chassis.
How did you do it?
Let
duthostsbe passed toreboot_and_checkfor all T2/chassis devicesHow did you verify/test it?
Run on non Cisco T2 device
Any platform specific information?
N/A
Supported testbed topology if it's a new test case?
N/A
Documentation
N/A