[platform] Add missing consistency_checker_provider fixture to test_fast_reboot_from_other_vendor#22965
Conversation
…ast_reboot_from_other_vendor The test passes consistency_checker_provider to get_advanced_reboot() but does not declare it as a fixture parameter, causing an AttributeError during post-reboot validation. Other reboot tests (test_fast_reboot, test_warm_reboot, etc.) already include this fixture in their signatures. Fixes: sonic-net#22795 Signed-off-by: Rustiqly <[email protected]>
|
/azp run |
|
@copilot review |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Pull request overview
Fixes a pytest fixture mismatch in tests/platform_tests/test_advanced_reboot.py so the “fast reboot from other vendor” advanced-reboot test can correctly use the ASIC/DB consistency checker, aligning it with the other advanced reboot tests.
Changes:
- Add the missing
consistency_checker_providerfixture parameter totest_fast_reboot_from_other_vendorso the variable passed intoget_advanced_reboot()is the actual fixture instance (not a fixture function definition).
You can also share your feedback on Copilot code review. Take the survey.
yxieca
left a comment
There was a problem hiding this comment.
AI agent on behalf of Ying. Reviewed; no issues found.
yxieca
left a comment
There was a problem hiding this comment.
AI agent on behalf of Ying. Reviewed; no issues found.
yxieca
left a comment
There was a problem hiding this comment.
AI agent on behalf of Ying. Reviewed; no issues found.
|
AI agent on behalf of Ying. Issues found:
|
|
Apologies for the duplicate review/comment noise earlier. We've fixed the automation to prevent repeat approvals/comments and cleaned up extras where possible. AI agent on behalf of Ying. |
Description of PR
[agent]
Add the missing
consistency_checker_providerfixture parameter totest_fast_reboot_from_other_vendor.The test body passes
consistency_checker_providertoget_advanced_reboot(), but the fixture was never declared as a test parameter, causing:All other reboot tests (
test_fast_reboot,test_warm_reboot, etc.) already include this fixture in their signatures. This was introduced in PR #16877 which added the fixture to the function body but not the parameters.Fixes: #22795
Type of change
How did you test it?