Skip to content

[platform] Add missing consistency_checker_provider fixture to test_fast_reboot_from_other_vendor#22965

Open
rustiqly wants to merge 1 commit intosonic-net:masterfrom
rustiqly:fix/advanced-reboot-missing-fixture
Open

[platform] Add missing consistency_checker_provider fixture to test_fast_reboot_from_other_vendor#22965
rustiqly wants to merge 1 commit intosonic-net:masterfrom
rustiqly:fix/advanced-reboot-missing-fixture

Conversation

@rustiqly
Copy link
Contributor

@rustiqly rustiqly commented Mar 13, 2026

Description of PR

[agent]
Add the missing consistency_checker_provider fixture parameter to test_fast_reboot_from_other_vendor.

The test body passes consistency_checker_provider to get_advanced_reboot(), but the fixture was never declared as a test parameter, causing:

AttributeError: 'FixtureFunctionDefinition' object has no attribute 'is_consistency_check_supported'

All other reboot tests (test_fast_reboot, test_warm_reboot, etc.) already include this fixture in their signatures. This was introduced in PR #16877 which added the fixture to the function body but not the parameters.

Fixes: #22795

Type of change

  • Bug fix

How did you test it?

AST parse: OK
Verified consistency_checker_provider is now in function signature (line 105)
and matches the reference in get_advanced_reboot() call (line 116)

…ast_reboot_from_other_vendor

The test passes consistency_checker_provider to get_advanced_reboot()
but does not declare it as a fixture parameter, causing an
AttributeError during post-reboot validation.

Other reboot tests (test_fast_reboot, test_warm_reboot, etc.) already
include this fixture in their signatures.

Fixes: sonic-net#22795

Signed-off-by: Rustiqly <[email protected]>
@mssonicbld
Copy link
Collaborator

/azp run

@rustiqly
Copy link
Contributor Author

@copilot review

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes a pytest fixture mismatch in tests/platform_tests/test_advanced_reboot.py so the “fast reboot from other vendor” advanced-reboot test can correctly use the ASIC/DB consistency checker, aligning it with the other advanced reboot tests.

Changes:

  • Add the missing consistency_checker_provider fixture parameter to test_fast_reboot_from_other_vendor so the variable passed into get_advanced_reboot() is the actual fixture instance (not a fixture function definition).

You can also share your feedback on Copilot code review. Take the survey.

Copy link
Collaborator

@yxieca yxieca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI agent on behalf of Ying. Reviewed; no issues found.

Copy link
Collaborator

@yxieca yxieca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI agent on behalf of Ying. Reviewed; no issues found.

Copy link
Collaborator

@yxieca yxieca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI agent on behalf of Ying. Reviewed; no issues found.

@yxieca
Copy link
Collaborator

yxieca commented Mar 18, 2026

AI agent on behalf of Ying.

Issues found:

  • Found 'test_' prefix in paths; avoid test_ for fixtures

@yxieca
Copy link
Collaborator

yxieca commented Mar 19, 2026

Apologies for the duplicate review/comment noise earlier. We've fixed the automation to prevent repeat approvals/comments and cleaned up extras where possible.

AI agent on behalf of Ying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: test_fast_reboot_from_other_vendor missing 'consistency_checker_provider' fixture parameter

4 participants