Port consistency checker to 202405 (f2cadae6)#18141
Open
Ryangwaite wants to merge 2 commits intosonic-net:202405from
Open
Port consistency checker to 202405 (f2cadae6)#18141Ryangwaite wants to merge 2 commits intosonic-net:202405from
Ryangwaite wants to merge 2 commits intosonic-net:202405from
Conversation
What is the motivation for this PR? There was a test gap discovered where the ASIC_DB and ASIC itself were inconsistent after an upgrade resulting in traffic being dropped. How did you do it? Created a python fixture called consistency_checker_provider that can be injected into any test and used to call the consistency_checker utility. How did you verify/test it? Tested on an internal A->B upgrade scenario. Any platform specific information? Currently only supports Arista x86_64-arista_7060_cx32s and x86_64-arista_7260cx3_64 platforms and versions 202305 and 202311. The ConsistencyCheckerProvider.is_consistency_check_supported will return True for a supported combination. Other platforms and versions may very well work they just haven't been tested yet. To try, simply ignore the result of is_consistency_check_supported and carry on with the test.
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Ryangwaite
force-pushed
the
port-consistency-checker-to-202405
branch
from
fcb5fd8 to
1ff61a7
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Ryangwaite
force-pushed
the
port-consistency-checker-to-202405
branch
from
1ff61a7 to
4c31b59
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…c-net#16877) Description of PR Summary: Added consistency checker to all relevant advanced-reboot cases and added minor improvements including: Ignoring NULL values in ASIC querying Logging ASIC/DB inconsistencies Fixes # (issue)
Ryangwaite
force-pushed
the
port-consistency-checker-to-202405
branch
from
4c31b59 to
244d2b3
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
This is a manual backport of the consistency-checker utility from master at commit f2cadae. This includes the following two PR's:
Manually backported due to conflicts.
Type of change
Back port request
Approach
What is the motivation for this PR?
There were conflicts in creating cherry-pick backport PR's hence this manual approach.
How did you do it?
Cherry-picked and resolved conflicts manually.
How did you verify/test it?
TODO: Testing on branch. The feature in general has also been tested thoroughly on master.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation