Skip to content

[pytest] Fix RunAnsibleModuleFail import statement#1670

Closed
msosyak wants to merge 1 commit intosonic-net:masterfrom
msosyak:fix_ssh_utils
Closed

[pytest] Fix RunAnsibleModuleFail import statement#1670
msosyak wants to merge 1 commit intosonic-net:masterfrom
msosyak:fix_ssh_utils

Conversation

@msosyak
Copy link
Contributor

@msosyak msosyak commented May 13, 2020

Description of PR

Summary:
Fixes # (#1669)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Approach

How did you do it?

Fix import statement

How did you verify/test it?

Run fast-reboot test

Any platform specific information?

N/A

Supported testbed topology if it's a new test case?

Documentation

@yxieca
Copy link
Collaborator

yxieca commented May 13, 2020

#1671 might be fixing this issue and the issue with markers. I think this issue was caused by adding __ init __.py into tests folder, which is reverted by my change.

Copy link
Collaborator

@yxieca yxieca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's confirm if we still need this change after #1671 ?

@msosyak
Copy link
Contributor Author

msosyak commented May 14, 2020

Issue #1669 fixed by #1671, so close this as redundant

@msosyak msosyak closed this May 14, 2020
@msosyak msosyak deleted the fix_ssh_utils branch May 14, 2020 13:55
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
…or 202012 (sonic-net#7105)

sonic-swss
* [nbrmgrd] added function to parse IP address from APP_DB (sonic-net#1672)
* [MUX/PFCWD] Use in_ports for acls instead of seperate ACL table (sonic-net#1670)
* [mux] VS test for neigh, route and fdb (sonic-net#1656)
* [Dynamic buffer calc] Bug fix: Remove PGs from an administratively down port. (sonic-net#1652)
* spell check fixes (sonic-net#1630)

sonic-utilities
* [reboot]: Stop mux before reboot on dual ToR (sonic-net#1500)
* [config] Disable/enable container monitoring when stopping/starting services (sonic-net#1499)
* Add 'show' and 'clear' command for PG drop (sonic-net#1461)
* [CLI][techsupport] Add NOOP option for commands that did not have that option (sonic-net#1445)
* [202012][reload] Improve reload by using sonic.target (sonic-net#1509)

Signed-off-by: Danny Allen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[pytest] prepare_testbed_ssh_keys did not catch RunAnsibleModuleFail exeption

2 participants