Skip to content

Fix single-lossless-prio test failure due to border-case.#15533

Closed
rraghav-cisco wants to merge 1 commit intosonic-net:masterfrom
rraghav-cisco:single_lossless_prio
Closed

Fix single-lossless-prio test failure due to border-case.#15533
rraghav-cisco wants to merge 1 commit intosonic-net:masterfrom
rraghav-cisco:single_lossless_prio

Conversation

@rraghav-cisco
Copy link
Contributor

Description of PR

Summary:
test_multidut_pfcwd_basic_with_snappi.py::test_pfcwd_basic_single_lossless_prio was failing due to a corner case with the error "packet loss is not in range of [.75, 1]. This PR addresses the parameters that can push the lossrate to the requried range.
@sdszhang for viz.

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@rraghav-cisco
Copy link
Contributor Author

Logs from the run

=========================================================================================================================== PASSES ===========================================================================================================================
______________________________________________________________________________________________ test_pfcwd_basic_single_lossless_prio[multidut_port_info0-True] _______________________________________________________________________________________________
______________________________________________________________________________________________ test_pfcwd_basic_single_lossless_prio[multidut_port_info0-False] ______________________________________________________________________________________________
______________________________________________________________________________________________ test_pfcwd_basic_single_lossless_prio[multidut_port_info1-True] _______________________________________________________________________________________________
______________________________________________________________________________________________ test_pfcwd_basic_single_lossless_prio[multidut_port_info1-False] ______________________________________________________________________________________________
------------------------------------------------------------------------------- generated xml file: /run_logs/ixia/import_error/2024-11-13-07-29-06/tr_2024-11-13-07-29-06.xml -------------------------------------------------------------------------------
INFO:root:Can not get Allure report URL. Please check logs
------------------------------------------------------------------------------------------------------------------- live log sessionfinish -------------------------------------------------------------------------------------------------------------------
07:37:55 __init__.pytest_terminal_summary         L0067 INFO   | Can not get Allure report URL. Please check logs
================================================================================================================== short test summary info ===================================================================================================================
PASSED snappi_tests/multidut/pfcwd/test_multidut_pfcwd_basic_with_snappi.py::test_pfcwd_basic_single_lossless_prio[multidut_port_info0-True]
PASSED snappi_tests/multidut/pfcwd/test_multidut_pfcwd_basic_with_snappi.py::test_pfcwd_basic_single_lossless_prio[multidut_port_info0-False]
PASSED snappi_tests/multidut/pfcwd/test_multidut_pfcwd_basic_with_snappi.py::test_pfcwd_basic_single_lossless_prio[multidut_port_info1-True]
PASSED snappi_tests/multidut/pfcwd/test_multidut_pfcwd_basic_with_snappi.py::test_pfcwd_basic_single_lossless_prio[multidut_port_info1-False]
========================================================================================================= 4 passed, 7 warnings in 526.86s (0:08:46) ==========================================================================================================
sonic@ixia-sonic-mgmt-whitebox:/data/tests$ 

@rraghav-cisco
Copy link
Contributor Author

@auspham , @sdszhang : I don't understand the failure reason for the azp run. May I know what is the reason? Thanks.

@sdszhang
Copy link
Contributor

@auspham , @sdszhang : I don't understand the failure reason for the azp run. May I know what is the reason? Thanks.
the PR pipeline needs to rerun sometimes. I have triggered a rerun. in the future, you can add a comment /azpw run to rerun it.

if trigger_pfcwd:
""" Large enough to trigger PFC watchdog """
pfc_storm_dur_sec = ceil(detect_time_sec + poll_interval_sec + 0.1)
pfc_storm_dur_sec = 4 * ceil(detect_time_sec + poll_interval_sec + 0.1)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you pls explain why this change is needed? I believe it's passing in T0/T1 with this settings.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sdszhang , we discussed internally. Based on the discussion, I will try this script without changes, and see how close it gets to failure. I will update the PR based on the findings.

@sdszhang
Copy link
Contributor

sdszhang commented Dec 2, 2024

close as duplicated with #15801

@sdszhang sdszhang closed this Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants