Fix single-lossless-prio test failure due to border-case.#15533
Closed
rraghav-cisco wants to merge 1 commit intosonic-net:masterfrom
Closed
Fix single-lossless-prio test failure due to border-case.#15533rraghav-cisco wants to merge 1 commit intosonic-net:masterfrom
rraghav-cisco wants to merge 1 commit intosonic-net:masterfrom
Conversation
Contributor
Author
|
Logs from the run |
Contributor
Author
Contributor
sdszhang
reviewed
Nov 13, 2024
| if trigger_pfcwd: | ||
| """ Large enough to trigger PFC watchdog """ | ||
| pfc_storm_dur_sec = ceil(detect_time_sec + poll_interval_sec + 0.1) | ||
| pfc_storm_dur_sec = 4 * ceil(detect_time_sec + poll_interval_sec + 0.1) |
Contributor
There was a problem hiding this comment.
could you pls explain why this change is needed? I believe it's passing in T0/T1 with this settings.
Contributor
Author
There was a problem hiding this comment.
@sdszhang , we discussed internally. Based on the discussion, I will try this script without changes, and see how close it gets to failure. I will update the PR based on the findings.
Contributor
|
close as duplicated with #15801 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
test_multidut_pfcwd_basic_with_snappi.py::test_pfcwd_basic_single_lossless_prio was failing due to a corner case with the error "packet loss is not in range of [.75, 1]. This PR addresses the parameters that can push the lossrate to the requried range.
@sdszhang for viz.
Type of change
Back port request
Approach
What is the motivation for this PR?
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation