Skip to content

Fix single-lossless-prio test failure due to border-case. #15533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rraghav-cisco wants to merge 1 commit into from
Closed

Fix single-lossless-prio test failure due to border-case. #15533

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/snappi_tests/multidut/pfcwd/files/pfcwd_multidut_basic_helper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,10 +100,10 @@ def run_pfcwd_basic_test(api,

if trigger_pfcwd:
""" Large enough to trigger PFC watchdog """
pfc_storm_dur_sec = ceil(detect_time_sec + poll_interval_sec + 0.1)
pfc_storm_dur_sec = 4 * ceil(detect_time_sec + poll_interval_sec + 0.1)
Copy link
Contributor

@sdszhang sdszhang Nov 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you pls explain why this change is needed? I believe it's passing in T0/T1 with this settings.

Copy link
Contributor Author

@rraghav-cisco rraghav-cisco Nov 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sdszhang , we discussed internally. Based on the discussion, I will try this script without changes, and see how close it gets to failure. I will update the PR based on the findings.


flow1_delay_sec = restore_time_sec / 2 + WARM_UP_TRAFFIC_DUR
flow1_dur_sec = pfc_storm_dur_sec
flow1_dur_sec = pfc_storm_dur_sec / 2

""" Start data traffic 2 after PFC is restored """
flow2_delay_sec = pfc_storm_dur_sec + restore_time_sec + \
Expand Down