Skip to content

To skip LLDP pytest on ptf32 and ptf64 topology.#1466

Merged
lguohan merged 1 commit intosonic-net:masterfrom
chenkelly:lldp_skip_ptf32_ptf64
Mar 19, 2020
Merged

To skip LLDP pytest on ptf32 and ptf64 topology.#1466
lguohan merged 1 commit intosonic-net:masterfrom
chenkelly:lldp_skip_ptf32_ptf64

Conversation

@chenkelly
Copy link
Contributor

Description of PR

The ptf32 and ptf64 topology don't use VMs which run LLDP.
DUT will not get any LLDP neighbor and test case will fail due to LLDP neighbor checking.
According to testcases.yml, lldp don't support on ptf32 and ptf64 topology.
To check topology and then skip LLDP pytest on ptf32 and ptf64 topology.

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • [] Testbed and Framework(new/improvement)
  • [] Test case(new/improvement)

Approach

How did you do it?

To skip LLDP pytest on ptf32 and ptf64 topology.

How did you verify/test it?

 sonic@81f2fbf4efaf:~/sonic-mgmt/tests$ py.test --inventory=lab --host-pattern=2-9_ptf32  --module-path ../ansible/library/ --testbed=2-9_ptf32 --testbed_file=testbed.csv test_lldp.py --log-level=INFO -vvvv --show-capture=stdout --duration=0
 =============================================================================================== test session starts ===============================================================================================
 platform linux2 -- Python 2.7.12, pytest-4.6.7, py-1.8.0, pluggy-0.13.1 -- /usr/bin/python
 cachedir: .pytest_cache
 ansible: 2.8.7
 rootdir: /var/sonic/sonic-mgmt/tests, inifile: pytest.ini
 plugins: ansible-2.2.2, pyfakefs-3.7.1, csv-2.0.2
 collected 2 items   

 test_lldp.py::test_lldp SKIPPED                                                                                                                                                                             [ 50%]
 test_lldp.py::test_lldp_neighbor SKIPPED                                                                                                                                                                    [100%]     

 ============================================================================================= slowest test durations ==============================================================================================
 1.58s setup    test_lldp.py::test_lldp
 0.00s setup    test_lldp.py::test_lldp_neighbor
 0.00s teardown test_lldp.py::test_lldp_neighbor
 0.00s teardown test_lldp.py::test_lldp
 ============================================================================================ 2 skipped in 1.60 seconds ============================================================================================

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

The ptf32 and ptf64 topology don't use VMs which run LLDP.
DUT will not get any LLDP neighbor and test case will fail due to LLDP neighbor checking.
According to testcases.yml, lldp don't support on ptf32 and ptf64 topology.
To check topology and then skip LLDP pytest on ptf32 and ptf64 topology.
@lguohan lguohan merged commit c4c0226 into sonic-net:master Mar 19, 2020
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
Including below commits:

36f7332 2021-01-14 | modified ERR log to NOTICE log for FDB notification failure after VLAN delete (sonic-net#1595) [madhanmellanox]
c21c883 2021-01-12 | [ci]: download artifacts from master branch build (sonic-net#1597) [lguohan]
a1d03a4 2021-01-12 | [fgnhgorch] Match mode changes for Fine Grained ECMP (sonic-net#1565) [anish-n]
1b65f3d 2021-01-12 | [ci]: use sonicbld pool (sonic-net#1594) [lguohan]
48ae866 2021-01-12 | [pfcwd] Update PFC storm detection logic for Mellanox platforms (sonic-net#1586) [Volodymyr Samotiy]
850001f 2021-01-12 | [FPMSYNCD] Evpn/Vxlan related changes to support FRR7.5(sonic-net#1585) [KISHORE KUNAL]
64ca9bb 2021-01-12 | [ci]: only copy artifacts when build is successful (sonic-net#1590) [lguohan]
17d0dae 2021-01-11 | [Fdborch] Fix for arm compilation (sonic-net#1592) [Prince Sunny]
693a02c 2021-01-08 | [gearbox] Add support for "hwinfo" field (sonic-net#1547) [Baptiste Covolato]
7e3b2c6 2021-01-09 | [Evpn Warmreboot] Added Dependancy check logic in VrfMgr (sonic-net#1466) [nkelapur]
a960e2e 2021-01-09 | [Orchagent]: FdbOrch changes for EVPN VXLAN (sonic-net#1275) [Pankaj Jain]
097cfda 2021-01-08 | [swss test] update setup guide for swss tests (sonic-net#1582) [Ying Xie]
b42253a 2021-01-05 | Fix for armhf build (sonic-net#1580) [Qi Luo]
d8c1465 2021-01-05 | [dvs] Update/disable DVS tests with new FRR 7.5 behavior (sonic-net#1579) [Danny Allen]
f6c7422 2021-01-05 | ASIC internal temperature sensors support (sonic-net#1517) [Santhosh Kumar T]
0aa9ef2 2021-01-01 | Simply by auto iterator type, because we will tune the return types of library functions (sonic-net#1577) [Qi Luo]
773238b 2020-12-31 | [build]: Fix format string for size_t (sonic-net#1576) [Qi Luo]
7ba4e43 2020-12-30 | [fgnhgorch] add warm reboot support for fgnhg (sonic-net#1538) [weixchen1215]
4cf6617 2020-12-30 | [ci]: add build for arm64 and armhf (sonic-net#1572) [lguohan]
6ebc0ed 2020-12-29 | [ci]: add azure-pipeline for amd64 (sonic-net#1571) [lguohan]
e32b9d0 2020-12-29 | [FDBSYNCD] Added pytest for fdbsyncd (sonic-net#1560) [KISHORE KUNAL]
a43f6be 2020-12-30 | [crm] Add support for snat, dnat and ipmc crm resources (sonic-net#1511) [Prabhu Sreenivasan]
7fc3888 2020-12-29 | PY Test script for EVPN L3 VxLAN (sonic-net#1330) [Tapash Das]
6eb36d9 2020-12-27 | vlanmgr changes related to EVPN VxLan warmboot (sonic-net#1460) [anilkpan]

Signed-off-by: Guohan Lu <[email protected]>
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
…ux-kernel submodules (sonic-net#7064)

sonic-swss
* Add table descriptions for dynamic buffer calculation to the documents (sonic-net#1664)
* Remove vxlanmgrd dependency on orchagent (sonic-net#1647)

sonic-utilities
* [show] Fix 'show mac' output, when FDB entry with Vlan 1 is present (sonic-net#1368)
* [warm-reboot]: Check empty key before issuing redis hget (sonic-net#1496)
* [generate-dump] Remove Arista specific logic (sonic-net#1482)
* [warm-reboot]: added automated recover for ISSU file (sonic-net#1466)
* [warm-reboot] Check if warm restart flag is set when issuing a warm-reboot (sonic-net#1460)
* [show][config] fix for show/config muxcable hwmode model value; fix show/config muxcable return codes; (sonic-net#1494)

sonic-linux-kernel
* [net] Disable prio and cls cgroups to make working cgroup2 sock matching (sonic-net#198)

Signed-off-by: Danny Allen <[email protected]>
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
988d8e172e7140174bfa21d3b86c9685c7127a14 (HEAD -> 201911, origin/201911) [warm-reboot]: added automated recover for ISSU file (sonic-net#1466)
913df4e2faf6e70e0aebb01d81f79694a6d8ee20 [201911] Warmboot script improvements - timeout in exec and disable service-autorestart (sonic-net#2149)

Signed-off-by: Abhishek Dosi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants