Removed test cases already converted to pytest.#1330
Removed test cases already converted to pytest.#1330yvolynets-mlnx wants to merge 1 commit intosonic-net:masterfrom
Conversation
Signed-off-by: Yuriy Volynets <[email protected]>
|
What is the reason to remove these wrappers??? |
As those tests are just calling pytest based test cases, there is no reason to keep pytest test cases and reference to them. |
|
@yvolynets-mlnx how about backward compatibility? how about other vendors that uses this for the regression? Also, please provide the reference to the HLD or other documentation that describes new steps to run TCs. |
Updated description |
Still, these changes make code inconsistent with https://github.com/Azure/sonic-mgmt/blob/master/ansible/doc/README.testbed.Example.md This breaks backward compatibility without a benefit. |
|
Ansible wrappers should not be removed. |
Including below commits: 36f7332 2021-01-14 | modified ERR log to NOTICE log for FDB notification failure after VLAN delete (sonic-net#1595) [madhanmellanox] c21c883 2021-01-12 | [ci]: download artifacts from master branch build (sonic-net#1597) [lguohan] a1d03a4 2021-01-12 | [fgnhgorch] Match mode changes for Fine Grained ECMP (sonic-net#1565) [anish-n] 1b65f3d 2021-01-12 | [ci]: use sonicbld pool (sonic-net#1594) [lguohan] 48ae866 2021-01-12 | [pfcwd] Update PFC storm detection logic for Mellanox platforms (sonic-net#1586) [Volodymyr Samotiy] 850001f 2021-01-12 | [FPMSYNCD] Evpn/Vxlan related changes to support FRR7.5(sonic-net#1585) [KISHORE KUNAL] 64ca9bb 2021-01-12 | [ci]: only copy artifacts when build is successful (sonic-net#1590) [lguohan] 17d0dae 2021-01-11 | [Fdborch] Fix for arm compilation (sonic-net#1592) [Prince Sunny] 693a02c 2021-01-08 | [gearbox] Add support for "hwinfo" field (sonic-net#1547) [Baptiste Covolato] 7e3b2c6 2021-01-09 | [Evpn Warmreboot] Added Dependancy check logic in VrfMgr (sonic-net#1466) [nkelapur] a960e2e 2021-01-09 | [Orchagent]: FdbOrch changes for EVPN VXLAN (sonic-net#1275) [Pankaj Jain] 097cfda 2021-01-08 | [swss test] update setup guide for swss tests (sonic-net#1582) [Ying Xie] b42253a 2021-01-05 | Fix for armhf build (sonic-net#1580) [Qi Luo] d8c1465 2021-01-05 | [dvs] Update/disable DVS tests with new FRR 7.5 behavior (sonic-net#1579) [Danny Allen] f6c7422 2021-01-05 | ASIC internal temperature sensors support (sonic-net#1517) [Santhosh Kumar T] 0aa9ef2 2021-01-01 | Simply by auto iterator type, because we will tune the return types of library functions (sonic-net#1577) [Qi Luo] 773238b 2020-12-31 | [build]: Fix format string for size_t (sonic-net#1576) [Qi Luo] 7ba4e43 2020-12-30 | [fgnhgorch] add warm reboot support for fgnhg (sonic-net#1538) [weixchen1215] 4cf6617 2020-12-30 | [ci]: add build for arm64 and armhf (sonic-net#1572) [lguohan] 6ebc0ed 2020-12-29 | [ci]: add azure-pipeline for amd64 (sonic-net#1571) [lguohan] e32b9d0 2020-12-29 | [FDBSYNCD] Added pytest for fdbsyncd (sonic-net#1560) [KISHORE KUNAL] a43f6be 2020-12-30 | [crm] Add support for snat, dnat and ipmc crm resources (sonic-net#1511) [Prabhu Sreenivasan] 7fc3888 2020-12-29 | PY Test script for EVPN L3 VxLAN (sonic-net#1330) [Tapash Das] 6eb36d9 2020-12-27 | vlanmgr changes related to EVPN VxLan warmboot (sonic-net#1460) [anilkpan] Signed-off-by: Guohan Lu <[email protected]>
3 participants
Signed-off-by: Yuriy Volynets [email protected]
Description of PR
Summary: Removed ansible test cases which are already converted to pytest:
acltb.yml
bgp_speaker.yml
dhcp_relay.yml
lldp.yml
snmp/cpu.yml
snmp/interfaces.yml
snmp/lldp.yml
snmp/pfc_counters.yml
snmp/queues.yml
Fixes # (issue)
Type of change
How to run test cases:
py.test acl -k "acl and not egress and not reboot and not port_toggle" --testbed DEVICE-TOPO --inventory ../ansible/inventory --testbed_file ../ansible/testbed.csv --host-pattern=DEVICE-TOPO --module-path=../ansible/library -v
py.test --pdb --inventory ../ansible/inventory --host-pattern DEVICE --module-path ../ansible/library/ --testbed DEVICE-TOPO --testbed_file ../ansible/testbed.csv --show-capture=no --log-cli-level info -ra -vvvvv test_bgp_speaker.py
py.test --pdb --inventory ../ansible/inventory --host-pattern DEVICE --module-path ../ansible/library/ --testbed DEVICE-TOPO --testbed_file ../ansible/testbed.csv --show-capture=no --log-cli-level info -ra -vvvvv test_dhcp_relay.py
py.test --pdb --inventory ../ansible/inventory --host-pattern DEVICE --module-path ../ansible/library/ --testbed DEVICE-TOPO --testbed_file ../ansible/testbed.csv --show-capture=no --log-cli-level info -ra -vvvvv test_lldp.py
py.test --pdb --inventory ../ansible/inventory --host-pattern DEVICE --module-path ../ansible/library/ --testbed DEVICE-TOPO --testbed_file ../ansible/testbed.csv --show-capture=no --log-cli-level info -ra -vvvvv snmp/test_snmp_cpu.py
For rest SNMP just specify appropriate file path
Approach
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation