Changed validation that device was rebooted in case of reboot#7064
Closed
ppikh wants to merge 1 commit intosonic-net:masterfrom
Closed
Changed validation that device was rebooted in case of reboot#7064ppikh wants to merge 1 commit intosonic-net:masterfrom
ppikh wants to merge 1 commit intosonic-net:masterfrom
Conversation
Previously we did check by checking time on DUT before reboot and after reboot by checking "uptime since" time. Then we checked that "uptime since" time bigger than time from DUT before reboot. In some cases afte reboot time on DUT may be not synchronized as result "uptime since" after reboot may be less than time before reboot DUT. Now we do check using next logic: Get DUT uptime in seconds before reboot, get DUT uptime in seconds after reboot - then check that uptime after reboot less than uptime before reboot Signed-off-by: Petro Pikh <[email protected]>
Collaborator
|
@ppikh please check failures |
Contributor
Author
|
Hi @liat-grozovik , Build not found. Could you please re-trigger tests? |
Contributor
Author
|
/azpw |
prgeor
reviewed
Jan 12, 2023
Contributor
Author
|
/azpw run Azure.sonic-mgmt |
Collaborator
|
/AzurePipelines run Azure.sonic-mgmt |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
@prgeor kindly reminder to review this one following your prev comments |
Collaborator
|
@prgeor kindly reminder to review following comments handling |
Contributor
@liat-grozovik how is my comment resolved?
|
Contributor
Author
|
Hi @prgeor - seems like this fix does not make sense. It looks like was some some issue in our lab. Now this test passing with original code. Sorry for you time. Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Petro Pikh [email protected]
Description of PR
Changed validation that device was rebooted in case of reboot
Previously we did check by checking time on DUT before reboot and after reboot by checking "uptime since" time. Then we checked that "uptime since" time bigger than time from DUT before reboot. In some cases after reboot time on DUT may be not synchronized as result "uptime since" after reboot may be less than time before reboot DUT.
Now we do check using next logic: Get DUT uptime in seconds before reboot, get DUT uptime in seconds after reboot - then check that uptime after reboot less than uptime before reboot
Summary: Changed validation that device was rebooted in case of reboot
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Previously we did check by checking time on DUT before reboot and after reboot by checking "uptime since" time. Then we checked that "uptime since" time bigger than time from DUT before reboot. In some cases after reboot time on DUT may be not synchronized as result "uptime since" after reboot may be less than time before reboot DUT.
How did you do it?
Now we do check using next logic: Get DUT uptime in seconds before reboot, get DUT uptime in seconds after reboot - then check that uptime after reboot less than uptime before reboot
How did you verify/test it?
Executed reboot tests(fast-reboot, warm-reboot)
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation